From 006660c374ef0a33db173c88eeb5455004584e15 Mon Sep 17 00:00:00 2001 From: SGWebFreelancer Date: Thu, 18 Jan 2024 12:05:31 +0800 Subject: [PATCH] Change the to try resources --- .../readwritethread/ReadWriteBlockingQueue.java | 12 +----------- .../baeldung/readwritethread/ReadWriteThread.java | 12 +++--------- 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/core-java-modules/core-java-io-5/src/main/java/com/baeldung/readwritethread/ReadWriteBlockingQueue.java b/core-java-modules/core-java-io-5/src/main/java/com/baeldung/readwritethread/ReadWriteBlockingQueue.java index 06e5fd7946..b518b455ea 100644 --- a/core-java-modules/core-java-io-5/src/main/java/com/baeldung/readwritethread/ReadWriteBlockingQueue.java +++ b/core-java-modules/core-java-io-5/src/main/java/com/baeldung/readwritethread/ReadWriteBlockingQueue.java @@ -65,9 +65,7 @@ class FileConsumer implements Runnable { @Override public void run() { - BufferedWriter writer = null; - try { - writer = new BufferedWriter(new FileWriter(outputFileName)); + try (BufferedWriter writer = new BufferedWriter(new FileWriter(outputFileName))) { String line; while ((line = queue.poll()) != null) { writer.write(line); @@ -75,14 +73,6 @@ class FileConsumer implements Runnable { } } catch (IOException e) { e.printStackTrace(); - } finally { - if (writer != null) { - try { - writer.close(); - } catch (IOException e) { - e.printStackTrace(); - } - } } } } \ No newline at end of file diff --git a/core-java-modules/core-java-io-5/src/main/java/com/baeldung/readwritethread/ReadWriteThread.java b/core-java-modules/core-java-io-5/src/main/java/com/baeldung/readwritethread/ReadWriteThread.java index 7248e0f99d..ba8c5547e3 100644 --- a/core-java-modules/core-java-io-5/src/main/java/com/baeldung/readwritethread/ReadWriteThread.java +++ b/core-java-modules/core-java-io-5/src/main/java/com/baeldung/readwritethread/ReadWriteThread.java @@ -11,15 +11,11 @@ public class ReadWriteThread { Thread thread = new Thread(new Runnable() { @Override public void run() { - try { - FileReader fileReader = new FileReader(filePath); - BufferedReader bufferedReader = new BufferedReader(fileReader); + try (BufferedReader bufferedReader = new BufferedReader(new FileReader(filePath))) { String line; while ((line = bufferedReader.readLine()) != null) { System.out.println(line); } - bufferedReader.close(); - fileReader.close(); } catch (IOException e) { e.printStackTrace(); } @@ -32,10 +28,8 @@ public class ReadWriteThread { Thread thread = new Thread(new Runnable() { @Override public void run() { - try { - FileWriter fileWriter = new FileWriter(filePath); - fileWriter.write(content); - fileWriter.close(); + try (FileWriter fileWriter = new FileWriter("file.txt")) { + fileWriter.write("Hello, world!"); } catch (IOException e) { e.printStackTrace(); }