From 01e95b4df01ac5c3a43e92fcd9a5787bf34f8c97 Mon Sep 17 00:00:00 2001
From: Krzysztof Woyke <krzysztof.woyke.sp@lhsystems.com>
Date: Sat, 20 Mar 2021 20:43:49 +0100
Subject: [PATCH] JAVA-4669: Code cleanup for UsingOptional

---
 .../main/java/com/baeldung/nulls/UsingOptional.java   |  4 ++--
 .../com/baeldung/nulls/UsingOptionalUnitTest.java     | 11 ++++-------
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/patterns/design-patterns-behavioral/src/main/java/com/baeldung/nulls/UsingOptional.java b/patterns/design-patterns-behavioral/src/main/java/com/baeldung/nulls/UsingOptional.java
index 099864589c..03bed5fedf 100644
--- a/patterns/design-patterns-behavioral/src/main/java/com/baeldung/nulls/UsingOptional.java
+++ b/patterns/design-patterns-behavioral/src/main/java/com/baeldung/nulls/UsingOptional.java
@@ -38,8 +38,8 @@ public class UsingOptional {
             .flatMap(list -> list.stream().findFirst());
     }
 
-    private Optional<List> getOptionalList() {
-        return Optional.ofNullable(getList());
+    private Optional<List<String>> getOptionalList() {
+        return Optional.of(getList());
     }
 
     private String doSomething(boolean processed) {
diff --git a/patterns/design-patterns-behavioral/src/test/java/com/baeldung/nulls/UsingOptionalUnitTest.java b/patterns/design-patterns-behavioral/src/test/java/com/baeldung/nulls/UsingOptionalUnitTest.java
index 73797d48c8..576d2bacf3 100644
--- a/patterns/design-patterns-behavioral/src/test/java/com/baeldung/nulls/UsingOptionalUnitTest.java
+++ b/patterns/design-patterns-behavioral/src/test/java/com/baeldung/nulls/UsingOptionalUnitTest.java
@@ -19,22 +19,22 @@ class UsingOptionalUnitTest {
     }
 
     @Test
-    public void whenArgIsFalse_thenReturnEmptyResponse() {
+    void whenArgIsFalse_thenReturnEmptyResponse() {
         Optional<Object> result = dataObject.process(false);
 
         assertFalse(result.isPresent());
     }
 
     @Test
-    public void whenArgIsTrue_thenReturnValidResponse() {
+    void whenArgIsTrue_thenReturnValidResponse() {
         Optional<Object> result = dataObject.process(true);
 
         assertTrue(result.isPresent());
     }
 
     @Test
-    public void whenArgIsFalse_thenChainResponseAndThrowException() {
-        assertThrows(Exception.class, () -> dataObject.process(false).orElseThrow(() -> new Exception()));
+    void whenArgIsFalse_thenChainResponseAndThrowException() {
+        assertThrows(Exception.class, () -> dataObject.process(false).orElseThrow(Exception::new));
     }
 
     @Test()
@@ -51,7 +51,4 @@ class UsingOptionalUnitTest {
     void whenOptionalListFirst_returnsEmptyOptional() {
         assertFalse(dataObject.optionalListFirst().isPresent());
     }
-
-
-
 }
\ No newline at end of file