[add-to-immutable-list] replace list.copyof with collections.unmodifiableList

This commit is contained in:
Kai.Yuan 2024-03-20 17:20:04 +01:00
parent 356624bf22
commit 0242528345

View File

@ -4,6 +4,7 @@ import static org.assertj.core.api.Assertions.assertThat;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.Collections;
import java.util.List; import java.util.List;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@ -13,14 +14,14 @@ public class AddElementsToImmutableListUnitTest {
public static <T> List<T> appendAnElement(List<T> immutableList, T element) { public static <T> List<T> appendAnElement(List<T> immutableList, T element) {
List<T> tmpList = new ArrayList<>(immutableList); List<T> tmpList = new ArrayList<>(immutableList);
tmpList.add(element); tmpList.add(element);
return List.copyOf(tmpList); return Collections.unmodifiableList(tmpList);
} }
@SafeVarargs @SafeVarargs
public static <T> List<T> appendElements(List<T> immutableList, T... elements) { public static <T> List<T> appendElements(List<T> immutableList, T... elements) {
List<T> tmpList = new ArrayList<>(immutableList); List<T> tmpList = new ArrayList<>(immutableList);
tmpList.addAll(Arrays.asList(elements)); tmpList.addAll(Arrays.asList(elements));
return List.copyOf(tmpList); return Collections.unmodifiableList(tmpList);
} }
@Test @Test