From 07af5a2687b9f1d4807ca655b3758611faa7c1b0 Mon Sep 17 00:00:00 2001 From: Mladen Savic Date: Thu, 3 Jun 2021 12:26:02 +0200 Subject: [PATCH] insert null into Integer column using JDBC - code improvements --- .../main/java/com/baeldung/insertnull/DBConfig.java | 10 +++------- .../com/baeldung/insertnull/InsertNullUnitTest.java | 10 +++------- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/persistence-modules/core-java-persistence-2/src/main/java/com/baeldung/insertnull/DBConfig.java b/persistence-modules/core-java-persistence-2/src/main/java/com/baeldung/insertnull/DBConfig.java index 391eb0999c..3907434239 100644 --- a/persistence-modules/core-java-persistence-2/src/main/java/com/baeldung/insertnull/DBConfig.java +++ b/persistence-modules/core-java-persistence-2/src/main/java/com/baeldung/insertnull/DBConfig.java @@ -9,22 +9,18 @@ public class DBConfig { private static Connection INSTANCE; - public static Connection getConnection() throws Exception { + public static Connection getConnection() throws SQLException { if (INSTANCE == null) { - Class.forName("org.h2.Driver"); INSTANCE = DriverManager.getConnection("jdbc:h2:mem:insertnull", "user", "password"); createPersonTable(); } return INSTANCE; } - private static void createPersonTable() { - try { - Statement statement = INSTANCE.createStatement(); + private static void createPersonTable() throws SQLException { + try(Statement statement = INSTANCE.createStatement()) { String sql = "CREATE TABLE Person (id INTEGER not null, name VARCHAR(50), lastName VARCHAR(50), age INTEGER, PRIMARY KEY (id))"; statement.executeUpdate(sql); - } catch (SQLException e) { - e.printStackTrace(); } } } diff --git a/persistence-modules/core-java-persistence-2/src/test/java/com/baeldung/insertnull/InsertNullUnitTest.java b/persistence-modules/core-java-persistence-2/src/test/java/com/baeldung/insertnull/InsertNullUnitTest.java index 7004779949..55319c626c 100644 --- a/persistence-modules/core-java-persistence-2/src/test/java/com/baeldung/insertnull/InsertNullUnitTest.java +++ b/persistence-modules/core-java-persistence-2/src/test/java/com/baeldung/insertnull/InsertNullUnitTest.java @@ -1,11 +1,9 @@ package com.baeldung.insertnull; -import org.hamcrest.CoreMatchers; -import org.hamcrest.MatcherAssert; import org.junit.jupiter.api.Test; -import java.sql.Connection; import java.sql.PreparedStatement; +import java.sql.SQLException; import java.sql.Types; import static org.hamcrest.CoreMatchers.equalTo; @@ -16,7 +14,7 @@ public class InsertNullUnitTest { private final String SQL = "INSERT INTO Person VALUES(?,?,?,?)"; @Test - public void givenNewPerson_whenSetNullIsUsed_thenNewRecordIsCreated() throws Exception { + public void givenNewPerson_whenSetNullIsUsed_thenNewRecordIsCreated() throws SQLException { Person person = new Person(1, "John", "Doe", null); try (PreparedStatement preparedStatement = DBConfig.getConnection().prepareStatement(SQL)) { @@ -30,12 +28,11 @@ public class InsertNullUnitTest { int noOfRows = preparedStatement.executeUpdate(); assertThat(noOfRows, equalTo(1)); - } catch (Exception ignored) { } } @Test - public void givenNewPerson_whenSetObjectIsUsed_thenNewRecordIsCreated() throws Exception { + public void givenNewPerson_whenSetObjectIsUsed_thenNewRecordIsCreated() throws SQLException { Person person = new Person(2, "John", "Doe", null); try (PreparedStatement preparedStatement = DBConfig.getConnection().prepareStatement(SQL)) { @@ -46,7 +43,6 @@ public class InsertNullUnitTest { int noOfRows = preparedStatement.executeUpdate(); assertThat(noOfRows, equalTo(1)); - } catch (Exception ignored) { } } }