Fixed review comments

This commit is contained in:
Amitabh Tiwari 2021-03-26 21:03:08 +05:30
parent d010629fd5
commit 0b16b1440b
1 changed files with 7 additions and 9 deletions

View File

@ -35,30 +35,28 @@ public class CountQueryIntegrationTest {
@Test @Test
public void givenValidData_whenSelectCount_thenSucceed() { public void givenValidData_whenSelectCount_thenSucceed() {
int count = dsl.selectCount().from(AUTHOR) int count = dsl.selectCount().from(AUTHOR)
.where(AUTHOR.FIRST_NAME.equalIgnoreCase("Bryan")) .where(AUTHOR.FIRST_NAME.equalIgnoreCase("Bryan"))
.fetchOne(0, int.class); .fetchOne(0, int.class);
Assert.assertEquals(1, count); Assert.assertEquals(1, count);
} }
@Test @Test
public void givenValidData_whenCount_thenSucceed() { public void givenValidData_whenCount_thenSucceed() {
int count = dsl.select(DSL.count()) int count = dsl.select(DSL.count())
.from(AUTHOR).fetchOne(0, int.class); .from(AUTHOR).fetchOne(0, int.class);
Assert.assertEquals(3, count); Assert.assertEquals(3, count);
} }
@Test @Test
public void givenValidData_whenFetchCount_thenSucceed() { public void givenValidData_whenFetchCount_thenSucceed() {
int count = dsl.fetchCount( int count = dsl.fetchCount(DSL.selectFrom(AUTHOR)
DSL.selectFrom(AUTHOR) .where(AUTHOR.FIRST_NAME.equalIgnoreCase("Bryan")));
.where(AUTHOR.FIRST_NAME.equalIgnoreCase("Bryan")));
Assert.assertEquals(1, count); Assert.assertEquals(1, count);
} }
@Test @Test
public void givenValidData_whenFetchCountWithoutCondition_thenSucceed() { public void givenValidData_whenFetchCountWithoutCondition_thenSucceed() {
int count = dsl.fetchCount( int count = dsl.fetchCount(DSL.selectFrom(AUTHOR));
DSL.selectFrom(AUTHOR));
Assert.assertEquals(3, count); Assert.assertEquals(3, count);
} }
@ -90,7 +88,7 @@ public class CountQueryIntegrationTest {
@Test @Test
public void givenValidData_whenCountwithGroupBy_thenSucceed() { public void givenValidData_whenCountwithGroupBy_thenSucceed() {
final Result<Record2<String, Integer>> result = dsl.select(AUTHOR.FIRST_NAME, DSL.count()) final Result<Record2<String, Integer>> result = dsl.select(AUTHOR.FIRST_NAME, DSL.count())
.from(AUTHOR).groupBy(AUTHOR.FIRST_NAME).fetch(); .from(AUTHOR).groupBy(AUTHOR.FIRST_NAME).fetch();
Assert.assertEquals(3, result.size()); Assert.assertEquals(3, result.size());
Assert.assertEquals(result.get(0).get(0), "Bert"); Assert.assertEquals(result.get(0).get(0), "Bert");
Assert.assertEquals(result.get(0).get(1), 1); Assert.assertEquals(result.get(0).get(1), 1);