Adjust config (#3979)

* Adjust config

* Adjust config

* Adjust config

* fix

* fix

* Rename MetricTypeTest

* Rename MetricTypeTest

* Rename MetricTypeTest

* Rename MetricTypeTest

* Install custom pmd jar to local maven repo during maven validate phase, so that it becomes available during project build

* maven install plugin - adding base path

* changed the phase for maven directory plugin to validate to make sure that the base directory variable is available to maven install plugin

* pmd violation flag back to false
This commit is contained in:
Grzegorz Piwowarek 2018-04-13 07:08:55 +02:00 committed by GitHub
parent 23162f16a9
commit 0c0a3cab16
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 51 additions and 16 deletions

2
.gitignore vendored
View File

@ -34,8 +34,6 @@ spring-security-openid/src/main/resources/application.properties
spring-all/*.log
*.jar
SpringDataInjectionDemo/.mvn/wrapper/maven-wrapper.properties
spring-call-getters-using-reflection/.mvn/wrapper/maven-wrapper.properties

BIN
custom-pmd-0.0.1.jar Normal file

Binary file not shown.

View File

@ -3,7 +3,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>org.baeldung.pmd</groupId>
<artifactId>custom-pmd</artifactId>
<version>0.0.1-SNAPSHOT</version>
<version>0.0.1</version>
<packaging>jar</packaging>
<name>custom-pmd</name>
<url>http://maven.apache.org</url>
@ -40,4 +40,4 @@
</plugin>
</plugins>
</build>
</project>
</project>

View File

@ -32,7 +32,7 @@ import com.netflix.servo.monitor.StepCounter;
import com.netflix.servo.monitor.Stopwatch;
import com.netflix.servo.stats.StatsConfig;
public class MetricTypeTest {
public class MetricTypeManualTest {
@Test
public void givenDefaultCounter_whenManipulate_thenCountValid() {

BIN
pmd/custom-pmd-0.0.1.jar Normal file

Binary file not shown.

59
pom.xml
View File

@ -39,7 +39,6 @@
</reporting>
<modules>
<module>custom-pmd</module>
<module>parent-boot-5</module>
<module>asm</module>
<module>atomix</module>
@ -362,7 +361,6 @@
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
@ -371,8 +369,7 @@
<executable>maven</executable>
</configuration>
</plugin>
<plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>${maven-surefire-plugin.version}</version>
@ -388,7 +385,6 @@
</excludes>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
@ -398,7 +394,6 @@
<target>1.8</target>
</configuration>
</plugin>
<!-- TODO till we sort it out
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-pmd-plugin</artifactId>
@ -407,11 +402,11 @@
<dependency>
<groupId>org.baeldung.pmd</groupId>
<artifactId>custom-pmd</artifactId>
<version>0.0.1-SNAPSHOT</version>
<version>0.0.1</version>
</dependency>
</dependencies>
<configuration>
<failurePriority>5</failurePriority> &lt;!&ndash; TODO change to 0 after fixing the project &ndash;&gt;
<failurePriority>5</failurePriority> <!-- TODO change to 0 after fixing the project -->
<aggregate>true</aggregate>
<failOnViolation>false</failOnViolation>
<verbose>true</verbose>
@ -420,7 +415,7 @@
<sourceEncoding>UTF-8</sourceEncoding>
<targetJdk>1.8</targetJdk>
<rulesets>
<ruleset>${user.dir}/baeldung-pmd-rules.xml</ruleset>
<ruleset>${tutorialsproject.basedir}/baeldung-pmd-rules.xml</ruleset>
</rulesets>
</configuration>
<executions>
@ -432,7 +427,49 @@
</execution>
</executions>
</plugin>
-->
<plugin>
<groupId>org.commonjava.maven.plugins</groupId>
<artifactId>directory-maven-plugin</artifactId>
<version>0.3.1</version>
<executions>
<execution>
<id>directories</id>
<goals>
<goal>directory-of</goal>
</goals>
<phase>validate</phase>
<configuration>
<property>tutorialsproject.basedir</property>
<project>
<groupId>com.baeldung</groupId>
<artifactId>parent-modules</artifactId>
</project>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-install-plugin</artifactId>
<version>2.5.1</version>
<configuration>
<groupId>org.baeldung.pmd</groupId>
<artifactId>custom-pmd</artifactId>
<version>0.0.1</version>
<packaging>jar</packaging>
<file>${tutorialsproject.basedir}/custom-pmd-0.0.1.jar</file>
<generatePom>true</generatePom>
</configuration>
<executions>
<execution>
<id>install-jar-lib</id>
<goals>
<goal>install-file</goal>
</goals>
<phase>validate</phase>
</execution>
</executions>
</plugin>
</plugins>
<extensions>
@ -444,4 +481,4 @@
</extensions>
</build>
</project>
</project>