iSharkFly-Docs/java-tutorials
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix suggestions

Browse Source
This commit is contained in:
Lucian Snare 2024-02-08 23:05:59 -05:00
parent ec2a32838e
commit 195a0e06d7
1 changed files with 9 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
core-java-modules/core-java-concurrency-2/src/test/java/com/baeldung/concurrent/completablefuture/CombiningCompletableFuturesUnitTest.java
View File

@ -1,10 +1,6 @@
package com.baeldung.concurrent.completablefuture; package com.baeldung.concurrent.completablefuture;
import static java.util.function.Predicate.isEqual;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.ArgumentMatchers.eq; import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times; import static org.mockito.Mockito.times;
@ -12,29 +8,19 @@ import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Collections;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.concurrent.CompletableFuture; import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;
import java.util.stream.Collectors; import java.util.stream.Collectors;
import java.util.stream.Stream; import java.util.stream.Stream;
import org.junit.Test;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments; import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource; import org.junit.jupiter.params.provider.MethodSource;
import org.mockito.Mock;
public class CombiningCompletableFuturesUnitTest { public class CombiningCompletableFuturesUnitTest {
@Mock Logger logger; private final Logger logger = mock(Logger.class);
@BeforeEach
void setup() {
logger = mock(Logger.class);
}
private static Stream<Arguments> clientData() { private static Stream<Arguments> clientData() {
return Stream.of( return Stream.of(
@ -64,13 +50,16 @@ public class CombiningCompletableFuturesUnitTest {
// When all CompletableFutures are completed (exceptionally or otherwise)... // When all CompletableFutures are completed (exceptionally or otherwise)...
Map<Boolean, List<Long>> resultsByValidity = clientCalls.stream() Map<Boolean, List<Long>> resultsByValidity = clientCalls.stream()
.map(future -> handleFuture(future)) .map(this::handleFuture)
.collect(Collectors.partitioningBy(resourceId -> isValidResponse(resourceId))); .collect(Collectors.partitioningBy(this::isValidResponse));
// Then the returned resource identifiers should match what is expected... // Then the returned resource identifiers should match what is expected...
assertThat(resultsByValidity.getOrDefault(true, List.of()).size()).isEqualTo(successCount); List<Long> validResults = resultsByValidity.getOrDefault(true, List.of());
assertThat(validResults.size()).isEqualTo(successCount);
// And the logger mock should be called once for each exception with the expected error message // And the logger mock should be called once for each exception with the expected error message
assertThat(resultsByValidity.getOrDefault(false, List.of()).size()).isEqualTo(errorCount); List<Long> invalidResults = resultsByValidity.getOrDefault(false, List.of());
assertThat(invalidResults.size()).isEqualTo(errorCount);
verify(logger, times(errorCount)) verify(logger, times(errorCount))
.error(eq("Encountered error: java.lang.IllegalArgumentException: Bad Resource")); .error(eq("Encountered error: java.lang.IllegalArgumentException: Bad Resource"));
} }
@ -86,7 +75,7 @@ public class CombiningCompletableFuturesUnitTest {
*/ */
private Long handleFuture(CompletableFuture<Long> future) { private Long handleFuture(CompletableFuture<Long> future) {
return future return future
.exceptionally(ex -> handleError(ex)) .exceptionally(this::handleError)
.join(); .join();
} }