From 1a5f9567521f2e23c646c9a1352bcfbd05db45dd Mon Sep 17 00:00:00 2001 From: bhandy Date: Fri, 23 Apr 2021 10:25:35 -0400 Subject: [PATCH] BAEL-4844: Fixed exception handling anti-pattern in the aspect. --- .../baeldung/aspectj/classmethodadvice/TracingAspect.aj | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/spring-aop/src/main/java/com/baeldung/aspectj/classmethodadvice/TracingAspect.aj b/spring-aop/src/main/java/com/baeldung/aspectj/classmethodadvice/TracingAspect.aj index c80dcc0a19..20a42940b8 100644 --- a/spring-aop/src/main/java/com/baeldung/aspectj/classmethodadvice/TracingAspect.aj +++ b/spring-aop/src/main/java/com/baeldung/aspectj/classmethodadvice/TracingAspect.aj @@ -13,11 +13,12 @@ public aspect TracingAspect { LOG.trace("Entering " + signature); try { return proceed(); - } catch (Exception e) { - LOG.trace("Exception thrown from " + signature, e); - throw e; } finally { LOG.trace("Exiting " + signature); } } + + after() throwing (Exception e) : traceAnnotatedClasses() { + LOG.trace("Exception thrown from " + thisJoinPoint.getSignature().toShortString(), e); + } }