first review round changes
This commit is contained in:
parent
9873c70dc4
commit
1beacb0ce8
@ -133,7 +133,6 @@ public class LoginControllerIntegrationTest {
|
|||||||
|
|
||||||
@Test
|
@Test
|
||||||
public void partialMocking() {
|
public void partialMocking() {
|
||||||
|
|
||||||
LoginService partialLoginService = new LoginService();
|
LoginService partialLoginService = new LoginService();
|
||||||
partialLoginService.setLoginDao(loginDao);
|
partialLoginService.setLoginDao(loginDao);
|
||||||
loginController.loginService = partialLoginService;
|
loginController.loginService = partialLoginService;
|
||||||
@ -142,24 +141,22 @@ public class LoginControllerIntegrationTest {
|
|||||||
userForm.username = "foo";
|
userForm.username = "foo";
|
||||||
|
|
||||||
new Expectations(partialLoginService) {{
|
new Expectations(partialLoginService) {{
|
||||||
//let's mock loginDao#login() call
|
// let's mock DAO call
|
||||||
loginDao.login(userForm); result = 1;
|
loginDao.login(userForm); result = 1;
|
||||||
|
|
||||||
//no expectation for partialLoginService#login() so that real implementation is used
|
// no expectation for login method so that real implementation is used
|
||||||
|
|
||||||
//mocking partialLoginService#setCurrentUser()
|
// mock setCurrentUser call
|
||||||
partialLoginService.setCurrentUser("foo");
|
partialLoginService.setCurrentUser("foo");
|
||||||
}};
|
}};
|
||||||
|
|
||||||
String login = loginController.login(userForm);
|
String login = loginController.login(userForm);
|
||||||
|
|
||||||
Assert.assertEquals("OK", login);
|
Assert.assertEquals("OK", login);
|
||||||
// verify that mocked partialLoginService#setCurrentUser("foo") is called
|
// verify mocked call
|
||||||
new Verifications() {
|
new Verifications() {{
|
||||||
{
|
|
||||||
partialLoginService.setCurrentUser("foo");
|
partialLoginService.setCurrentUser("foo");
|
||||||
}
|
}};
|
||||||
};
|
|
||||||
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
Loading…
x
Reference in New Issue
Block a user