From 22b7cf7957991602e89824847bd769a12cc18bc2 Mon Sep 17 00:00:00 2001
From: Eugen Paraschiv <hanriseldon@gmail.com>
Date: Sun, 15 Jul 2018 09:51:16 +0300
Subject: [PATCH] plugin cleanup

---
 bootique/pom.xml              |  5 +++++
 core-java-8/pom.xml           | 13 -------------
 core-java-concurrency/pom.xml | 13 -------------
 core-java-sun/pom.xml         |  4 +++-
 disruptor/pom.xml             |  5 +++++
 java-numbers/pom.xml          | 15 ---------------
 jmh/pom.xml                   |  2 ++
 jooby/pom.xml                 |  3 +++
 undertow/pom.xml              |  6 +++++-
 9 files changed, 23 insertions(+), 43 deletions(-)

diff --git a/bootique/pom.xml b/bootique/pom.xml
index 6b2a0e2b99..880b9a516f 100644
--- a/bootique/pom.xml
+++ b/bootique/pom.xml
@@ -52,16 +52,21 @@
 
     <build>
         <plugins>
+
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-shade-plugin</artifactId>
+                <version>${maven-shade-plugin.version}</version>
             </plugin>
+
         </plugins>
     </build>
 
     <properties>
         <main.class>com.baeldung.bootique.App</main.class>
         <bootique-bom.version>0.23</bootique-bom.version>
+
+        <maven-shade-plugin.version>2.4.3</maven-shade-plugin.version>
     </properties>
 
 </project>
\ No newline at end of file
diff --git a/core-java-8/pom.xml b/core-java-8/pom.xml
index fdb8fa4b6e..dee0634951 100644
--- a/core-java-8/pom.xml
+++ b/core-java-8/pom.xml
@@ -128,19 +128,6 @@
                 </executions>
             </plugin>
 
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-jar-plugin</artifactId>
-                <configuration>
-                    <archive>
-                        <manifest>
-                            <addClasspath>true</addClasspath>
-                            <classpathPrefix>libs/</classpathPrefix>
-                            <mainClass>org.baeldung.executable.ExecutableMavenJar</mainClass>
-                        </manifest>
-                    </archive>
-                </configuration>
-            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
diff --git a/core-java-concurrency/pom.xml b/core-java-concurrency/pom.xml
index 9d2bc39d5d..eb81983a2a 100644
--- a/core-java-concurrency/pom.xml
+++ b/core-java-concurrency/pom.xml
@@ -75,19 +75,6 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-jar-plugin</artifactId>
-                <configuration>
-                    <archive>
-                        <manifest>
-                            <addClasspath>true</addClasspath>
-                            <classpathPrefix>libs/</classpathPrefix>
-                            <mainClass>org.baeldung.executable.ExecutableMavenJar</mainClass>
-                        </manifest>
-                    </archive>
-                </configuration>
-            </plugin>
             
         </plugins>
     </build>
diff --git a/core-java-sun/pom.xml b/core-java-sun/pom.xml
index 52842903aa..f489f3b030 100644
--- a/core-java-sun/pom.xml
+++ b/core-java-sun/pom.xml
@@ -185,6 +185,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>
+                <version>${maven-jar-plugin.version}</version>
                 <configuration>
                     <archive>
                         <manifest>
@@ -295,6 +296,7 @@
         <protonpack.version>1.13</protonpack.version>
         <streamex.version>0.6.5</streamex.version>
         <vavr.version>0.9.0</vavr.version>
+        <spring-web.version>4.3.4.RELEASE</spring-web.version>
 
         <!-- testing -->
         <assertj.version>3.6.1</assertj.version>
@@ -303,7 +305,7 @@
         <!-- maven plugins -->
         <maven-surefire-plugin.version>2.19.1</maven-surefire-plugin.version>
         <sun-tools.version>1.8.0</sun-tools.version>
-        <spring-web.version>4.3.4.RELEASE</spring-web.version>
+        <maven-jar-plugin.version>3.0.2</maven-jar-plugin.version>
     </properties>
 
 </project>
\ No newline at end of file
diff --git a/disruptor/pom.xml b/disruptor/pom.xml
index 039d7f9c2d..6f3a8d9bfd 100644
--- a/disruptor/pom.xml
+++ b/disruptor/pom.xml
@@ -55,6 +55,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>
+                <version>${maven-jar-plugin.version}</version>
                 <configuration>
                     <archive>
                         <manifest>
@@ -91,6 +92,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-shade-plugin</artifactId>
+                <version>${maven-shade-plugin.version}</version>
                 <executions>
                     <execution>
                         <goals>
@@ -133,6 +135,9 @@
         <!-- testing -->
         <testng.version>6.10</testng.version>
         <assertj.version>3.6.1</assertj.version>
+        
+        <maven-shade-plugin.version>2.4.3</maven-shade-plugin.version>
+        <maven-jar-plugin.version>3.0.2</maven-jar-plugin.version>
     </properties>
 
 </project>
\ No newline at end of file
diff --git a/java-numbers/pom.xml b/java-numbers/pom.xml
index 8e8cc9f15e..a9fb556517 100644
--- a/java-numbers/pom.xml
+++ b/java-numbers/pom.xml
@@ -100,21 +100,6 @@
                 </executions>
             </plugin>
 
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-jar-plugin</artifactId>
-                <version>${maven-jar-plugin.version}</version>
-                <configuration>
-                    <archive>
-                        <manifest>
-                            <addClasspath>true</addClasspath>
-                            <classpathPrefix>libs/</classpathPrefix>
-                            <mainClass>org.baeldung.executable.ExecutableMavenJar</mainClass>
-                        </manifest>
-                    </archive>
-                </configuration>
-            </plugin>
-
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-javadoc-plugin</artifactId>
diff --git a/jmh/pom.xml b/jmh/pom.xml
index 45ad0d426f..1e01809fe6 100644
--- a/jmh/pom.xml
+++ b/jmh/pom.xml
@@ -33,6 +33,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>
+                <version>${maven-jar-plugin.version}</version>
                 <configuration>
                     <archive>
                         <manifest>
@@ -46,6 +47,7 @@
 
     <properties>
         <openjdk.jmh.version>1.19</openjdk.jmh.version>
+        <maven-jar-plugin.version>3.0.2</maven-jar-plugin.version>
     </properties>
 
 </project>
\ No newline at end of file
diff --git a/jooby/pom.xml b/jooby/pom.xml
index 5bd7f27d88..2867b7f4b6 100644
--- a/jooby/pom.xml
+++ b/jooby/pom.xml
@@ -44,6 +44,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-shade-plugin</artifactId>
+                <version>${maven-shade-plugin.version}</version>
             </plugin>
         </plugins>
     </build>
@@ -52,6 +53,8 @@
         <jooby.version>1.1.3</jooby.version>
         <application.class>com.baeldung.jooby.App</application.class>
         <jooby-jedis.version>1.1.3</jooby-jedis.version>
+        
+        <maven-shade-plugin.version>2.4.3</maven-shade-plugin.version>
     </properties>
 
 </project>
diff --git a/undertow/pom.xml b/undertow/pom.xml
index 15388e278c..d000956aee 100644
--- a/undertow/pom.xml
+++ b/undertow/pom.xml
@@ -1,7 +1,7 @@
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
     <modelVersion>4.0.0</modelVersion>
-    
+
     <groupId>com.baeldung.undertow</groupId>
     <artifactId>undertow</artifactId>
     <packaging>jar</packaging>
@@ -29,6 +29,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-shade-plugin</artifactId>
+                <version>${maven-shade-plugin.version}</version>
                 <executions>
                     <execution>
                         <phase>package</phase>
@@ -41,6 +42,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>
+                <version>${maven-jar-plugin.version}</version>
                 <configuration>
                     <archive>
                         <manifest>
@@ -54,6 +56,8 @@
 
     <properties>
         <undertow-servlet.version>1.4.18.Final</undertow-servlet.version>
+        <maven-shade-plugin.version>2.4.3</maven-shade-plugin.version>
+        <maven-jar-plugin.version>3.0.2</maven-jar-plugin.version>
     </properties>
 
 </project>
\ No newline at end of file