BAEL-183 Updated after review

core-java/src/test/java/com/baeldung/test/comparison/DependentTests.java

@@ -17,13 +17,13 @@ public class DependentTests {
     }
 
     @Test
-	public void validEmailTest() {
+    public void givenEmail_ifValid_thenTrue() {
         boolean valid = emailValidator.validate(validEmail);
         Assert.assertEquals(valid, true);
     }
 
-	@Test(dependsOnMethods={"validEmailTest"})
+    @Test(dependsOnMethods = { "givenEmail_ifValid_thenTrue" })
-	public void validateLogin() {
+    public void givenValidEmail_whenLoggedin_thenTrue() {
         boolean valid = loginValidator.validate();
         Assert.assertEquals(valid, true);
     }

core-java/src/test/java/com/baeldung/test/comparison/DivisibilityTest.java

@@ -0,0 +1,21 @@
+package com.baeldung.test.comparison;
+
+import static org.junit.Assert.assertEquals;
+
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+public class DivisibilityTest {
+
+    private static int number;
+
+    @BeforeClass
+    public static void setup() {
+        number = 40;
+    }
+
+    @Test
+    public void givenNumber_whenDivisiblebyTwo_thenCorrect() {
+        assertEquals(number % 2, 0);
+    }
+}

core-java/src/test/java/com/baeldung/test/comparison/MyParameterisedUnitTest.java

@@ -27,13 +27,12 @@ public class MyParameterisedUnitTest {
 
     @Parameters
     public static Collection<Object[]> data() {
-        Object[][] data 
+        Object[][] data = new Object[][] { { "Peter" }, { "Sam" }, { "Tim" }, { "Lucy" } };
-          = new Object[][] { { "Peter" }, { "Sam" }, { "Tim" }, { "Lucy" } };
         return Arrays.asList(data);
     }
 
     @Test
-    public void pushNameTest() {
+    public void givenName_whenValidLength_thenTrue() {
         boolean valid = nameCheck.nameCheck(name);
         Assert.assertEquals(valid, true);
     }

core-java/src/test/java/com/baeldung/test/comparison/MyParameterisedUnitTestNg.java

@@ -17,21 +17,18 @@ public class MyParameterisedUnitTestNg {
 
     @Test(enabled = false)
     @Parameters({ "num", "expectedResult" })
-	public void parameterCheckTest(int number,boolean expectedResult) {
+    public void givenNumber_ifPrime_thenCorrect(int number, boolean expectedResult) {
-	    Assert.assertEquals(expectedResult,
+        Assert.assertEquals(expectedResult, primeNumberChecker.validate(number));
-	    primeNumberChecker.validate(number));
     }
 
     @DataProvider(name = "test1")
     public static Object[][] primeNumbers() {
-	    return new Object[][] {
+        return new Object[][] { { 2, true }, { 6, false }, { 19, true }, { 22, false }, { 23, true } };
-	      {2, true}, {6, false}, {19, true}, {22, false}, {23, true}};
     }
 
     @Test(dataProvider = "test1")
-	public void testPrimeNumberChecker(Integer inputNumber, Boolean expectedResult) {
+    public void givenNumber_whenPrime_thenCorrect(Integer inputNumber, Boolean expectedResult) {
-	    Assert.assertEquals(expectedResult,
+        Assert.assertEquals(expectedResult, primeNumberChecker.validate(inputNumber));
-	    primeNumberChecker.validate(inputNumber));
     }
 
     @Test(dataProvider = "myDataProvider")
@@ -65,15 +62,19 @@ class PrimeNumberCheck{
 class User {
     private String name;
     private int age;
+
     public String getName() {
         return name;
     }
+
     public void setName(String name) {
         this.name = name;
     }
+
     public int getAge() {
         return age;
     }
+
     public void setAge(int age) {
         this.age = age;
     }

core-java/src/test/java/com/baeldung/test/comparison/MyTest1.java

@@ -1,12 +0,0 @@
-package com.baeldung.test.comparison;
-
-import org.junit.Test;
-
-public class MyTest1 {
-
-	@Test
-	public void suiteTest1() {
-
-	}
-
-}

core-java/src/test/java/com/baeldung/test/comparison/MyTest2.java

@@ -1,10 +0,0 @@
-package com.baeldung.test.comparison;
-
-import org.junit.Test;
-
-public class MyTest2 {
-	@Test
-	public void suiteTest2() {
-
-	}
-}

core-java/src/test/java/com/baeldung/test/comparison/StringCaseTest.java

@@ -0,0 +1,22 @@
+package com.baeldung.test.comparison;
+
+import static org.junit.Assert.assertEquals;
+
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+public class StringCaseTest {
+
+    private static String data;
+
+    @BeforeClass
+    public static void setup() {
+        data = "HELLO BAELDUNG";
+    }
+
+    @Test
+    public void givenString_whenAllCaps_thenCorrect() {
+        assertEquals(data.toUpperCase(), data);
+    }
+
+}

core-java/src/test/java/com/baeldung/test/comparison/SuiteTest.java

@@ -4,10 +4,7 @@ import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
 
 @RunWith(Suite.class)
-@Suite.SuiteClasses({
+@Suite.SuiteClasses({ StringCaseTest.class, DivisibilityTest.class })
-  MyTest1.class,
+public class SuiteTest {
-  MyTest2.class
-})
-public class MyTest5 {
 
 }

core-java/src/test/java/com/baeldung/test/comparison/SummationServiceTest.java

@@ -1,5 +1,6 @@
 package com.baeldung.test.comparison;
 
+import java.security.Security;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -38,23 +39,21 @@ public class SummationServiceTest {
 
     @Test
     public void givenNumbers_sumEquals_thenCorrect() {
-        int sum = 0;
+        int sum = numbers.stream()
-        for (int num : numbers)
+            .reduce(0, Integer::sum);
-            sum += num;
         Assert.assertEquals(6, sum);
     }
 
     @Ignore
     @Test
     public void givenEmptyList_sumEqualsZero_thenCorrect() {
-		 int sum = 0;
+        int sum = numbers.stream()
-	        for (int num : numbers)
+            .reduce(0, Integer::sum);
-	            sum += num;
         Assert.assertEquals(6, sum);
     }
 
     @Test(expected = ArithmeticException.class)
-    public void calculateWithException() { 
+    public void givenNumber_whenThrowsException_thenCorrect() {
         int i = 1 / 0;
     }
 }

core-java/src/test/java/com/baeldung/test/comparison/SummationServiceTestTestNg.java

@@ -64,27 +64,21 @@ public class SummationServiceTestTestNg extends TestNG{
 
     @Test(groups = "positive_tests", enabled = false)
     public void givenNumbers_sumEquals_thenCorrect() {
-        int sum = 0;
+        int sum = numbers.stream().reduce(0, Integer::sum);
-        for (int num : numbers)
-            sum += num;
         Assert.assertEquals(sum, 6);
     }
 
     @Test(groups = "negative_tests")
     public void givenEmptyList_sumEqualsZero_thenCorrect() {
-		 int sum = 0;
+        int sum = numbers.stream().reduce(0, Integer::sum);
-	        for (int num : numbers)
-	            sum += num;
         Assert.assertEquals(0, sum);
     }
 
     @Test(groups = "regression")
     public void givenNegativeNumber_sumLessthanZero_thenCorrect() {
-	    int sum = 0;
+        int sum = numbers.stream().reduce(0, Integer::sum);
-	    for (int num : numbers)
+        Assert.assertTrue(sum < 0);
-	        sum += num;
+        ;
-	    System.out.println(sum);
-	    Assert.assertTrue(sum<0);;
     }
 
     @Test(groups = "sanity")
@@ -93,9 +87,8 @@ public class SummationServiceTestTestNg extends TestNG{
     }
 
     @Test(expectedExceptions = ArithmeticException.class)
-	public void calculateWithException() { 
+    public void givenNumber_whenThrowsException_thenCorrect() {
         int i = 1 / 0;
     }
 
-	
 }

core-java/src/test/java/com/baeldung/test/comparison/TimeOutTest.java

@@ -4,7 +4,8 @@ import org.testng.annotations.Test;
 
 public class TimeOutTest {
     @Test(timeOut = 1000, enabled = false)
-	public void testInfinity() {
+    public void givenExecution_takeMoreTime_thenFail() {
-	    while (true);
+        while (true)
+            ;
     }
 }

core-java/src/test/java/temp/SummationServiceTest.java

@@ -0,0 +1,49 @@
+package temp;
+
+import static org.junit.Assert.*;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.junit.After;
+import org.junit.AfterClass;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import junit.framework.Assert;
+
+public class SummationServiceTest {
+
+    private static List<Integer> numbers;
+
+    @BeforeClass
+    public static void initialize() {
+        numbers = new ArrayList<>();
+    }
+
+    @AfterClass
+    public static void tearDown() {
+        numbers = null;
+    }
+
+    @Before
+    public void runBeforeEachTest() {
+        numbers.add(1);
+        numbers.add(2);
+        numbers.add(3);
+    }
+
+    @After
+    public void runAfterEachTest() {
+        numbers.clear();
+    }
+
+    @Test
+    public void givenNumbers_sumEquals_thenCorrect() {
+        int sum = 0;
+        for (int num : numbers)
+            sum += num;
+        assertEquals(6, sum);
+    }
+}