Implementing Code Review comments

persistence-modules/spring-data-cosmosdb/pom.xml

@@ -16,6 +16,7 @@
 
   <properties>
 	<java.version>1.8</java.version>
+	<cosmodb.version>2.3.0</cosmodb.version>
   </properties>
 
   <dependencies>
@@ -26,14 +27,17 @@
 	<dependency>
 	  <groupId>com.microsoft.azure</groupId>
 	  <artifactId>spring-data-cosmosdb</artifactId>
-			<version>2.3.0</version>
+	  <version>${cosmodb.version}</version>
 	</dependency>
-
     <dependency>
 	  <groupId>org.springframework.boot</groupId>
 	  <artifactId>spring-boot-starter-test</artifactId>
 	  <scope>test</scope>
 	</dependency>
+	<dependency>
+	  <groupId>org.projectlombok</groupId>
+	  <artifactId>lombok</artifactId>
+	</dependency>
   </dependencies>
 
   <build>

persistence-modules/spring-data-cosmosdb/src/main/java/com/baeldung/spring/data/cosmosdb/controller/ProductController.java

@@ -22,9 +22,13 @@ import java.util.Optional;
 @RequestMapping("/products")
 public class ProductController {
 
-    @Autowired
     private ProductService productService;
 
+    @Autowired
+    public ProductController(ProductService productService) {
+        this.productService = productService;
+    }
+
     @PostMapping
     @ResponseStatus(HttpStatus.CREATED)
     public void create(@RequestBody Product product) {
@@ -46,8 +50,8 @@ public class ProductController {
         return productService.findProductByName(name);
     }
 
-    @GetMapping(value = "/category/{category}")
+    @GetMapping(value = "/category")
-    public List<Product> getByCategory(@PathVariable String category) {
+    public List<Product> getByCategory(@RequestParam String category) {
         return productService.getProductsOfCategory(category);
     }
 

persistence-modules/spring-data-cosmosdb/src/main/java/com/baeldung/spring/data/cosmosdb/entity/Product.java

@@ -5,6 +5,11 @@ import com.microsoft.azure.spring.data.cosmosdb.core.mapping.PartitionKey;
 
 import org.springframework.data.annotation.Id;
 
+import lombok.Getter;
+import lombok.Setter;
+
+@Getter
+@Setter
 @Document(collection = "products")
 public class Product {
 
@@ -18,41 +23,4 @@ public class Product {
     @PartitionKey
     private String productCategory;
 
-    public String getProductid() {
-        return productid;
-    }
-
-    public void setProductid(String productid) {
-        this.productid = productid;
-    }
-
-    public String getProductName() {
-        return productName;
-    }
-
-    public void setProductName(String productName) {
-        this.productName = productName;
-    }
-
-    public String getProductCategory() {
-        return productCategory;
-    }
-
-    public void setProductCategory(String productCategory) {
-        this.productCategory = productCategory;
-    }
-
-    public double getPrice() {
-        return price;
-    }
-
-    public void setPrice(double price) {
-        this.price = price;
-    }
-
-    @Override
-    public String toString() {
-        return "Product [productid=" + productid + ", productName=" + productName + ", price=" + price + ", productCategory=" + productCategory + "]";
-    }
-
 }

persistence-modules/spring-data-cosmosdb/src/main/java/com/baeldung/spring/data/cosmosdb/service/ProductService.java

@@ -25,8 +25,7 @@ public class ProductService {
     }
 
     public List<Product> getProductsOfCategory(String category) {
-        List<Product> products = repository.findByProductCategory(category);
+        return repository.findByProductCategory(category);
-        return products;
     }
 
     public void saveProduct(Product product) {

persistence-modules/spring-data-cosmosdb/src/test/java/com/baeldung/spring/data/cosmosdb/AzurecosmodbApplicationManualTest.java

@@ -14,7 +14,7 @@ import java.util.Optional;
 //Uncomment this when configured URI and keys for Azure Cosmos DB in application.properties
 //to run the integration test
 //@SpringBootTest
-public class AzurecosmodbApplicationIntegrationTest {
+public class AzurecosmodbApplicationManualTest {
 
     @Autowired
     ProductRepository productRepository;
@@ -29,11 +29,9 @@ public class AzurecosmodbApplicationIntegrationTest {
         product.setPrice(110.0);
         product.setProductName("Blue Shirt");
 
-        // Uncomment these lines when configured URI and keys for Azure Cosmos DB in application.properties
+        productRepository.save(product);
-        // to run the integration test
+        Optional<Product> retrievedProduct = productRepository.findById("1001", new PartitionKey("Shirt"));
-        // productRepository.save(product);
+        Assert.notNull(retrievedProduct, "Retrieved Product is Null");
-        // Optional<Product> retrievedProduct = productRepository.findById("1001", new PartitionKey("Shirt"));
-        // Assert.notNull(retrievedProduct, "Retrieved Product is Null");
 
     }