BAEL-1979 Removed the System.out.println() statements and converted the assertTrue to assertEquals wherever possible.

This commit is contained in:
Sandip 2018-07-30 01:52:40 +05:30
parent 388645a34c
commit 2ac1ccbbb9
4 changed files with 33 additions and 32 deletions

View File

@ -4,7 +4,8 @@ public class Contact {
private String type; private String type;
private Integer number; private int number;
public String getType() { public String getType() {
return type; return type;
@ -14,11 +15,11 @@ public class Contact {
this.type = type; this.type = type;
} }
public Integer getNumber() { public int getNumber() {
return number; return number;
} }
public void setNumber(Integer number) { public void setNumber(int number) {
this.number = number; this.number = number;
} }

View File

@ -6,7 +6,7 @@ public class Customer {
private String firstName; private String firstName;
private String lastName; private String lastName;
private Integer age; private int age;
private List<Contact> contactDetails; private List<Contact> contactDetails;
private Address homeAddress; private Address homeAddress;
@ -26,11 +26,11 @@ public class Customer {
this.lastName = lastName; this.lastName = lastName;
} }
public Integer getAge() { public int getAge() {
return age; return age;
} }
public void setAge(Integer age) { public void setAge(int age) {
this.age = age; this.age = age;
} }

View File

@ -23,7 +23,6 @@ public class JavaToYAMLSerializationUnitTest {
Yaml yaml = new Yaml(); Yaml yaml = new Yaml();
StringWriter writer = new StringWriter(); StringWriter writer = new StringWriter();
yaml.dump(data, writer); yaml.dump(data, writer);
System.out.println(writer.toString());
String expectedYaml = "name: Silenthand Olleander\nrace: Human\ntraits: [ONE_HAND, ONE_EYE]\n"; String expectedYaml = "name: Silenthand Olleander\nrace: Human\ntraits: [ONE_HAND, ONE_EYE]\n";
assertEquals(expectedYaml, writer.toString()); assertEquals(expectedYaml, writer.toString());
} }
@ -48,7 +47,6 @@ public class JavaToYAMLSerializationUnitTest {
customer.setFirstName("Greg"); customer.setFirstName("Greg");
customer.setLastName("McDowell"); customer.setLastName("McDowell");
Yaml yaml = new Yaml(); Yaml yaml = new Yaml();
System.out.println(yaml.dumpAs(customer, Tag.MAP, null));
String expectedYaml = "{age: 45, contactDetails: null, firstName: Greg, homeAddress: null, lastName: McDowell}\n"; String expectedYaml = "{age: 45, contactDetails: null, firstName: Greg, homeAddress: null, lastName: McDowell}\n";
assertEquals(expectedYaml, yaml.dumpAs(customer, Tag.MAP, null)); assertEquals(expectedYaml, yaml.dumpAs(customer, Tag.MAP, null));
} }

View File

@ -1,20 +1,15 @@
package com.baeldung.snakeyaml; package com.baeldung.snakeyaml;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
import java.io.InputStream;
import java.util.Date;
import java.util.Map;
import org.junit.Test; import org.junit.Test;
import org.yaml.snakeyaml.TypeDescription; import org.yaml.snakeyaml.TypeDescription;
import org.yaml.snakeyaml.Yaml; import org.yaml.snakeyaml.Yaml;
import org.yaml.snakeyaml.constructor.Constructor; import org.yaml.snakeyaml.constructor.Constructor;
import com.baeldung.snakeyaml.Contact; import java.io.InputStream;
import com.baeldung.snakeyaml.Customer; import java.util.Date;
import java.util.Map;
import static org.junit.Assert.*;
public class YAMLToJavaDeserialisationUnitTest { public class YAMLToJavaDeserialisationUnitTest {
@ -25,6 +20,9 @@ public class YAMLToJavaDeserialisationUnitTest {
.getClassLoader() .getClassLoader()
.getResourceAsStream("yaml/customer.yaml"); .getResourceAsStream("yaml/customer.yaml");
Map<String, Object> obj = yaml.load(inputStream); Map<String, Object> obj = yaml.load(inputStream);
assertEquals("John", obj.get("firstName"));
assertEquals("Doe", obj.get("lastName"));
assertEquals(20, obj.get("age"));
System.out.println(obj); System.out.println(obj);
} }
@ -35,6 +33,9 @@ public class YAMLToJavaDeserialisationUnitTest {
.getClassLoader() .getClassLoader()
.getResourceAsStream("yaml/customer.yaml"); .getResourceAsStream("yaml/customer.yaml");
Customer customer = yaml.load(inputStream); Customer customer = yaml.load(inputStream);
assertEquals("John", customer.getFirstName());
assertEquals("Doe", customer.getLastName());
assertEquals(20, customer.getAge());
System.out.println(customer); System.out.println(customer);
} }
@ -45,6 +46,9 @@ public class YAMLToJavaDeserialisationUnitTest {
.getClassLoader() .getClassLoader()
.getResourceAsStream("yaml/customer_with_type.yaml"); .getResourceAsStream("yaml/customer_with_type.yaml");
Customer customer = yaml.load(inputStream); Customer customer = yaml.load(inputStream);
assertEquals("John", customer.getFirstName());
assertEquals("Doe", customer.getLastName());
assertEquals(20, customer.getAge());
System.out.println(customer); System.out.println(customer);
} }
@ -53,9 +57,9 @@ public class YAMLToJavaDeserialisationUnitTest {
Yaml yaml = new Yaml(); Yaml yaml = new Yaml();
Map<Object, Object> document = yaml.load("3.0: 2018-07-22"); Map<Object, Object> document = yaml.load("3.0: 2018-07-22");
assertNotNull(document); assertNotNull(document);
assertTrue(document.size() == 1); assertEquals(1, document.size());
assertTrue(document.containsKey(Double.valueOf(3.0))); assertTrue(document.containsKey(3.0d));
assertTrue(document.get(Double.valueOf(3.0)) instanceof Date); assertTrue(document.get(3.0d) instanceof Date);
} }
@Test @Test
@ -68,22 +72,21 @@ public class YAMLToJavaDeserialisationUnitTest {
assertNotNull(customer); assertNotNull(customer);
assertEquals("John", customer.getFirstName()); assertEquals("John", customer.getFirstName());
assertEquals("Doe", customer.getLastName()); assertEquals("Doe", customer.getLastName());
assertTrue(customer.getAge() == 31); assertEquals(31, customer.getAge());
assertNotNull(customer.getContactDetails()); assertNotNull(customer.getContactDetails());
assertTrue(customer.getContactDetails() assertEquals(2, customer.getContactDetails().size());
.size() == 2);
assertEquals("mobile", customer.getContactDetails() assertEquals("mobile", customer.getContactDetails()
.get(0) .get(0)
.getType()); .getType());
assertTrue(customer.getContactDetails() assertEquals(123456789,customer.getContactDetails()
.get(0) .get(0)
.getNumber() == 123456789); .getNumber());
assertEquals("landline", customer.getContactDetails() assertEquals("landline", customer.getContactDetails()
.get(1) .get(1)
.getType()); .getType());
assertTrue(customer.getContactDetails() assertEquals(456786868, customer.getContactDetails()
.get(1) .get(1)
.getNumber() == 456786868); .getNumber());
assertNotNull(customer.getHomeAddress()); assertNotNull(customer.getHomeAddress());
assertEquals("Xyz, DEF Street", customer.getHomeAddress() assertEquals("Xyz, DEF Street", customer.getHomeAddress()
.getLine()); .getLine());
@ -103,10 +106,9 @@ public class YAMLToJavaDeserialisationUnitTest {
assertNotNull(customer); assertNotNull(customer);
assertEquals("John", customer.getFirstName()); assertEquals("John", customer.getFirstName());
assertEquals("Doe", customer.getLastName()); assertEquals("Doe", customer.getLastName());
assertTrue(customer.getAge() == 31); assertEquals(31, customer.getAge());
assertNotNull(customer.getContactDetails()); assertNotNull(customer.getContactDetails());
assertTrue(customer.getContactDetails() assertEquals(2, customer.getContactDetails().size());
.size() == 2);
assertEquals("mobile", customer.getContactDetails() assertEquals("mobile", customer.getContactDetails()
.get(0) .get(0)
.getType()); .getType());
@ -126,7 +128,7 @@ public class YAMLToJavaDeserialisationUnitTest {
count++; count++;
assertTrue(object instanceof Customer); assertTrue(object instanceof Customer);
} }
assertTrue(count == 2); assertEquals(2, count);
} }
} }