diff --git a/spring-rest/pom.xml b/spring-rest/pom.xml index 3c23f1bca7..ec4b50bfa8 100644 --- a/spring-rest/pom.xml +++ b/spring-rest/pom.xml @@ -54,7 +54,7 @@ commons-fileupload commons-fileupload - 1.3.2 + ${commons-fileupload.version} @@ -85,7 +85,7 @@ com.thoughtworks.xstream xstream - 1.4.8 + ${xstream.version} @@ -99,7 +99,7 @@ org.apache.commons commons-lang3 - 3.5 + ${commons-lang3.version} @@ -171,18 +171,18 @@ com.google.protobuf protobuf-java - 3.1.0 + ${protobuf-java.version} com.googlecode.protobuf-java-format protobuf-java-format - 1.4 + ${protobuf-java-format.version} com.esotericsoftware kryo - 4.0.0 + ${kryo.version} @@ -337,38 +337,20 @@ - - - - 4.3.11.Final - 5.1.40 - - - 5.2.2.Final - + 1.3.2 + 4.0.0 + 1.4 + 3.1.0 + 3.5 + 1.4.9 + 20.0 - 3.4 - - - 1.3 - 4.12 - 1.10.19 - - 4.4.1 - 4.5 - 2.9.0 - - 1.7.13 - 1.1.3 - - 3.6.0 - 2.6 - 2.19.1 1.6.0 + 3.0.4 3.4.1 @@ -380,7 +362,7 @@ org.codehaus.mojo findbugs-maven-plugin - 3.0.4 + ${findbugs-maven-plugin.version} Max FindDeadLocalStores,FindNullDeref diff --git a/spring-rest/src/test/java/org/baeldung/okhttp/OkHttpMiscLiveTest.java b/spring-rest/src/test/java/org/baeldung/okhttp/OkHttpMiscLiveTest.java index e6b3cc87b0..6ab485ee14 100644 --- a/spring-rest/src/test/java/org/baeldung/okhttp/OkHttpMiscLiveTest.java +++ b/spring-rest/src/test/java/org/baeldung/okhttp/OkHttpMiscLiveTest.java @@ -4,6 +4,7 @@ import static org.baeldung.client.Consts.APPLICATION_PORT; import java.io.File; import java.io.IOException; +import java.net.SocketTimeoutException; import java.util.concurrent.Executors; import java.util.concurrent.ScheduledExecutorService; import java.util.concurrent.TimeUnit; @@ -32,7 +33,7 @@ public class OkHttpMiscLiveTest { client = new OkHttpClient(); } - @Test + @Test(expected = SocketTimeoutException.class) public void whenSetRequestTimeout_thenFail() throws IOException { final OkHttpClient clientWithTimeout = new OkHttpClient.Builder().readTimeout(1, TimeUnit.SECONDS).build(); diff --git a/spring-rest/src/test/java/org/baeldung/web/controller/redirect/RedirectControllerIntegrationTest.java b/spring-rest/src/test/java/org/baeldung/web/controller/redirect/RedirectControllerIntegrationTest.java index b31bfcf5ec..c604db596a 100644 --- a/spring-rest/src/test/java/org/baeldung/web/controller/redirect/RedirectControllerIntegrationTest.java +++ b/spring-rest/src/test/java/org/baeldung/web/controller/redirect/RedirectControllerIntegrationTest.java @@ -1,7 +1,6 @@ package org.baeldung.web.controller.redirect; import static org.hamcrest.CoreMatchers.equalTo; -import static org.hamcrest.CoreMatchers.nullValue; import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get; import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.flash; import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.forwardedUrl; @@ -51,7 +50,7 @@ public class RedirectControllerIntegrationTest { @Test public void whenRedirectOnUrlWithUsingRedirectAttributes_thenStatusRedirectionAndRedirectedOnUrlAndAddedAttributeToFlashScope() throws Exception { mockMvc.perform(get("/redirectWithRedirectAttributes")).andExpect(status().is3xxRedirection()).andExpect(flash().attribute("flashAttribute", equalTo("redirectWithRedirectAttributes"))) - .andExpect(model().attribute("attribute", equalTo("redirectWithRedirectAttributes"))).andExpect(model().attribute("flashAttribute", equalTo(nullValue()))).andExpect(redirectedUrl("redirectedUrl?attribute=redirectWithRedirectAttributes")); + .andExpect(model().attribute("attribute", equalTo("redirectWithRedirectAttributes"))).andExpect(model().attribute("flashAttribute", equalTo(null))).andExpect(redirectedUrl("redirectedUrl?attribute=redirectWithRedirectAttributes")); } @Test