From 34f4a6bdb9d8eab7af2eb2d842ce854034520cee Mon Sep 17 00:00:00 2001 From: mmchsusan Date: Thu, 12 Jul 2018 13:22:05 -0400 Subject: [PATCH] Bael-1965: using awaitility in test (#4691) * how to trigger and stop scheduled batch job * Replace thread.sleep to awaitility tool in integration testing --- spring-batch/pom.xml | 8 ++++ .../batchscheduler/SpringBatchScheduler.java | 16 +++---- .../SpringBatchSchedulerIntegrationTest.java | 42 +++++++++---------- 3 files changed, 37 insertions(+), 29 deletions(-) diff --git a/spring-batch/pom.xml b/spring-batch/pom.xml index 9a7e9b7f57..cfd725b2bd 100644 --- a/spring-batch/pom.xml +++ b/spring-batch/pom.xml @@ -52,6 +52,13 @@ opencsv ${opencsv.version} + + + org.awaitility + awaitility + ${awaitility.version} + test + @@ -59,6 +66,7 @@ 4.0.0.RELEASE 3.15.1 4.1 + 3.1.1 diff --git a/spring-batch/src/main/java/org/baeldung/batchscheduler/SpringBatchScheduler.java b/spring-batch/src/main/java/org/baeldung/batchscheduler/SpringBatchScheduler.java index edb9b7cfa5..1beeb6b2bf 100644 --- a/spring-batch/src/main/java/org/baeldung/batchscheduler/SpringBatchScheduler.java +++ b/spring-batch/src/main/java/org/baeldung/batchscheduler/SpringBatchScheduler.java @@ -6,7 +6,7 @@ import java.util.List; import java.util.Map; import java.util.concurrent.ScheduledFuture; import java.util.concurrent.atomic.AtomicBoolean; - +import java.util.concurrent.atomic.AtomicInteger; import org.baeldung.batchscheduler.model.Book; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -45,7 +45,7 @@ public class SpringBatchScheduler { private AtomicBoolean enabled = new AtomicBoolean(true); - private Date currentLaunchDate; + private AtomicInteger batchRunCounter = new AtomicInteger(0); private final Map> scheduledTasks = new IdentityHashMap<>(); @@ -60,18 +60,14 @@ public class SpringBatchScheduler { Date date = new Date(); logger.debug("scheduler starts at " + date); if (enabled.get()) { - currentLaunchDate = date; - JobExecution jobExecution = jobLauncher().run(job(), new JobParametersBuilder().addDate("launchDate", currentLaunchDate) + JobExecution jobExecution = jobLauncher().run(job(), new JobParametersBuilder().addDate("launchDate", date) .toJobParameters()); + batchRunCounter.incrementAndGet(); logger.debug("Batch job ends with status as " + jobExecution.getStatus()); } logger.debug("scheduler ends "); } - public Date getCurrentLaunchDate() { - return currentLaunchDate; - } - public void stop() { enabled.set(false); } @@ -169,4 +165,8 @@ public class SpringBatchScheduler { }; } + public AtomicInteger getBatchRunCounter() { + return batchRunCounter; + } + } diff --git a/spring-batch/src/test/java/org/baeldung/batchscheduler/SpringBatchSchedulerIntegrationTest.java b/spring-batch/src/test/java/org/baeldung/batchscheduler/SpringBatchSchedulerIntegrationTest.java index ef825b900f..8927421ac5 100644 --- a/spring-batch/src/test/java/org/baeldung/batchscheduler/SpringBatchSchedulerIntegrationTest.java +++ b/spring-batch/src/test/java/org/baeldung/batchscheduler/SpringBatchSchedulerIntegrationTest.java @@ -1,60 +1,60 @@ package org.baeldung.batchscheduler; -import java.util.Date; - import org.junit.Assert; import org.junit.Test; import org.junit.runner.RunWith; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.context.ApplicationContext; -import org.springframework.scheduling.TaskScheduler; import org.springframework.scheduling.annotation.ScheduledAnnotationBeanPostProcessor; import org.springframework.test.context.ContextConfiguration; import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; +import static org.awaitility.Awaitility.await; +import static java.util.concurrent.TimeUnit.*; + @RunWith(SpringJUnit4ClassRunner.class) @ContextConfiguration(classes = SpringBatchScheduler.class) public class SpringBatchSchedulerIntegrationTest { - private static final int TIMER = 3000; - @Autowired private ApplicationContext context; @Test public void stopJobsWhenSchedulerDisabled() throws Exception { - Thread.sleep(TIMER); SpringBatchScheduler schedulerBean = context.getBean(SpringBatchScheduler.class); + await().untilAsserted(() -> Assert.assertEquals(2, schedulerBean.getBatchRunCounter() + .get())); schedulerBean.stop(); - Thread.sleep(TIMER); - Date lastLaunchDate = schedulerBean.getCurrentLaunchDate(); - Thread.sleep(TIMER); - Assert.assertEquals(lastLaunchDate, schedulerBean.getCurrentLaunchDate()); + await().atLeast(3, SECONDS); + + Assert.assertEquals(2, schedulerBean.getBatchRunCounter() + .get()); } @Test public void stopJobSchedulerWhenSchedulerDestroyed() throws Exception { - Thread.sleep(TIMER); ScheduledAnnotationBeanPostProcessor bean = context.getBean(ScheduledAnnotationBeanPostProcessor.class); SpringBatchScheduler schedulerBean = context.getBean(SpringBatchScheduler.class); + await().untilAsserted(() -> Assert.assertEquals(2, schedulerBean.getBatchRunCounter() + .get())); bean.postProcessBeforeDestruction(schedulerBean, "SpringBatchScheduler"); - Thread.sleep(TIMER); - Date lastLaunchTime = schedulerBean.getCurrentLaunchDate(); - Thread.sleep(TIMER); - Assert.assertEquals(lastLaunchTime, schedulerBean.getCurrentLaunchDate()); + await().atLeast(3, SECONDS); + Assert.assertEquals(2, schedulerBean.getBatchRunCounter() + .get()); } @Test public void stopJobSchedulerWhenFutureTasksCancelled() throws Exception { - Thread.sleep(TIMER); SpringBatchScheduler schedulerBean = context.getBean(SpringBatchScheduler.class); + await().untilAsserted(() -> Assert.assertEquals(2, schedulerBean.getBatchRunCounter() + .get())); schedulerBean.cancelFutureSchedulerTasks(); - Thread.sleep(TIMER); - Date lastLaunchTime = schedulerBean.getCurrentLaunchDate(); - Thread.sleep(TIMER); - Assert.assertEquals(lastLaunchTime, schedulerBean.getCurrentLaunchDate()); + await().atLeast(3, SECONDS); + Assert.assertEquals(2, schedulerBean.getBatchRunCounter() + .get()); } - + + }