From 3cbfd383edd32b2848286c643fbc53b5f7609718 Mon Sep 17 00:00:00 2001
From: Vishal <vakkalkote@gmail.com>
Date: Mon, 17 Aug 2020 18:06:20 +0530
Subject: [PATCH] Refactor | Add common formatting, remove comments, update
 test class name,follow test method naming convention and use Junit5

---
 testing-modules/testing-assertions/pom.xml    | 22 +++++++++
 .../OrderAgnosticListComparison.java          | 46 -------------------
 .../OrderAgnosticListComparisonUnitTest.java  | 40 ++++++++++++++++
 3 files changed, 62 insertions(+), 46 deletions(-)
 delete mode 100644 testing-modules/testing-assertions/src/test/java/com/baeldung/listassert/OrderAgnosticListComparison.java
 create mode 100644 testing-modules/testing-assertions/src/test/java/com/baeldung/listassert/OrderAgnosticListComparisonUnitTest.java

diff --git a/testing-modules/testing-assertions/pom.xml b/testing-modules/testing-assertions/pom.xml
index fe8c86d058..5bb6f5faaa 100644
--- a/testing-modules/testing-assertions/pom.xml
+++ b/testing-modules/testing-assertions/pom.xml
@@ -18,6 +18,18 @@
             <artifactId>logback-classic</artifactId>
             <version>1.2.3</version>
         </dependency>
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter-engine</artifactId>
+            <version>5.6.2</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter-api</artifactId>
+            <version>5.6.2</version>
+            <scope>test</scope>
+        </dependency>
         <dependency>
             <groupId>org.assertj</groupId>
             <artifactId>assertj-core</artifactId>
@@ -37,4 +49,14 @@
             <scope>test</scope>
         </dependency>
     </dependencies>
+
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-surefire-plugin</artifactId>
+                <version>2.22.1</version>
+            </plugin>
+        </plugins>
+    </build>
 </project>
diff --git a/testing-modules/testing-assertions/src/test/java/com/baeldung/listassert/OrderAgnosticListComparison.java b/testing-modules/testing-assertions/src/test/java/com/baeldung/listassert/OrderAgnosticListComparison.java
deleted file mode 100644
index b03723e5bd..0000000000
--- a/testing-modules/testing-assertions/src/test/java/com/baeldung/listassert/OrderAgnosticListComparison.java
+++ /dev/null
@@ -1,46 +0,0 @@
-package com.baeldung.listassert;
-
-import org.hamcrest.Matchers;
-import org.apache.commons.collections4.CollectionUtils;
-import org.junit.Test;
-
-
-import java.util.Arrays;
-import java.util.List;
-
-import static org.hamcrest.MatcherAssert.assertThat;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
-
-public class OrderAgnosticListComparison {
-
-    private final List<Integer> first = Arrays.asList(1, 3, 4, 6, 8);
-    private final List<Integer> second = Arrays.asList(8, 1, 6, 3, 4);
-    private final List<Integer> third = Arrays.asList(1, 3, 3, 6, 6);
-
-    //In this test using simple JUnit assertion
-    @Test
-    public void whenTestingForOrderAgnosticEqualityShouldBeTrue() {
-        assertTrue(first.size() == second.size() &&
-                first.containsAll(second) && second.containsAll(first));
-    }
-
-    @Test
-    public void whenTestingForOrderAgnosticEqualityShouldBeFalse() {
-        assertFalse(first.size() == third.size() &&
-                first.containsAll(third) && third.containsAll(first));
-    }
-
-    //In this test using Hamcrest lib apis for assertion
-    @Test
-    public void whenTestingForOrderAgnosticEqualityShouldBeEqual() {
-        assertThat(first, Matchers.containsInAnyOrder(second.toArray()));
-    }
-
-    //In this test asserting lists using Apache Commons apis
-    @Test
-    public void whenTestingForOrderAgnosticEqualityShouldBeTrueIfEqualOtherwiseFalse() {
-        assertTrue(CollectionUtils.isEqualCollection(first, second));
-        assertFalse(CollectionUtils.isEqualCollection(first, third));
-    }
-}
diff --git a/testing-modules/testing-assertions/src/test/java/com/baeldung/listassert/OrderAgnosticListComparisonUnitTest.java b/testing-modules/testing-assertions/src/test/java/com/baeldung/listassert/OrderAgnosticListComparisonUnitTest.java
new file mode 100644
index 0000000000..9ef6f203af
--- /dev/null
+++ b/testing-modules/testing-assertions/src/test/java/com/baeldung/listassert/OrderAgnosticListComparisonUnitTest.java
@@ -0,0 +1,40 @@
+package com.baeldung.listassert;
+
+import org.apache.commons.collections4.CollectionUtils;
+import org.hamcrest.Matchers;
+import org.junit.jupiter.api.Test;
+
+import java.util.Arrays;
+import java.util.List;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public class OrderAgnosticListComparisonUnitTest {
+
+    private final List<Integer> first = Arrays.asList(1, 3, 4, 6, 8);
+    private final List<Integer> second = Arrays.asList(8, 1, 6, 3, 4);
+    private final List<Integer> third = Arrays.asList(1, 3, 3, 6, 6);
+
+    @Test
+    public void whenTestingForOrderAgnosticEquality_ShouldBeTrue() {
+        assertTrue(first.size() == second.size() && first.containsAll(second) && second.containsAll(first));
+    }
+
+    @Test
+    public void whenTestingForOrderAgnosticEquality_ShouldBeFalse() {
+        assertFalse(first.size() == third.size() && first.containsAll(third) && third.containsAll(first));
+    }
+
+    @Test
+    public void whenTestingForOrderAgnosticEquality_ShouldBeEqual() {
+        assertThat(first, Matchers.containsInAnyOrder(second.toArray()));
+    }
+
+    @Test
+    public void whenTestingForOrderAgnosticEquality_ShouldBeTrueIfEqualOtherwiseFalse() {
+        assertTrue(CollectionUtils.isEqualCollection(first, second));
+        assertFalse(CollectionUtils.isEqualCollection(first, third));
+    }
+}