BAEL-4504: Fix PR comments

This commit is contained in:
Daniel Strmecki 2020-10-11 11:14:36 +02:00
parent f80f82781f
commit 42455830c0
1 changed files with 4 additions and 4 deletions

View File

@ -21,7 +21,7 @@ public class FindFreePortUnitTest {
@BeforeAll @BeforeAll
public static void getExplicitFreePortNumberAndRange() { public static void getExplicitFreePortNumberAndRange() {
try (ServerSocket serverSocket = new ServerSocket(0);) { try (ServerSocket serverSocket = new ServerSocket(0)) {
FREE_PORT_NUMBER = serverSocket.getLocalPort(); FREE_PORT_NUMBER = serverSocket.getLocalPort();
FREE_PORT_RANGE = new int[] {FREE_PORT_NUMBER, FREE_PORT_NUMBER + 1, FREE_PORT_NUMBER + 2}; FREE_PORT_RANGE = new int[] {FREE_PORT_NUMBER, FREE_PORT_NUMBER + 1, FREE_PORT_NUMBER + 2};
} catch (IOException e) { } catch (IOException e) {
@ -31,7 +31,7 @@ public class FindFreePortUnitTest {
@Test @Test
public void givenExplicitFreePort_whenCreatingServerSocket_thenThatPortIsAssigned() { public void givenExplicitFreePort_whenCreatingServerSocket_thenThatPortIsAssigned() {
try (ServerSocket serverSocket = new ServerSocket(FREE_PORT_NUMBER);) { try (ServerSocket serverSocket = new ServerSocket(FREE_PORT_NUMBER)) {
assertThat(serverSocket).isNotNull(); assertThat(serverSocket).isNotNull();
assertThat(serverSocket.getLocalPort()).isEqualTo(FREE_PORT_NUMBER); assertThat(serverSocket.getLocalPort()).isEqualTo(FREE_PORT_NUMBER);
} catch (IOException e) { } catch (IOException e) {
@ -54,7 +54,7 @@ public class FindFreePortUnitTest {
for (int port : FREE_PORT_RANGE) { for (int port : FREE_PORT_RANGE) {
try (ServerSocket serverSocket = new ServerSocket(port)) { try (ServerSocket serverSocket = new ServerSocket(port)) {
assertThat(serverSocket).isNotNull(); assertThat(serverSocket).isNotNull();
assertThat(serverSocket.getLocalPort()).isGreaterThan(0); assertThat(serverSocket.getLocalPort()).isEqualTo(port);
return; return;
} catch (IOException e) { } catch (IOException e) {
assertThat(e).hasMessageContaining("Address already in use"); assertThat(e).hasMessageContaining("Address already in use");
@ -78,7 +78,7 @@ public class FindFreePortUnitTest {
int port = SocketUtils.findAvailableTcpPort(); int port = SocketUtils.findAvailableTcpPort();
try (ServerSocket serverSocket = new ServerSocket(port)) { try (ServerSocket serverSocket = new ServerSocket(port)) {
assertThat(serverSocket).isNotNull(); assertThat(serverSocket).isNotNull();
assertThat(serverSocket.getLocalPort()).isGreaterThan(0); assertThat(serverSocket.getLocalPort()).isEqualTo(port);
} catch (IOException e) { } catch (IOException e) {
fail("Port is not available"); fail("Port is not available");
} }