Refactor Spring with Lombok samples

This commit is contained in:
pivovarit 2017-02-04 06:15:54 +01:00
parent 896a193fb0
commit 4d5624161f
11 changed files with 28 additions and 29 deletions

View File

@ -6,13 +6,13 @@ import org.springframework.stereotype.Component;
@Component @Component
@AllArgsConstructor @AllArgsConstructor
public class Apologizer { public class ApologizeService {
private final Translator translator; private final Translator translator;
private final String message; private final String message;
@Autowired @Autowired
public Apologizer(Translator translator) { public ApologizeService(Translator translator) {
this(translator, "sorry"); this(translator, "sorry");
} }

View File

@ -4,11 +4,11 @@ import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component; import org.springframework.stereotype.Component;
@Component @Component
public class Fareweller { public class FarewellService {
private final Translator translator; private final Translator translator;
public Fareweller(Translator translator) { public FarewellService(Translator translator) {
this.translator = translator; this.translator = translator;
} }

View File

@ -4,7 +4,7 @@ import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component; import org.springframework.stereotype.Component;
@Component @Component
public class Greeter { public class GreetingService {
@Autowired @Autowired
private Translator translator; private Translator translator;

View File

@ -1,12 +1,11 @@
package com.baeldung.lombok; package com.baeldung.lombok;
import lombok.AllArgsConstructor; import lombok.AllArgsConstructor;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component; import org.springframework.stereotype.Component;
@Component @Component
@AllArgsConstructor @AllArgsConstructor
public class Thanker { public class ThankingService {
private final Translator translator; private final Translator translator;

View File

@ -14,12 +14,12 @@ import static org.mockito.Mockito.when;
@ContextConfiguration( @ContextConfiguration(
loader = AnnotationConfigContextLoader.class, loader = AnnotationConfigContextLoader.class,
classes = TestConfig.class) classes = TestConfig.class)
public class ApologizerAutowiringTest { public class ApologizeServiceAutowiringTest {
private final static String TRANSLATED = "TRANSLATED"; private final static String TRANSLATED = "TRANSLATED";
@Autowired @Autowired
private Apologizer apologizer; private ApologizeService apologizeService;
@Autowired @Autowired
private Translator translator; private Translator translator;
@ -27,7 +27,7 @@ public class ApologizerAutowiringTest {
@Test @Test
public void apologizeWithTranslatedMessage() { public void apologizeWithTranslatedMessage() {
when(translator.translate("sorry")).thenReturn(TRANSLATED); when(translator.translate("sorry")).thenReturn(TRANSLATED);
assertEquals(TRANSLATED, apologizer.apologize()); assertEquals(TRANSLATED, apologizeService.apologize());
} }
} }

View File

@ -6,7 +6,7 @@ import static org.junit.Assert.assertEquals;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
public class ApologizerTest { public class ApologizeServiceTest {
private final static String MESSAGE = "MESSAGE"; private final static String MESSAGE = "MESSAGE";
private final static String TRANSLATED = "TRANSLATED"; private final static String TRANSLATED = "TRANSLATED";
@ -14,8 +14,8 @@ public class ApologizerTest {
@Test @Test
public void apologizeWithCustomTranslatedMessage() { public void apologizeWithCustomTranslatedMessage() {
Translator translator = mock(Translator.class); Translator translator = mock(Translator.class);
Apologizer apologizer = new Apologizer(translator, MESSAGE); ApologizeService apologizeService = new ApologizeService(translator, MESSAGE);
when(translator.translate(MESSAGE)).thenReturn(TRANSLATED); when(translator.translate(MESSAGE)).thenReturn(TRANSLATED);
assertEquals(TRANSLATED, apologizer.apologize()); assertEquals(TRANSLATED, apologizeService.apologize());
} }
} }

View File

@ -17,7 +17,7 @@ import static org.mockito.Mockito.when;
public class FarewellAutowiringTest { public class FarewellAutowiringTest {
@Autowired @Autowired
private Fareweller fareweller; private FarewellService farewellService;
@Autowired @Autowired
private Translator translator; private Translator translator;
@ -26,6 +26,6 @@ public class FarewellAutowiringTest {
public void sayByeWithTranslatedMessage() { public void sayByeWithTranslatedMessage() {
String translated = "translated"; String translated = "translated";
when(translator.translate("bye")).thenReturn(translated); when(translator.translate("bye")).thenReturn(translated);
assertEquals(translated, fareweller.farewell()); assertEquals(translated, farewellService.farewell());
} }
} }

View File

@ -6,7 +6,7 @@ import static org.junit.Assert.*;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
public class FarewellerTest { public class FarewellServiceTest {
private final static String TRANSLATED = "TRANSLATED"; private final static String TRANSLATED = "TRANSLATED";
@ -14,7 +14,7 @@ public class FarewellerTest {
public void sayByeWithTranslatedMessage() { public void sayByeWithTranslatedMessage() {
Translator translator = mock(Translator.class); Translator translator = mock(Translator.class);
when(translator.translate("bye")).thenReturn(TRANSLATED); when(translator.translate("bye")).thenReturn(TRANSLATED);
Fareweller fareweller = new Fareweller(translator); FarewellService farewellService = new FarewellService(translator);
assertEquals(TRANSLATED, fareweller.farewell()); assertEquals(TRANSLATED, farewellService.farewell());
} }
} }

View File

@ -14,10 +14,10 @@ import static org.mockito.Mockito.when;
@ContextConfiguration( @ContextConfiguration(
loader = AnnotationConfigContextLoader.class, loader = AnnotationConfigContextLoader.class,
classes = TestConfig.class) classes = TestConfig.class)
public class GreeterTest { public class GreetingServiceTest {
@Autowired @Autowired
private Greeter greeter; private GreetingService greetingService;
@Autowired @Autowired
private Translator translator; private Translator translator;
@ -26,12 +26,12 @@ public class GreeterTest {
public void greetWithTranslatedMessage() { public void greetWithTranslatedMessage() {
String translated = "translated"; String translated = "translated";
when(translator.translate("hello")).thenReturn(translated); when(translator.translate("hello")).thenReturn(translated);
assertEquals(translated, greeter.greet()); assertEquals(translated, greetingService.greet());
} }
@Test(expected = NullPointerException.class) @Test(expected = NullPointerException.class)
public void throwWhenInstantiated() { public void throwWhenInstantiated() {
Greeter greeter = new Greeter(); GreetingService greetingService = new GreetingService();
greeter.greet(); greetingService.greet();
} }
} }

View File

@ -14,10 +14,10 @@ import static org.mockito.Mockito.when;
@ContextConfiguration( @ContextConfiguration(
loader = AnnotationConfigContextLoader.class, loader = AnnotationConfigContextLoader.class,
classes = TestConfig.class) classes = TestConfig.class)
public class ThankerAutowiringTest { public class ThankingServiceAutowiringTest {
@Autowired @Autowired
private Thanker thanker; private ThankingService thankingService;
@Autowired @Autowired
private Translator translator; private Translator translator;
@ -26,6 +26,6 @@ public class ThankerAutowiringTest {
public void thankWithTranslatedMessage() { public void thankWithTranslatedMessage() {
String translated = "translated"; String translated = "translated";
when(translator.translate("thank you")).thenReturn(translated); when(translator.translate("thank you")).thenReturn(translated);
assertEquals(translated, thanker.thank()); assertEquals(translated, thankingService.thank());
} }
} }

View File

@ -6,7 +6,7 @@ import static org.junit.Assert.*;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
public class ThankerTest { public class ThankingServiceTest {
private final static String TRANSLATED = "TRANSLATED"; private final static String TRANSLATED = "TRANSLATED";
@ -14,7 +14,7 @@ public class ThankerTest {
public void thankWithTranslatedMessage() { public void thankWithTranslatedMessage() {
Translator translator = mock(Translator.class); Translator translator = mock(Translator.class);
when(translator.translate("thank you")).thenReturn(TRANSLATED); when(translator.translate("thank you")).thenReturn(TRANSLATED);
Thanker thanker = new Thanker(translator); ThankingService thankingService = new ThankingService(translator);
assertEquals(TRANSLATED, thanker.thank()); assertEquals(TRANSLATED, thankingService.thank());
} }
} }