From 4e063a1120afb7aec6dc9b6ff5548472bc665c5c Mon Sep 17 00:00:00 2001
From: Nikunj Gandhi <nikunjgandhi@Nikunjs-MBP.attlocal.net>
Date: Thu, 19 Sep 2019 15:26:45 -0400
Subject: [PATCH] BAEL-3214 | Code review related changes - 1

---
 .../filewriter/FileWriterExample.java         | 37 ----------------
 .../filewriter/FileWriterExampleUnitTest.java | 42 ++++++++-----------
 2 files changed, 17 insertions(+), 62 deletions(-)
 delete mode 100644 core-java-modules/core-java-io-2/src/main/java/com/baeldung/filewriter/FileWriterExample.java

diff --git a/core-java-modules/core-java-io-2/src/main/java/com/baeldung/filewriter/FileWriterExample.java b/core-java-modules/core-java-io-2/src/main/java/com/baeldung/filewriter/FileWriterExample.java
deleted file mode 100644
index d60f0800ec..0000000000
--- a/core-java-modules/core-java-io-2/src/main/java/com/baeldung/filewriter/FileWriterExample.java
+++ /dev/null
@@ -1,37 +0,0 @@
-package com.baeldung.filewriter;
-
-import java.io.BufferedWriter;
-import java.io.FileWriter;
-import java.io.IOException;
-import java.util.List;
-
-public class FileWriterExample {
-
-    public void writeString(String fileName, String strToWrite) throws IOException {
-        try (FileWriter fileWriter = new FileWriter(fileName)) {
-            fileWriter.write(strToWrite);
-        }
-    }
-
-    public void appendString(String fileName, String stringToAppend) throws IOException {
-        try (FileWriter fileWriter = new FileWriter(fileName, true)) {
-            fileWriter.append(stringToAppend);
-        }
-    }
-
-    public void writeCharArray(String fileName, char[] charArrToWrite) throws IOException {
-        try (FileWriter fileWriter = new FileWriter(fileName)) {
-            fileWriter.write(charArrToWrite);
-        }
-    }
-
-    public void writeWithBufferedWriter(String fileName, List<String> stringsToWrite) throws IOException {
-        try (FileWriter fileWriter = new FileWriter(fileName); BufferedWriter bufferedWriter = new BufferedWriter(fileWriter)) {
-            for (String stringToWrite : stringsToWrite) {
-                bufferedWriter.write(stringToWrite);
-            }
-        }
-
-    }
-
-}
diff --git a/core-java-modules/core-java-io-2/src/test/java/com/baeldung/filewriter/FileWriterExampleUnitTest.java b/core-java-modules/core-java-io-2/src/test/java/com/baeldung/filewriter/FileWriterExampleUnitTest.java
index a1fdb5459e..5a8dfcc381 100644
--- a/core-java-modules/core-java-io-2/src/test/java/com/baeldung/filewriter/FileWriterExampleUnitTest.java
+++ b/core-java-modules/core-java-io-2/src/test/java/com/baeldung/filewriter/FileWriterExampleUnitTest.java
@@ -1,12 +1,9 @@
 package com.baeldung.filewriter;
 
+import java.io.FileWriter;
 import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.Random;
-import java.util.stream.IntStream;
 
 import org.junit.After;
 import org.junit.Assert;
@@ -15,11 +12,6 @@ import org.junit.Test;
 public class FileWriterExampleUnitTest {
 
     private static final String FILE_NAME = "src/test/resources/FileWriterTest.txt";
-    private static final String STRING_TO_WRITE = "Hello Folks!";
-    private static final String STRING_TO_APPEND = "Hello Folks Again!";
-    private static final char[] CHAR_ARRAY_TO_WRITE = STRING_TO_WRITE.toCharArray();
-
-    private FileWriterExample fileWriterExample = new FileWriterExample();
 
     @After
     public void tearDown() throws IOException {
@@ -28,30 +20,30 @@ public class FileWriterExampleUnitTest {
 
     @Test
     public void testWriteString() throws IOException {
-        fileWriterExample.writeString(FILE_NAME, STRING_TO_WRITE);
-        Assert.assertEquals(STRING_TO_WRITE, new String(Files.readAllBytes(Path.of(FILE_NAME))));
+        try (FileWriter fileWriter = new FileWriter(FILE_NAME)) {
+            fileWriter.write("Hello Folks!");
+        }
+        Assert.assertEquals("Hello Folks!", new String(Files.readAllBytes(Path.of(FILE_NAME))));
     }
 
     @Test
     public void testAppendString() throws IOException {
-        fileWriterExample.writeString(FILE_NAME, STRING_TO_WRITE);
-        fileWriterExample.appendString(FILE_NAME, STRING_TO_APPEND);
-        Assert.assertEquals(STRING_TO_WRITE + STRING_TO_APPEND, new String(Files.readAllBytes(Path.of(FILE_NAME))));
+        try (FileWriter fileWriter = new FileWriter(FILE_NAME)) {
+            fileWriter.write("Hello Folks!");
+        }
+        // using another try with resources to reopen the file in append mode
+        try (FileWriter fileWriter = new FileWriter(FILE_NAME, true)) {
+            fileWriter.write("Hello Folks Again!");
+        }
+
+        Assert.assertEquals("Hello Folks!" + "Hello Folks Again!", new String(Files.readAllBytes(Path.of(FILE_NAME))));
     }
 
     @Test
     public void testWriteCharArray() throws IOException {
-        fileWriterExample.writeCharArray(FILE_NAME, CHAR_ARRAY_TO_WRITE);
-        Assert.assertEquals(STRING_TO_WRITE, new String(Files.readAllBytes(Path.of(FILE_NAME))));
-    }
-    
-    @Test
-    public void testWriteWithBufferedWriter() throws IOException{
-        final List<String> stringsToWrite = new ArrayList<>();
-        for(int i=0 ; i < 10000;i++) {
-            stringsToWrite.add("Random string "+i);
+        try (FileWriter fileWriter = new FileWriter(FILE_NAME)) {
+            fileWriter.write("Hello Folks!".toCharArray());
         }
-        fileWriterExample.writeWithBufferedWriter(FILE_NAME, stringsToWrite);
-        Assert.assertNotNull(new String(Files.readAllBytes(Path.of(FILE_NAME))));
+        Assert.assertEquals("Hello Folks!", new String(Files.readAllBytes(Path.of(FILE_NAME))));
     }
 }