From 506d0f405db1906e7e1396595bd7e14aa3a5d384 Mon Sep 17 00:00:00 2001
From: eugenp <hanriseldon@gmail.com>
Date: Sat, 14 Feb 2015 13:57:07 +0200
Subject: [PATCH] small registration fixes

---
 .../listener/RegistrationListener.java        | 23 ++++++++++++++-----
 .../controller/RegistrationController.java    |  1 +
 .../test/SpringSecurityRolesTest.java         |  0
 3 files changed, 18 insertions(+), 6 deletions(-)
 rename spring-security-login-and-registration/src/{main => test}/java/org/baeldung/test/SpringSecurityRolesTest.java (100%)

diff --git a/spring-security-login-and-registration/src/main/java/org/baeldung/registration/listener/RegistrationListener.java b/spring-security-login-and-registration/src/main/java/org/baeldung/registration/listener/RegistrationListener.java
index f636f4e765..268aa300bd 100644
--- a/spring-security-login-and-registration/src/main/java/org/baeldung/registration/listener/RegistrationListener.java
+++ b/spring-security-login-and-registration/src/main/java/org/baeldung/registration/listener/RegistrationListener.java
@@ -23,6 +23,8 @@ public class RegistrationListener implements ApplicationListener<OnRegistrationC
     @Autowired
     private JavaMailSender mailSender;
 
+    // API
+
     @Override
     public void onApplicationEvent(OnRegistrationCompleteEvent event) {
         this.confirmRegistration(event);
@@ -33,14 +35,23 @@ public class RegistrationListener implements ApplicationListener<OnRegistrationC
         String token = UUID.randomUUID().toString();
         service.createVerificationTokenForUser(user, token);
 
-        String recipientAddress = user.getEmail();
-        String subject = "Registration Confirmation";
-        String confirmationUrl = event.getAppUrl() + "/regitrationConfirm.html?token=" + token;
-        String message = messages.getMessage("message.regSucc", null, event.getLocale());
-        SimpleMailMessage email = new SimpleMailMessage();
+        final SimpleMailMessage email = constructEmailMessage(event, user, token);
+        mailSender.send(email);
+    }
+
+    //
+
+    private final SimpleMailMessage constructEmailMessage(final OnRegistrationCompleteEvent event, final User user, final String token) {
+        final String recipientAddress = user.getEmail();
+        final String subject = "Registration Confirmation";
+        final String confirmationUrl = "http://" + event.getAppUrl() + "/regitrationConfirm.html?token=" + token;
+        final String message = messages.getMessage("message.regSucc", null, event.getLocale());
+        final SimpleMailMessage email = new SimpleMailMessage();
         email.setTo(recipientAddress);
         email.setSubject(subject);
         email.setText(message + " \r\n" + confirmationUrl);
-        mailSender.send(email);
+        email.setFrom("eugen@baeldung.com");
+        return email;
     }
+    
 }
diff --git a/spring-security-login-and-registration/src/main/java/org/baeldung/web/controller/RegistrationController.java b/spring-security-login-and-registration/src/main/java/org/baeldung/web/controller/RegistrationController.java
index 10e5753ccd..c0e6d1748e 100644
--- a/spring-security-login-and-registration/src/main/java/org/baeldung/web/controller/RegistrationController.java
+++ b/spring-security-login-and-registration/src/main/java/org/baeldung/web/controller/RegistrationController.java
@@ -190,6 +190,7 @@ public class RegistrationController {
         userService.createPasswordResetTokenForUser(user, token);
         final String appUrl = request.getServerName() + ":" + request.getServerPort() + request.getContextPath();
         final SimpleMailMessage email = constructResetTokenEmail(appUrl, request.getLocale(), token, user);
+        email.setFrom("eugen@baeldung.com");
         mailSender.send(email);
 
         return new ObjectMapper().writeValueAsString(messages.getMessage("message.resetPassword", null, request.getLocale()));
diff --git a/spring-security-login-and-registration/src/main/java/org/baeldung/test/SpringSecurityRolesTest.java b/spring-security-login-and-registration/src/test/java/org/baeldung/test/SpringSecurityRolesTest.java
similarity index 100%
rename from spring-security-login-and-registration/src/main/java/org/baeldung/test/SpringSecurityRolesTest.java
rename to spring-security-login-and-registration/src/test/java/org/baeldung/test/SpringSecurityRolesTest.java