From 6932011bf9c86e9f55a37da89094c0f13dfc8fe9 Mon Sep 17 00:00:00 2001 From: Deboshree Date: Tue, 8 Nov 2022 23:55:31 +0530 Subject: [PATCH 1/4] https://jira.baeldung.com/browse/BAEL-4630 --- testing-modules/testng-jenkins/pom.xml | 48 +++++++++++++++++++ .../TestNGSampleTestForNumberAddition.java | 26 ++++++++++ .../TestNGSampleTestForStringLength.java | 20 ++++++++ .../src/test/resources/test_suite.xml | 10 ++++ 4 files changed, 104 insertions(+) create mode 100644 testing-modules/testng-jenkins/pom.xml create mode 100644 testing-modules/testng-jenkins/src/test/java/com/baeldung/TestNGSampleTestForNumberAddition.java create mode 100644 testing-modules/testng-jenkins/src/test/java/com/baeldung/TestNGSampleTestForStringLength.java create mode 100644 testing-modules/testng-jenkins/src/test/resources/test_suite.xml diff --git a/testing-modules/testng-jenkins/pom.xml b/testing-modules/testng-jenkins/pom.xml new file mode 100644 index 0000000000..9a89f633a4 --- /dev/null +++ b/testing-modules/testng-jenkins/pom.xml @@ -0,0 +1,48 @@ + + + 4.0.0 + testng + 0.1.0-SNAPSHOT + testng-jenkins + jar + + + com.baeldung + testing-modules + 1.0.0-SNAPSHOT + + + + 7.6.1 + + + + + org.testng + testng + ${testng.version} + test + + + + + + + org.apache.maven.plugins + maven-surefire-plugin + + + + src\test\resources\test_suite.xml + + + + + + + + + + \ No newline at end of file diff --git a/testing-modules/testng-jenkins/src/test/java/com/baeldung/TestNGSampleTestForNumberAddition.java b/testing-modules/testng-jenkins/src/test/java/com/baeldung/TestNGSampleTestForNumberAddition.java new file mode 100644 index 0000000000..05b4e590a3 --- /dev/null +++ b/testing-modules/testng-jenkins/src/test/java/com/baeldung/TestNGSampleTestForNumberAddition.java @@ -0,0 +1,26 @@ +package com.baeldung; + +import static org.testng.AssertJUnit.assertEquals; +import org.testng.annotations.AfterClass; +import org.testng.annotations.BeforeClass; +import org.testng.annotations.Test; + +public class TestNGSampleTestForNumberAddition { + int firstNumber, secondNumber; + + @BeforeClass + public void setup() { + firstNumber = 13; + secondNumber = 24; + } + + @AfterClass + public void tearDown() { + firstNumber = secondNumber = 0; + } + + @Test + public void givenNumbers_whenSumIsOdd_thenTrue() { + assertEquals(1, ( firstNumber + secondNumber ) % 2); + } +} diff --git a/testing-modules/testng-jenkins/src/test/java/com/baeldung/TestNGSampleTestForStringLength.java b/testing-modules/testng-jenkins/src/test/java/com/baeldung/TestNGSampleTestForStringLength.java new file mode 100644 index 0000000000..24cc674684 --- /dev/null +++ b/testing-modules/testng-jenkins/src/test/java/com/baeldung/TestNGSampleTestForStringLength.java @@ -0,0 +1,20 @@ +package com.baeldung; + +import static org.testng.AssertJUnit.assertEquals; +import org.testng.annotations.BeforeClass; +import org.testng.annotations.Test; + +public class TestNGSampleTestForStringLength { + + String name; + + @BeforeClass + public void setup() { + name = "Hannah"; + } + + @Test + public void givenString_whenEvenLength_thenTrue() { + assertEquals(0, name.length() % 2); + } +} diff --git a/testing-modules/testng-jenkins/src/test/resources/test_suite.xml b/testing-modules/testng-jenkins/src/test/resources/test_suite.xml new file mode 100644 index 0000000000..101fe28ea6 --- /dev/null +++ b/testing-modules/testng-jenkins/src/test/resources/test_suite.xml @@ -0,0 +1,10 @@ + + + + + + + + + + \ No newline at end of file From bd6c979b1edab75828f5ffec617f611ae12a7f26 Mon Sep 17 00:00:00 2001 From: Deboshree Date: Wed, 9 Nov 2022 01:00:29 +0530 Subject: [PATCH 2/4] Revert "https://jira.baeldung.com/browse/BAEL-4630" This reverts commit 6932011bf9c86e9f55a37da89094c0f13dfc8fe9. --- testing-modules/testng-jenkins/pom.xml | 48 ------------------- .../TestNGSampleTestForNumberAddition.java | 26 ---------- .../TestNGSampleTestForStringLength.java | 20 -------- .../src/test/resources/test_suite.xml | 10 ---- 4 files changed, 104 deletions(-) delete mode 100644 testing-modules/testng-jenkins/pom.xml delete mode 100644 testing-modules/testng-jenkins/src/test/java/com/baeldung/TestNGSampleTestForNumberAddition.java delete mode 100644 testing-modules/testng-jenkins/src/test/java/com/baeldung/TestNGSampleTestForStringLength.java delete mode 100644 testing-modules/testng-jenkins/src/test/resources/test_suite.xml diff --git a/testing-modules/testng-jenkins/pom.xml b/testing-modules/testng-jenkins/pom.xml deleted file mode 100644 index 9a89f633a4..0000000000 --- a/testing-modules/testng-jenkins/pom.xml +++ /dev/null @@ -1,48 +0,0 @@ - - - 4.0.0 - testng - 0.1.0-SNAPSHOT - testng-jenkins - jar - - - com.baeldung - testing-modules - 1.0.0-SNAPSHOT - - - - 7.6.1 - - - - - org.testng - testng - ${testng.version} - test - - - - - - - org.apache.maven.plugins - maven-surefire-plugin - - - - src\test\resources\test_suite.xml - - - - - - - - - - \ No newline at end of file diff --git a/testing-modules/testng-jenkins/src/test/java/com/baeldung/TestNGSampleTestForNumberAddition.java b/testing-modules/testng-jenkins/src/test/java/com/baeldung/TestNGSampleTestForNumberAddition.java deleted file mode 100644 index 05b4e590a3..0000000000 --- a/testing-modules/testng-jenkins/src/test/java/com/baeldung/TestNGSampleTestForNumberAddition.java +++ /dev/null @@ -1,26 +0,0 @@ -package com.baeldung; - -import static org.testng.AssertJUnit.assertEquals; -import org.testng.annotations.AfterClass; -import org.testng.annotations.BeforeClass; -import org.testng.annotations.Test; - -public class TestNGSampleTestForNumberAddition { - int firstNumber, secondNumber; - - @BeforeClass - public void setup() { - firstNumber = 13; - secondNumber = 24; - } - - @AfterClass - public void tearDown() { - firstNumber = secondNumber = 0; - } - - @Test - public void givenNumbers_whenSumIsOdd_thenTrue() { - assertEquals(1, ( firstNumber + secondNumber ) % 2); - } -} diff --git a/testing-modules/testng-jenkins/src/test/java/com/baeldung/TestNGSampleTestForStringLength.java b/testing-modules/testng-jenkins/src/test/java/com/baeldung/TestNGSampleTestForStringLength.java deleted file mode 100644 index 24cc674684..0000000000 --- a/testing-modules/testng-jenkins/src/test/java/com/baeldung/TestNGSampleTestForStringLength.java +++ /dev/null @@ -1,20 +0,0 @@ -package com.baeldung; - -import static org.testng.AssertJUnit.assertEquals; -import org.testng.annotations.BeforeClass; -import org.testng.annotations.Test; - -public class TestNGSampleTestForStringLength { - - String name; - - @BeforeClass - public void setup() { - name = "Hannah"; - } - - @Test - public void givenString_whenEvenLength_thenTrue() { - assertEquals(0, name.length() % 2); - } -} diff --git a/testing-modules/testng-jenkins/src/test/resources/test_suite.xml b/testing-modules/testng-jenkins/src/test/resources/test_suite.xml deleted file mode 100644 index 101fe28ea6..0000000000 --- a/testing-modules/testng-jenkins/src/test/resources/test_suite.xml +++ /dev/null @@ -1,10 +0,0 @@ - - - - - - - - - - \ No newline at end of file From 979b362ad1be3dc8315391fd2af926b543cda0af Mon Sep 17 00:00:00 2001 From: Deboshree Date: Fri, 24 Mar 2023 21:41:26 +0530 Subject: [PATCH 3/4] https://jira.baeldung.com/browse/BAEL- 1. moving modules to java-string-conversions 2. fixing old broken test --- .../stringtoint/StringToIntEncapsulation.java | 53 +++++++++++++++ .../DateToStringFormatterUnitTest.java | 17 +++-- .../StringToIntEncapsulationUnitTest.java | 67 +++++++++++++++++++ 3 files changed, 128 insertions(+), 9 deletions(-) create mode 100644 core-java-modules/core-java-string-conversions/src/main/java/com/baeldung/stringtoint/StringToIntEncapsulation.java create mode 100644 core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/stringtoint/StringToIntEncapsulationUnitTest.java diff --git a/core-java-modules/core-java-string-conversions/src/main/java/com/baeldung/stringtoint/StringToIntEncapsulation.java b/core-java-modules/core-java-string-conversions/src/main/java/com/baeldung/stringtoint/StringToIntEncapsulation.java new file mode 100644 index 0000000000..cac1a5e19b --- /dev/null +++ b/core-java-modules/core-java-string-conversions/src/main/java/com/baeldung/stringtoint/StringToIntEncapsulation.java @@ -0,0 +1,53 @@ +package com.baeldung.stringtoint; + +import java.util.Optional; +import org.apache.commons.lang3.math.NumberUtils; + +public class StringToIntEncapsulation { + + private StringToIntEncapsulation() { + } + + public static Integer convertStringToIntUsingIntegerParseInt(String input){ + try { + return Integer.parseInt(input); + } catch (NumberFormatException e) { + // log or handle the error + return null; // or Integer.MIN_VALUE, or some other default value + } + } + + public static Integer convertStringToIntUsingIntegerValueOf(String input){ + try { + return Integer.valueOf(input); + } catch (NumberFormatException e) { + // log or handle the error + return null; // or Integer.MIN_VALUE, or some other default value + } + } + + public static Integer convertStringToIntUsingIntegerDecode(String input){ + try { + return Integer.decode(input); + } catch (Exception e) { + // log or handle the error + return null; // or Integer.MIN_VALUE, or some other default value + } + } + + public static Integer converStringToIntUsingOptional(String input){ + Optional parsedInt; + try { + parsedInt = Optional.of(Integer.parseInt(input)); + } catch (Exception e) { + // log or handle the error + parsedInt = Optional.empty(); + } + return parsedInt.orElse(null); + } + + public static int convertStringToIntUsingNumberUtils(String input){ + //returns Integer.MIN_VALUE as the default value if conversion fails + return NumberUtils.toInt(input, Integer.MIN_VALUE); + } +} diff --git a/core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/datetostring/DateToStringFormatterUnitTest.java b/core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/datetostring/DateToStringFormatterUnitTest.java index 221900fb0e..2ad92adb2d 100644 --- a/core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/datetostring/DateToStringFormatterUnitTest.java +++ b/core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/datetostring/DateToStringFormatterUnitTest.java @@ -19,7 +19,6 @@ import static org.junit.Assert.assertEquals; public class DateToStringFormatterUnitTest { private static final String DATE_FORMAT = "MMM d, yyyy HH:mm a"; - private static final String EXPECTED_STRING_DATE = "Aug 1, 2018 12:00 PM"; private static Date date; @BeforeClass @@ -34,8 +33,8 @@ public class DateToStringFormatterUnitTest { public void whenDateConvertedUsingSimpleDateFormatToString_thenCorrect() { DateFormat formatter = new SimpleDateFormat(DATE_FORMAT); String formattedDate = formatter.format(date); - - assertEquals(EXPECTED_STRING_DATE, formattedDate); + String expectedDate = "Aug 1, 2018 12:00 pm"; + assertEquals(expectedDate, formattedDate); } @Test @@ -43,15 +42,15 @@ public class DateToStringFormatterUnitTest { String formattedDate = DateFormat .getDateTimeInstance(DateFormat.MEDIUM, DateFormat.SHORT, Locale.US) .format(date); - - assertEquals(EXPECTED_STRING_DATE, formattedDate); + String expectedDate = "Aug 1, 2018, 12:00 PM"; + assertEquals(expectedDate, formattedDate); } @Test public void whenDateConvertedUsingFormatterToString_thenCorrect() { String formattedDate = String.format("%1$tb %1$te, %1$tY %1$tI:%1$tM %1$Tp", date); - - assertEquals(EXPECTED_STRING_DATE, formattedDate); + String expectedDate = "Aug 1, 2018 12:00 PM"; + assertEquals(expectedDate, formattedDate); } @Test @@ -62,7 +61,7 @@ public class DateToStringFormatterUnitTest { .atZone(ZoneId.of("CET")) .toLocalDateTime(); String formattedDate = ldt.format(fmt); - - assertEquals(EXPECTED_STRING_DATE, formattedDate); + String expectedDate = "Aug 1, 2018 12:00 pm"; + assertEquals(expectedDate, formattedDate); } } diff --git a/core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/stringtoint/StringToIntEncapsulationUnitTest.java b/core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/stringtoint/StringToIntEncapsulationUnitTest.java new file mode 100644 index 0000000000..46cbf61244 --- /dev/null +++ b/core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/stringtoint/StringToIntEncapsulationUnitTest.java @@ -0,0 +1,67 @@ +package com.baeldung.stringtoint; + +import java.util.Arrays; +import java.util.List; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; + +class StringToIntEncapsulationUnitTest { + + @Test + void whenConvertingIntToString_thenInvalidCasesReturnNull() { + List testData = Arrays.asList( + new TestData("", null), + new TestData(null, null), + new TestData("23,56", null), + new TestData("2147483648", null), + new TestData("-2147483649", null), + new TestData("hello", null) + ); + testData.forEach(data -> { + Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.convertStringToIntUsingIntegerParseInt(data.input)); + Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.convertStringToIntUsingIntegerValueOf(data.input)); + Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.converStringToIntUsingOptional(data.input)); + Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.convertStringToIntUsingIntegerDecode(data.input)); + }); + } + + @Test + void whenConvertingIntToString_thenValidCasesReturnUnboxedInt() { + List testData = Arrays.asList( + new TestData("23", 23), + new TestData("-23", -23) + ); + testData.forEach(data -> { + Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.convertStringToIntUsingIntegerParseInt(data.input)); + Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.convertStringToIntUsingIntegerValueOf(data.input)); + Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.converStringToIntUsingOptional(data.input)); + Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.convertStringToIntUsingNumberUtils(data.input)); + Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.convertStringToIntUsingIntegerDecode(data.input)); + }); + } + + @Test + void whenConvertingStringToIntUsingNumberUtils_ThenInValidConversionReturnIntegerMin() { + List testData = Arrays.asList( + new TestData("", Integer.MIN_VALUE), + new TestData(null, Integer.MIN_VALUE), + new TestData("23,56", Integer.MIN_VALUE), + new TestData("2147483648", Integer.MIN_VALUE), + new TestData("-2147483649", Integer.MIN_VALUE), + new TestData("hello", Integer.MIN_VALUE) + ); + testData.forEach(data -> + Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.convertStringToIntUsingNumberUtils(data.input))); + } + + + public static class TestData{ + String input; + Integer expectedOutput; + + TestData(String input, Integer expectedOutput){ + this.input = input; + this.expectedOutput = expectedOutput; + } + } +} \ No newline at end of file From a7e728651567d4bf03040f4dfb0140119273c67d Mon Sep 17 00:00:00 2001 From: Deboshree Date: Fri, 24 Mar 2023 23:17:33 +0530 Subject: [PATCH 4/4] https://jira.baeldung.com/browse/BAEL- addressing PR comments --- ...ulation.java => StringToIntConverter.java} | 15 +++--- .../DateToStringFormatterUnitTest.java | 17 ++++--- ...java => StringToIntConverterUnitTest.java} | 50 +++++++------------ 3 files changed, 34 insertions(+), 48 deletions(-) rename core-java-modules/core-java-string-conversions/src/main/java/com/baeldung/stringtoint/{StringToIntEncapsulation.java => StringToIntConverter.java} (70%) rename core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/stringtoint/{StringToIntEncapsulationUnitTest.java => StringToIntConverterUnitTest.java} (58%) diff --git a/core-java-modules/core-java-string-conversions/src/main/java/com/baeldung/stringtoint/StringToIntEncapsulation.java b/core-java-modules/core-java-string-conversions/src/main/java/com/baeldung/stringtoint/StringToIntConverter.java similarity index 70% rename from core-java-modules/core-java-string-conversions/src/main/java/com/baeldung/stringtoint/StringToIntEncapsulation.java rename to core-java-modules/core-java-string-conversions/src/main/java/com/baeldung/stringtoint/StringToIntConverter.java index cac1a5e19b..03d77c2aea 100644 --- a/core-java-modules/core-java-string-conversions/src/main/java/com/baeldung/stringtoint/StringToIntEncapsulation.java +++ b/core-java-modules/core-java-string-conversions/src/main/java/com/baeldung/stringtoint/StringToIntConverter.java @@ -3,9 +3,9 @@ package com.baeldung.stringtoint; import java.util.Optional; import org.apache.commons.lang3.math.NumberUtils; -public class StringToIntEncapsulation { +public class StringToIntConverter { - private StringToIntEncapsulation() { + private StringToIntConverter() { } public static Integer convertStringToIntUsingIntegerParseInt(String input){ @@ -13,7 +13,7 @@ public class StringToIntEncapsulation { return Integer.parseInt(input); } catch (NumberFormatException e) { // log or handle the error - return null; // or Integer.MIN_VALUE, or some other default value + return Integer.MIN_VALUE; } } @@ -22,7 +22,7 @@ public class StringToIntEncapsulation { return Integer.valueOf(input); } catch (NumberFormatException e) { // log or handle the error - return null; // or Integer.MIN_VALUE, or some other default value + return Integer.MIN_VALUE; } } @@ -31,11 +31,11 @@ public class StringToIntEncapsulation { return Integer.decode(input); } catch (Exception e) { // log or handle the error - return null; // or Integer.MIN_VALUE, or some other default value + return Integer.MIN_VALUE; } } - public static Integer converStringToIntUsingOptional(String input){ + public static Integer convertStringToIntUsingOptional(String input){ Optional parsedInt; try { parsedInt = Optional.of(Integer.parseInt(input)); @@ -43,11 +43,10 @@ public class StringToIntEncapsulation { // log or handle the error parsedInt = Optional.empty(); } - return parsedInt.orElse(null); + return parsedInt.orElse(Integer.MIN_VALUE); } public static int convertStringToIntUsingNumberUtils(String input){ - //returns Integer.MIN_VALUE as the default value if conversion fails return NumberUtils.toInt(input, Integer.MIN_VALUE); } } diff --git a/core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/datetostring/DateToStringFormatterUnitTest.java b/core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/datetostring/DateToStringFormatterUnitTest.java index 2ad92adb2d..221900fb0e 100644 --- a/core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/datetostring/DateToStringFormatterUnitTest.java +++ b/core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/datetostring/DateToStringFormatterUnitTest.java @@ -19,6 +19,7 @@ import static org.junit.Assert.assertEquals; public class DateToStringFormatterUnitTest { private static final String DATE_FORMAT = "MMM d, yyyy HH:mm a"; + private static final String EXPECTED_STRING_DATE = "Aug 1, 2018 12:00 PM"; private static Date date; @BeforeClass @@ -33,8 +34,8 @@ public class DateToStringFormatterUnitTest { public void whenDateConvertedUsingSimpleDateFormatToString_thenCorrect() { DateFormat formatter = new SimpleDateFormat(DATE_FORMAT); String formattedDate = formatter.format(date); - String expectedDate = "Aug 1, 2018 12:00 pm"; - assertEquals(expectedDate, formattedDate); + + assertEquals(EXPECTED_STRING_DATE, formattedDate); } @Test @@ -42,15 +43,15 @@ public class DateToStringFormatterUnitTest { String formattedDate = DateFormat .getDateTimeInstance(DateFormat.MEDIUM, DateFormat.SHORT, Locale.US) .format(date); - String expectedDate = "Aug 1, 2018, 12:00 PM"; - assertEquals(expectedDate, formattedDate); + + assertEquals(EXPECTED_STRING_DATE, formattedDate); } @Test public void whenDateConvertedUsingFormatterToString_thenCorrect() { String formattedDate = String.format("%1$tb %1$te, %1$tY %1$tI:%1$tM %1$Tp", date); - String expectedDate = "Aug 1, 2018 12:00 PM"; - assertEquals(expectedDate, formattedDate); + + assertEquals(EXPECTED_STRING_DATE, formattedDate); } @Test @@ -61,7 +62,7 @@ public class DateToStringFormatterUnitTest { .atZone(ZoneId.of("CET")) .toLocalDateTime(); String formattedDate = ldt.format(fmt); - String expectedDate = "Aug 1, 2018 12:00 pm"; - assertEquals(expectedDate, formattedDate); + + assertEquals(EXPECTED_STRING_DATE, formattedDate); } } diff --git a/core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/stringtoint/StringToIntEncapsulationUnitTest.java b/core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/stringtoint/StringToIntConverterUnitTest.java similarity index 58% rename from core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/stringtoint/StringToIntEncapsulationUnitTest.java rename to core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/stringtoint/StringToIntConverterUnitTest.java index 46cbf61244..2bfb4db161 100644 --- a/core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/stringtoint/StringToIntEncapsulationUnitTest.java +++ b/core-java-modules/core-java-string-conversions/src/test/java/com/baeldung/stringtoint/StringToIntConverterUnitTest.java @@ -5,23 +5,24 @@ import java.util.List; import org.junit.jupiter.api.Assertions; import org.junit.jupiter.api.Test; -class StringToIntEncapsulationUnitTest { +class StringToIntConverterUnitTest { @Test - void whenConvertingIntToString_thenInvalidCasesReturnNull() { + void whenConvertingIntToString_thenInvalidCasesReturnIntegerMinValue() { List testData = Arrays.asList( - new TestData("", null), - new TestData(null, null), - new TestData("23,56", null), - new TestData("2147483648", null), - new TestData("-2147483649", null), - new TestData("hello", null) + new TestData("", Integer.MIN_VALUE), + new TestData(null, Integer.MIN_VALUE), + new TestData("23,56", Integer.MIN_VALUE), + new TestData("2147483648", Integer.MIN_VALUE), + new TestData("-2147483649", Integer.MIN_VALUE), + new TestData("hello", Integer.MIN_VALUE) ); testData.forEach(data -> { - Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.convertStringToIntUsingIntegerParseInt(data.input)); - Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.convertStringToIntUsingIntegerValueOf(data.input)); - Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.converStringToIntUsingOptional(data.input)); - Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.convertStringToIntUsingIntegerDecode(data.input)); + Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingIntegerParseInt(data.input)); + Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingIntegerValueOf(data.input)); + Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingOptional(data.input)); + Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingIntegerDecode(data.input)); + Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingNumberUtils(data.input)); }); } @@ -32,29 +33,14 @@ class StringToIntEncapsulationUnitTest { new TestData("-23", -23) ); testData.forEach(data -> { - Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.convertStringToIntUsingIntegerParseInt(data.input)); - Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.convertStringToIntUsingIntegerValueOf(data.input)); - Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.converStringToIntUsingOptional(data.input)); - Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.convertStringToIntUsingNumberUtils(data.input)); - Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.convertStringToIntUsingIntegerDecode(data.input)); + Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingIntegerParseInt(data.input)); + Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingIntegerValueOf(data.input)); + Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingOptional(data.input)); + Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingNumberUtils(data.input)); + Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingIntegerDecode(data.input)); }); } - @Test - void whenConvertingStringToIntUsingNumberUtils_ThenInValidConversionReturnIntegerMin() { - List testData = Arrays.asList( - new TestData("", Integer.MIN_VALUE), - new TestData(null, Integer.MIN_VALUE), - new TestData("23,56", Integer.MIN_VALUE), - new TestData("2147483648", Integer.MIN_VALUE), - new TestData("-2147483649", Integer.MIN_VALUE), - new TestData("hello", Integer.MIN_VALUE) - ); - testData.forEach(data -> - Assertions.assertEquals(data.expectedOutput, StringToIntEncapsulation.convertStringToIntUsingNumberUtils(data.input))); - } - - public static class TestData{ String input; Integer expectedOutput;