From 515bcf55ea8f2787c33ee8b8351374b192868208 Mon Sep 17 00:00:00 2001 From: ajay74984 <51405689+ajay74984@users.noreply.github.com> Date: Sun, 17 May 2020 20:51:59 +0200 Subject: [PATCH] OCP review comments. (#9310) * OCP change * calculator unit test * renamed variable and abstract class addition --- .../o/AbstractCalculatorOperation.java | 7 +++ .../main/java/com/baeldung/o/Addition.java | 28 ++++----- .../main/java/com/baeldung/o/Division.java | 62 +++++++++---------- .../main/java/com/baeldung/o/Subtraction.java | 28 ++++----- .../com/baeldung/o/CalculatorUnitTest.java | 10 +-- 5 files changed, 71 insertions(+), 64 deletions(-) create mode 100644 patterns/solid/src/main/java/com/baeldung/o/AbstractCalculatorOperation.java diff --git a/patterns/solid/src/main/java/com/baeldung/o/AbstractCalculatorOperation.java b/patterns/solid/src/main/java/com/baeldung/o/AbstractCalculatorOperation.java new file mode 100644 index 0000000000..798d5e2d95 --- /dev/null +++ b/patterns/solid/src/main/java/com/baeldung/o/AbstractCalculatorOperation.java @@ -0,0 +1,7 @@ +package com.baeldung.o; + +public abstract class AbstractCalculatorOperation { + + abstract void perform(); + +} diff --git a/patterns/solid/src/main/java/com/baeldung/o/Addition.java b/patterns/solid/src/main/java/com/baeldung/o/Addition.java index 6145b386d9..1ad99aad4b 100644 --- a/patterns/solid/src/main/java/com/baeldung/o/Addition.java +++ b/patterns/solid/src/main/java/com/baeldung/o/Addition.java @@ -1,29 +1,29 @@ package com.baeldung.o; public class Addition implements CalculatorOperation { - private double number1; - private double number2; + private double left; + private double right; private double result = 0.0; - public Addition(double number1, double number2) { - this.number1 = number1; - this.number2 = number2; + public Addition(double left, double right) { + this.left = left; + this.right = right; } - public double getNumber1() { - return number1; + public double getLeft() { + return left; } - public void setNumber1(double number1) { - this.number1 = number1; + public void setLeft(double left) { + this.left = left; } - public double getNumber2() { - return number2; + public double getRight() { + return right; } - public void setNumber2(double number2) { - this.number2 = number2; + public void setRight(double right) { + this.right = right; } public double getResult() { @@ -36,6 +36,6 @@ public class Addition implements CalculatorOperation { @Override public void perform() { - result = number1 + number2; + result = left + right; } } diff --git a/patterns/solid/src/main/java/com/baeldung/o/Division.java b/patterns/solid/src/main/java/com/baeldung/o/Division.java index 24ab4355c2..fbb8a1f523 100644 --- a/patterns/solid/src/main/java/com/baeldung/o/Division.java +++ b/patterns/solid/src/main/java/com/baeldung/o/Division.java @@ -1,43 +1,43 @@ package com.baeldung.o; public class Division implements CalculatorOperation { - private double number1; - private double number2; - private double result = 0.0; + private double left; + private double right; + private double result = 0.0; - public Division(double number1, double number2) { - this.number1 = number1; - this.number2 = number2; - } + public Division(double left, double right) { + this.left = left; + this.right = right; + } - public double getNumber1() { - return number1; - } + public double getLeft() { + return left; + } - public void setNumber1(double number1) { - this.number1 = number1; - } + public void setLeft(double left) { + this.left = left; + } - public double getNumber2() { - return number2; - } + public double getRight() { + return right; + } - public void setNumber2(double number2) { - this.number2 = number2; - } + public void setRight(double right) { + this.right = right; + } - public double getResult() { - return result; - } + public double getResult() { + return result; + } - public void setResult(double result) { - this.result = result; - } + public void setResult(double result) { + this.result = result; + } - @Override - public void perform() { - if (number2 != 0) { - result = number1 / number2; - } - } + @Override + public void perform() { + if (right != 0) { + result = left / right; + } + } } diff --git a/patterns/solid/src/main/java/com/baeldung/o/Subtraction.java b/patterns/solid/src/main/java/com/baeldung/o/Subtraction.java index b74e0c5f73..5827d33568 100644 --- a/patterns/solid/src/main/java/com/baeldung/o/Subtraction.java +++ b/patterns/solid/src/main/java/com/baeldung/o/Subtraction.java @@ -1,29 +1,29 @@ package com.baeldung.o; public class Subtraction implements CalculatorOperation { - private double number1; - private double number2; + private double left; + private double right; private double result = 0.0; - public Subtraction(double number1, double number2) { - this.number1 = number1; - this.number2 = number2; + public Subtraction(double left, double right) { + this.left = left; + this.right = right; } - public double getNumber1() { - return number1; + public double getLeft() { + return left; } - public void setNumber1(double number1) { - this.number1 = number1; + public void setLeft(double left) { + this.left = left; } - public double getNumber2() { - return number2; + public double getRight() { + return right; } - public void setNumber2(double number2) { - this.number2 = number2; + public void setRight(double right) { + this.right = right; } public double getResult() { @@ -36,6 +36,6 @@ public class Subtraction implements CalculatorOperation { @Override public void perform() { - result = number1 - number2; + result = left - right; } } diff --git a/patterns/solid/src/main/test/com/baeldung/o/CalculatorUnitTest.java b/patterns/solid/src/main/test/com/baeldung/o/CalculatorUnitTest.java index f372d450a7..3ae894e963 100644 --- a/patterns/solid/src/main/test/com/baeldung/o/CalculatorUnitTest.java +++ b/patterns/solid/src/main/test/com/baeldung/o/CalculatorUnitTest.java @@ -7,8 +7,8 @@ import org.junit.jupiter.api.Test; public class CalculatorUnitTest { - private static final double NUMBER_1 = 10.0; - private static final double NUMBER_2 = 20.0; + private static final double RIGHT = 10.0; + private static final double LEFT = 20.0; private static final double SUM = 30.0; private static final double SUBTRACTION_RESULT = 10.0; private static final double DIVISION_RESULT = 2.0; @@ -22,21 +22,21 @@ public class CalculatorUnitTest { @Test public void whenAddTwoNumber_returnSum() { - Addition addition = new Addition(NUMBER_1, NUMBER_2); + Addition addition = new Addition(RIGHT, LEFT); calculator.calculate(addition); assertEquals(SUM, addition.getResult(), 0.0); } @Test public void whenSutractTwoNumber_returnCorrectResult() { - Subtraction subtraction = new Subtraction(NUMBER_2, NUMBER_1); + Subtraction subtraction = new Subtraction(LEFT, RIGHT); calculator.calculate(subtraction); assertEquals(SUBTRACTION_RESULT, subtraction.getResult(), 0.0); } @Test public void whenDivideTwoNumber_returnCorrectResult() { - Division division = new Division(NUMBER_2, NUMBER_1); + Division division = new Division(LEFT, RIGHT); calculator.calculate(division); assertEquals(DIVISION_RESULT, division.getResult(), 0.0); }