Refactoring Code - short and simple

This commit is contained in:
Nikhil Khatwani 2016-11-12 15:03:07 +05:30
parent c30bd6caa7
commit 633162a04b

View File

@ -19,84 +19,77 @@ import com.baeldung.datetime.UseLocalDateTime;
public class StringConversionTest { public class StringConversionTest {
@Test @Test
public void givenString_whenConvertedToint_thenCorrect() { public void whenConvertedToint_thenCorrect() {
String str = "1"; assertEquals(Integer.parseInt("1"), 1);
assertEquals(Integer.parseInt(str), 1);
} }
@Test @Test
public void givenString_whenConvertedToInteger_thenCorrect() { public void whenConvertedToInteger_thenCorrect() {
String str = "12"; assertEquals(Integer.valueOf("12").equals(12), true);
Integer number = Integer.valueOf(str);
assertEquals(number.intValue(), 12);
} }
@Test @Test
public void givenString_whenConvertedTolong_thenCorrect() { public void whenConvertedTolong_thenCorrect() {
String str = "12345"; assertEquals(Long.parseLong("12345"), 12345);
assertEquals(Long.parseLong(str), 12345);
} }
@Test @Test
public void givenString_whenConvertedToLong_thenCorrect() { public void whenConvertedToLong_thenCorrect() {
String str = "14567"; assertEquals(Long.valueOf("14567").equals(14567L), true);
Long number = Long.valueOf(str);
assertEquals(number.longValue(), 14567);
} }
@Test @Test
public void givenString_whenConvertedTodouble_thenCorrect() { public void whenConvertedTodouble_thenCorrect() {
String str = "1.4"; assertEquals(Double.parseDouble("1.4"), 1.4, 0.0);
assertEquals(Double.parseDouble(str), 1.4, 0.0);
} }
@Test @Test
public void givenString_whenConvertedToDouble_thenCorrect() { public void whenConvertedToDouble_thenCorrect() {
String str = "145.67"; assertEquals(Double.valueOf("145.67").equals(145.67d), true);
Double number = Double.valueOf(str);
assertEquals(number.doubleValue(), 145.67, 0.0);
} }
@Test @Test
public void givenString_whenConvertedToByteArray_thenCorrect() throws UnsupportedEncodingException { public void whenConvertedToByteArray_thenCorrect() throws UnsupportedEncodingException {
byte[] byteArray1 = new byte[] { 'a', 'b', 'c' }; byte[] byteArray1 = new byte[] { 'a', 'b', 'c' };
String str = new String(byteArray1, "UTF-8"); String string = new String(byteArray1, "UTF-8");
assertEquals(Arrays.equals(str.getBytes(), byteArray1), true);
assertEquals(Arrays.equals(string.getBytes(), byteArray1), true);
} }
@Test @Test
public void givenString_whenConvertedToboolean_thenCorrect() { public void whenConvertedToboolean_thenCorrect() {
String str = "true"; assertEquals(Boolean.parseBoolean("true"), true);
assertEquals(Boolean.parseBoolean(str), true);
} }
@Test @Test
public void givenString_whenConvertedToBoolean_thenCorrect() { public void whenConvertedToBoolean_thenCorrect() {
String str = "true"; assertEquals(Boolean.valueOf("true"), true);
assertEquals(Boolean.valueOf(str), true);
} }
@Test @Test
public void givenString_whenConvertedToCharArray_thenCorrect() { public void whenConvertedToCharArray_thenCorrect() {
String str = "hello"; String str = "hello";
char[] charArray = { 'h', 'e', 'l', 'l', 'o' }; char[] charArray = { 'h', 'e', 'l', 'l', 'o' };
assertEquals(Arrays.equals(charArray, str.toCharArray()), true); assertEquals(Arrays.equals(charArray, str.toCharArray()), true);
} }
@Test @Test
public void givenString_whenConvertedToJava6Date_thenCorrect() throws ParseException { public void whenConvertedToJava6Date_thenCorrect() throws ParseException {
String str = "15/10/2013"; String str = "15/10/2013";
SimpleDateFormat formatter = new SimpleDateFormat("dd/M/yyyy"); SimpleDateFormat formatter = new SimpleDateFormat("dd/M/yyyy");
Date date1 = formatter.parse(str); Date date1 = formatter.parse(str);
Calendar calendar = new GregorianCalendar(2013, 9, 15); Calendar calendar = new GregorianCalendar(2013, 9, 15);
Date date2 = calendar.getTime(); Date date2 = calendar.getTime();
assertEquals(date1.compareTo(date2), 0); assertEquals(date1.compareTo(date2), 0);
} }
@Test @Test
public void givenString_whenConvertedToJava8Date_thenCorrect() throws ParseException { public void whenConvertedToJava8Date_thenCorrect() throws ParseException {
String str = "2007-12-03T10:15:30"; String str = "2007-12-03T10:15:30";
LocalDateTime localDateTime = new UseLocalDateTime().getLocalDateTimeUsingParseMethod(str); LocalDateTime localDateTime = new UseLocalDateTime().getLocalDateTimeUsingParseMethod(str);
assertEquals(localDateTime.getDayOfMonth(), 3); assertEquals(localDateTime.getDayOfMonth(), 3);
assertEquals(localDateTime.getMonth(), Month.DECEMBER); assertEquals(localDateTime.getMonth(), Month.DECEMBER);
assertEquals(localDateTime.getYear(), 2007); assertEquals(localDateTime.getYear(), 2007);