From 60880ad40100b14b05596ba48d787ffaed44a4bd Mon Sep 17 00:00:00 2001
From: eric-martin <emart.tigers@gmail.com>
Date: Wed, 1 Jan 2020 16:59:11 -0600
Subject: [PATCH 1/2] BAEL-3517: Code Review Feedback Applied

---
 java-numbers-3/pom.xml                        |  2 --
 .../doubletolong/DoubleToLongUnitTest.java    | 26 ++++++++++++++++---
 pom.xml                                       |  2 ++
 3 files changed, 24 insertions(+), 6 deletions(-)
 rename java-numbers-3/src/{main => test}/java/com/baeldung/doubletolong/DoubleToLongUnitTest.java (50%)

diff --git a/java-numbers-3/pom.xml b/java-numbers-3/pom.xml
index 0559bf2c34..3dd8e16bc7 100644
--- a/java-numbers-3/pom.xml
+++ b/java-numbers-3/pom.xml
@@ -3,7 +3,6 @@
     xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
     <artifactId>java-numbers-3</artifactId>
-    <version>0.0.1-SNAPSHOT</version>
     <name>java-numbers-3</name>
     <packaging>jar</packaging>
 
@@ -13,7 +12,6 @@
         <version>0.0.1-SNAPSHOT</version>
         <relativePath>../parent-java</relativePath>
     </parent>
-
    
     <build>
         <finalName>java-numbers-3</finalName>
diff --git a/java-numbers-3/src/main/java/com/baeldung/doubletolong/DoubleToLongUnitTest.java b/java-numbers-3/src/test/java/com/baeldung/doubletolong/DoubleToLongUnitTest.java
similarity index 50%
rename from java-numbers-3/src/main/java/com/baeldung/doubletolong/DoubleToLongUnitTest.java
rename to java-numbers-3/src/test/java/com/baeldung/doubletolong/DoubleToLongUnitTest.java
index a2e8406396..e98201d3f0 100644
--- a/java-numbers-3/src/main/java/com/baeldung/doubletolong/DoubleToLongUnitTest.java
+++ b/java-numbers-3/src/test/java/com/baeldung/doubletolong/DoubleToLongUnitTest.java
@@ -9,28 +9,46 @@ public class DoubleToLongUnitTest {
 
     @Test
     public void givenDoubleValue_whenLongValueCalled_thenLongValueReturned() {
-        Assert.assertEquals(9999L, Double.valueOf(VALUE)
-            .longValue());
+        Assert.assertEquals(9999L, Double.valueOf(VALUE).longValue());
     }
 
     @Test
-    public void givenDoubleValue_whenMathRoundUseds_thenLongValueReturned() {
+    public void givenDoubleValue_whenMathRoundUsed_thenLongValueReturned() {
         Assert.assertEquals(10000L, Math.round(VALUE));
     }
 
+    @Test
+    public void givenDoubleValue_whenMathRoundUsed_thenRoundDown() {
+        Assert.assertEquals(9999L, Math.round(9999.444));
+    }
+
     @Test
     public void givenDoubleValue_whenMathCeilUsed_thenLongValueReturned() {
         Assert.assertEquals(10000L, Math.ceil(VALUE), 0);
     }
 
+    @Test
+    public void givenDoubleValue_whenMathCeilUsed_thenSameValueReturned() {
+        Assert.assertEquals(9999L, Math.ceil(9999.0), 0);
+    }
+
+    @Test
+    public void givenDoubleValue_whenMathCeilUsed_thenDifferentThanRound() {
+        Assert.assertEquals(10000L, Math.ceil(9999.444), 0);
+    }
+
     @Test
     public void givenDoubleValue_whenMathFloorUsed_thenLongValueReturned() {
         Assert.assertEquals(9999L, Math.floor(VALUE), 0);
     }
 
+    @Test
+    public void givenDoubleValue_whenMathFloorUsed_thenSameValueReturned() {
+        Assert.assertEquals(9999L, Math.floor(9999.0), 0);
+    }
+
     @Test
     public void givenDoubleValue_whenTypeCasted_thenLongValueReturned() {
         Assert.assertEquals(9999L, (long) VALUE);
     }
-
 }
diff --git a/pom.xml b/pom.xml
index cc0c68d22f..7383ab1a01 100644
--- a/pom.xml
+++ b/pom.xml
@@ -511,6 +511,7 @@
                 <module>java-math-2</module> <!-- Added for BAEL-3506 -->
                 <module>java-numbers</module>
                 <module>java-numbers-2</module>
+                <module>java-numbers-3</module>
                 <module>java-rmi</module>
                 <module>java-spi</module>
                 <module>java-vavr-stream</module>
@@ -1144,6 +1145,7 @@
                 <module>java-math-2</module>  <!-- Added for BAEL-3506 -->
                 <module>java-numbers</module>
                 <module>java-numbers-2</module>
+                <module>java-numbers-3</module>
                 <module>java-rmi</module>
                 <module>java-spi</module>
                 <module>java-vavr-stream</module>

From a0fa9f23b3ab562dce36e88faf5d72701f055744 Mon Sep 17 00:00:00 2001
From: eric-martin <emart.tigers@gmail.com>
Date: Wed, 1 Jan 2020 17:51:52 -0600
Subject: [PATCH 2/2] Add a few additional test cases

---
 .../baeldung/doubletolong/DoubleToLongUnitTest.java  | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/java-numbers-3/src/test/java/com/baeldung/doubletolong/DoubleToLongUnitTest.java b/java-numbers-3/src/test/java/com/baeldung/doubletolong/DoubleToLongUnitTest.java
index e98201d3f0..702c59c12b 100644
--- a/java-numbers-3/src/test/java/com/baeldung/doubletolong/DoubleToLongUnitTest.java
+++ b/java-numbers-3/src/test/java/com/baeldung/doubletolong/DoubleToLongUnitTest.java
@@ -13,7 +13,7 @@ public class DoubleToLongUnitTest {
     }
 
     @Test
-    public void givenDoubleValue_whenMathRoundUsed_thenLongValueReturned() {
+    public void givenDoubleValue_whenMathRoundUsed_thenRoundUp() {
         Assert.assertEquals(10000L, Math.round(VALUE));
     }
 
@@ -22,6 +22,11 @@ public class DoubleToLongUnitTest {
         Assert.assertEquals(9999L, Math.round(9999.444));
     }
 
+    @Test
+    public void givenDoubleValue_whenMathRoundUsed_thenSameValueReturned() {
+        Assert.assertEquals(9999L, Math.round(9999.0));
+    }
+
     @Test
     public void givenDoubleValue_whenMathCeilUsed_thenLongValueReturned() {
         Assert.assertEquals(10000L, Math.ceil(VALUE), 0);
@@ -47,6 +52,11 @@ public class DoubleToLongUnitTest {
         Assert.assertEquals(9999L, Math.floor(9999.0), 0);
     }
 
+    @Test
+    public void givenDoubleValue_whenMathFloorUsed_thenDifferentThanCeil() {
+        Assert.assertEquals(9999L, Math.floor(9999.444), 0);
+    }
+
     @Test
     public void givenDoubleValue_whenTypeCasted_thenLongValueReturned() {
         Assert.assertEquals(9999L, (long) VALUE);