JAVA-12359 Code Review Changes
This commit is contained in:
parent
ca3fe06a56
commit
675e33fbab
|
@ -7,7 +7,7 @@ import java.util.Arrays;
|
|||
|
||||
public class StringFilenameValidationUtils {
|
||||
|
||||
public static final Character[] INVALID_WINDOWS_SPECIFIC_CHARS = {'"', '*', ':', '<', '>', '?', '\\', '|'};
|
||||
public static final Character[] INVALID_WINDOWS_SPECIFIC_CHARS = {'"', '*', '<', '>', '?', '|'};
|
||||
public static final Character[] INVALID_UNIX_SPECIFIC_CHARS = {'\000'};
|
||||
|
||||
public static final String REGEX_PATTERN = "^[A-za-z0-9.]{1,255}$";
|
||||
|
|
|
@ -82,16 +82,12 @@ public class StringFilenameValidationUnitTest {
|
|||
@MethodSource("filenamesWithInvalidWindowsChars")
|
||||
public void givenFilenameStringWithInvalidWindowsCharAndIsWindows_whenValidateUsingIO_thenRaiseException(
|
||||
String filename) {
|
||||
if (!filename.contains(":")) {
|
||||
assertThatThrownBy(() -> validateStringFilenameUsingIO(filename)).isInstanceOf(IOException.class)
|
||||
.extracting(Throwable::getMessage, InstanceOfAssertFactories.STRING)
|
||||
.containsAnyOf("The system cannot find the path specifie",
|
||||
.containsAnyOf("The system cannot find the path specified",
|
||||
"The filename, directory name, or volume label syntax is incorrect");
|
||||
if (!filename.contains("\\")) {
|
||||
assertThatThrownBy(() -> validateStringFilenameUsingNIO2(filename))
|
||||
.isInstanceOf(InvalidPathException.class).hasMessageContaining("Illegal char");
|
||||
}
|
||||
}
|
||||
assertThatThrownBy(() -> validateStringFilenameUsingNIO2(filename)).isInstanceOf(InvalidPathException.class)
|
||||
.hasMessageContaining("Illegal char");
|
||||
|
||||
assertThat(validateStringFilenameUsingContains(filename)).isFalse();
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue