iSharkFly-Docs
/
java-tutorials
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update download servlet to try-with-resources block. (#4453)

This commit is contained in:
pauljervis 2018-07-04 08:43:48 +01:00 committed by Eugen
parent 3b3008b6d5
commit 684324fc10
1 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
javax-servlets/src/main/java/com/baeldung/servlets/DownloadServlet.java
View File

@ -4,7 +4,6 @@ import java.io.IOException;
import java.io.InputStream; import java.io.InputStream;
import java.io.OutputStream; import java.io.OutputStream;
import javax.servlet.ServletException;
import javax.servlet.annotation.WebServlet; import javax.servlet.annotation.WebServlet;
import javax.servlet.http.HttpServlet; import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
@ -15,12 +14,12 @@ public class DownloadServlet extends HttpServlet {
private final int ARBITARY_SIZE = 1048; private final int ARBITARY_SIZE = 1048;
@Override @Override
protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException { protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException {
resp.setContentType("text/plain"); resp.setContentType("text/plain");
resp.setHeader("Content-disposition", "attachment; filename=sample.txt"); resp.setHeader("Content-disposition", "attachment; filename=sample.txt");
OutputStream out = resp.getOutputStream(); try (InputStream in = req.getServletContext().getResourceAsStream("/WEB-INF/sample.txt");
InputStream in = req.getServletContext().getResourceAsStream("/WEB-INF/sample.txt"); OutputStream out = resp.getOutputStream()) {
byte[] buffer = new byte[ARBITARY_SIZE]; byte[] buffer = new byte[ARBITARY_SIZE];
@ -28,8 +27,6 @@ public class DownloadServlet extends HttpServlet {
while ((numBytesRead = in.read(buffer)) > 0) { while ((numBytesRead = in.read(buffer)) > 0) {
out.write(buffer, 0, numBytesRead); out.write(buffer, 0, numBytesRead);
} }
}
in.close();
out.flush();
} }
} }