From 6a1f8e76c5238e3b211427578b951de5963460f1 Mon Sep 17 00:00:00 2001 From: BudBak Date: Mon, 20 Jan 2020 13:53:26 +0530 Subject: [PATCH] BAEL-3481 - Fixed Formatting. --- .../BalancedBracketsUsingDeque.java | 54 ++++---- .../BalancedBracketsUsingString.java | 38 +++--- .../BalancedBracketsUsingDequeUnitTest.java | 116 +++++++++--------- .../BalancedBracketsUsingStringUnitTest.java | 114 +++++++++-------- 4 files changed, 155 insertions(+), 167 deletions(-) diff --git a/algorithms-miscellaneous-5/src/main/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingDeque.java b/algorithms-miscellaneous-5/src/main/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingDeque.java index cc3e246962..4c220b4047 100644 --- a/algorithms-miscellaneous-5/src/main/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingDeque.java +++ b/algorithms-miscellaneous-5/src/main/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingDeque.java @@ -5,36 +5,32 @@ import java.util.LinkedList; public class BalancedBracketsUsingDeque { - public boolean isBalanced(String str) { - if (null == str || ((str.length() % 2) != 0)) { - return false; - } else { - char[] ch = str.toCharArray(); - for (char c : ch) { - if (!(c == '{' || c == '[' || c == '(' || c == '}' || c == ']' || c == ')')) { - return false; - } - - } + public boolean isBalanced(String str) { + if (null == str || ((str.length() % 2) != 0)) { + return false; + } else { + char[] ch = str.toCharArray(); + for (char c : ch) { + if (!(c == '{' || c == '[' || c == '(' || c == '}' || c == ']' || c == ')')) { + return false; } - Deque deque = new LinkedList<>(); - for (char ch: str.toCharArray()) { - if (ch == '{' || ch == '[' || ch == '(') { - deque.addFirst(ch); - } else { - if ( !deque.isEmpty() - && ((deque.peekFirst() == '{' && ch == '}') - || (deque.peekFirst() == '[' && ch == ']') - || (deque.peekFirst() == '(' && ch == ')') - )) { - deque.removeFirst(); - } else { - return false; - } - } - } - - return true; + } } + + Deque deque = new LinkedList<>(); + for (char ch : str.toCharArray()) { + if (ch == '{' || ch == '[' || ch == '(') { + deque.addFirst(ch); + } else { + if (!deque.isEmpty() && ((deque.peekFirst() == '{' && ch == '}') || (deque.peekFirst() == '[' && ch == ']') || (deque.peekFirst() == '(' && ch == ')'))) { + deque.removeFirst(); + } else { + return false; + } + } + } + + return true; + } } \ No newline at end of file diff --git a/algorithms-miscellaneous-5/src/main/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingString.java b/algorithms-miscellaneous-5/src/main/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingString.java index 60d7191597..0418efbe79 100644 --- a/algorithms-miscellaneous-5/src/main/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingString.java +++ b/algorithms-miscellaneous-5/src/main/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingString.java @@ -2,26 +2,26 @@ package com.baeldung.algorithms.balancedbrackets; public class BalancedBracketsUsingString { - public boolean isBalanced(String str) { - if (null == str || ((str.length() % 2) != 0)) { - return false; - } else { - char[] ch = str.toCharArray(); - for(char c : ch) { - if(!(c == '{' || c == '[' || c == '(' || c == '}' || c == ']' || c == ')')) { - return false; - } - - } + public boolean isBalanced(String str) { + if (null == str || ((str.length() % 2) != 0)) { + return false; + } else { + char[] ch = str.toCharArray(); + for (char c : ch) { + if (!(c == '{' || c == '[' || c == '(' || c == '}' || c == ']' || c == ')')) { + return false; } - while (str.contains("()") || str.contains("[]") || str.contains("{}")) { - str = str.replaceAll("\\(\\)", "") - .replaceAll("\\[\\]", "") - .replaceAll("\\{\\}", ""); - } - return (str.length() == 0); - + } } -} \ No newline at end of file + while (str.contains("()") || str.contains("[]") || str.contains("{}")) { + str = str.replaceAll("\\(\\)", "") + .replaceAll("\\[\\]", "") + .replaceAll("\\{\\}", ""); + } + return (str.length() == 0); + + } + +} \ No newline at end of file diff --git a/algorithms-miscellaneous-5/src/test/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingDequeUnitTest.java b/algorithms-miscellaneous-5/src/test/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingDequeUnitTest.java index d7bed3000b..964c1ce11a 100644 --- a/algorithms-miscellaneous-5/src/test/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingDequeUnitTest.java +++ b/algorithms-miscellaneous-5/src/test/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingDequeUnitTest.java @@ -6,75 +6,71 @@ import org.junit.Test; import static org.assertj.core.api.Assertions.assertThat; public class BalancedBracketsUsingDequeUnitTest { - private BalancedBracketsUsingDeque balancedBracketsUsingDeque; + private BalancedBracketsUsingDeque balancedBracketsUsingDeque; - @Before - public void setup() { - balancedBracketsUsingDeque = new BalancedBracketsUsingDeque(); - } + @Before + public void setup() { + balancedBracketsUsingDeque = new BalancedBracketsUsingDeque(); + } + @Test + public void givenNullInput_whenCheckingForBalance_shouldReturnFalse() { + boolean result = balancedBracketsUsingDeque.isBalanced(null); + assertThat(result).isFalse(); + } - @Test - public void givenNullInput_whenCheckingForBalance_shouldReturnFalse() { - boolean result = balancedBracketsUsingDeque.isBalanced(null); - assertThat(result).isFalse(); - } + @Test + public void givenEmptyString_whenCheckingForBalance_shouldReturnTrue() { + boolean result = balancedBracketsUsingDeque.isBalanced(""); + assertThat(result).isTrue(); + } - @Test - public void givenEmptyString_whenCheckingForBalance_shouldReturnTrue() { - boolean result = balancedBracketsUsingDeque.isBalanced(""); - assertThat(result).isTrue(); - } + @Test + public void givenInvalidCharacterString_whenCheckingForBalance_shouldReturnFalse() { + boolean result = balancedBracketsUsingDeque.isBalanced("abc[](){}"); + assertThat(result).isFalse(); + } - @Test - public void givenInvalidCharacterString_whenCheckingForBalance_shouldReturnFalse() { - boolean result = balancedBracketsUsingDeque.isBalanced("abc[](){}"); - assertThat(result).isFalse(); - } + @Test + public void givenOddLengthString_whenCheckingForBalance_shouldReturnFalse() { + boolean result = balancedBracketsUsingDeque.isBalanced("{{[]()}}}"); + assertThat(result).isFalse(); + } - @Test - public void givenOddLengthString_whenCheckingForBalance_shouldReturnFalse() { - boolean result = balancedBracketsUsingDeque.isBalanced("{{[]()}}}"); - assertThat(result).isFalse(); - } + @Test + public void givenEvenLengthString_whenCheckingForBalance_shouldReturnFalse() { + boolean result = balancedBracketsUsingDeque.isBalanced("{{[]()}}}}"); + assertThat(result).isFalse(); + } - @Test - public void givenEvenLengthString_whenCheckingForBalance_shouldReturnFalse() { - boolean result = balancedBracketsUsingDeque.isBalanced("{{[]()}}}}"); - assertThat(result).isFalse(); - } + @Test + public void givenEvenLengthUnbalancedString_whenCheckingForBalance_shouldReturnFalse() { + boolean result = balancedBracketsUsingDeque.isBalanced("{[(])}"); + assertThat(result).isFalse(); + } - @Test - public void givenEvenLengthUnbalancedString_whenCheckingForBalance_shouldReturnFalse() { - boolean result = balancedBracketsUsingDeque.isBalanced("{[(])}"); - assertThat(result).isFalse(); - } + @Test + public void givenEvenLengthBalancedString_whenCheckingForBalance_shouldReturnTrue() { + boolean result = balancedBracketsUsingDeque.isBalanced("{[()]}"); + assertThat(result).isTrue(); + } + @Test + public void givenBalancedString_whenCheckingForBalance_shouldReturnTrue() { + boolean result = balancedBracketsUsingDeque.isBalanced("{{[[(())]]}}"); + assertThat(result).isTrue(); + } - @Test - public void givenEvenLengthBalancedString_whenCheckingForBalance_shouldReturnTrue() { - boolean result = balancedBracketsUsingDeque.isBalanced("{[()]}"); - assertThat(result).isTrue(); - } + @Test + public void givenAnotherBalancedString_whenCheckingForBalance_shouldReturnTrue() { + boolean result = balancedBracketsUsingDeque.isBalanced("{{([])}}"); + assertThat(result).isTrue(); + } - @Test - public void givenBalancedString_whenCheckingForBalance_shouldReturnTrue() { - boolean result = balancedBracketsUsingDeque.isBalanced("{{[[(())]]}}"); - assertThat(result).isTrue(); - } + @Test + public void givenUnBalancedString_whenCheckingForBalance_shouldReturnFalse() { + boolean result = balancedBracketsUsingDeque.isBalanced("{{)[](}}"); + assertThat(result).isFalse(); + } - - @Test - public void givenAnotherBalancedString_whenCheckingForBalance_shouldReturnTrue() { - boolean result = balancedBracketsUsingDeque.isBalanced("{{([])}}"); - assertThat(result).isTrue(); - } - - - @Test - public void givenUnBalancedString_whenCheckingForBalance_shouldReturnFalse() { - boolean result = balancedBracketsUsingDeque.isBalanced("{{)[](}}"); - assertThat(result).isFalse(); - } - -} \ No newline at end of file +} \ No newline at end of file diff --git a/algorithms-miscellaneous-5/src/test/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingStringUnitTest.java b/algorithms-miscellaneous-5/src/test/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingStringUnitTest.java index 8f4d72d0e7..69ce42b0f1 100644 --- a/algorithms-miscellaneous-5/src/test/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingStringUnitTest.java +++ b/algorithms-miscellaneous-5/src/test/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingStringUnitTest.java @@ -6,75 +6,71 @@ import org.junit.Test; import static org.assertj.core.api.Assertions.assertThat; public class BalancedBracketsUsingStringUnitTest { - private BalancedBracketsUsingString balancedBracketsUsingString; + private BalancedBracketsUsingString balancedBracketsUsingString; - @Before - public void setup() { - balancedBracketsUsingString = new BalancedBracketsUsingString(); - } + @Before + public void setup() { + balancedBracketsUsingString = new BalancedBracketsUsingString(); + } + @Test + public void givenNullInput_whenCheckingForBalance_shouldReturnFalse() { + boolean result = balancedBracketsUsingString.isBalanced(null); + assertThat(result).isFalse(); + } - @Test - public void givenNullInput_whenCheckingForBalance_shouldReturnFalse() { - boolean result = balancedBracketsUsingString.isBalanced(null); - assertThat(result).isFalse(); - } + @Test + public void givenEmptyString_whenCheckingForBalance_shouldReturnTrue() { + boolean result = balancedBracketsUsingString.isBalanced(""); + assertThat(result).isTrue(); + } - @Test - public void givenEmptyString_whenCheckingForBalance_shouldReturnTrue() { - boolean result = balancedBracketsUsingString.isBalanced(""); - assertThat(result).isTrue(); - } + @Test + public void givenInvalidCharacterString_whenCheckingForBalance_shouldReturnFalse() { + boolean result = balancedBracketsUsingString.isBalanced("abc[](){}"); + assertThat(result).isFalse(); + } - @Test - public void givenInvalidCharacterString_whenCheckingForBalance_shouldReturnFalse() { - boolean result = balancedBracketsUsingString.isBalanced("abc[](){}"); - assertThat(result).isFalse(); - } + @Test + public void givenOddLengthString_whenCheckingForBalance_shouldReturnFalse() { + boolean result = balancedBracketsUsingString.isBalanced("{{[]()}}}"); + assertThat(result).isFalse(); + } - @Test - public void givenOddLengthString_whenCheckingForBalance_shouldReturnFalse() { - boolean result = balancedBracketsUsingString.isBalanced("{{[]()}}}"); - assertThat(result).isFalse(); - } + @Test + public void givenEvenLengthString_whenCheckingForBalance_shouldReturnFalse() { + boolean result = balancedBracketsUsingString.isBalanced("{{[]()}}}}"); + assertThat(result).isFalse(); + } - @Test - public void givenEvenLengthString_whenCheckingForBalance_shouldReturnFalse() { - boolean result = balancedBracketsUsingString.isBalanced("{{[]()}}}}"); - assertThat(result).isFalse(); - } + @Test + public void givenEvenLengthUnbalancedString_whenCheckingForBalance_shouldReturnFalse() { + boolean result = balancedBracketsUsingString.isBalanced("{[(])}"); + assertThat(result).isFalse(); + } - @Test - public void givenEvenLengthUnbalancedString_whenCheckingForBalance_shouldReturnFalse() { - boolean result = balancedBracketsUsingString.isBalanced("{[(])}"); - assertThat(result).isFalse(); - } + @Test + public void givenEvenLengthBalancedString_whenCheckingForBalance_shouldReturnTrue() { + boolean result = balancedBracketsUsingString.isBalanced("{[()]}"); + assertThat(result).isTrue(); + } + @Test + public void givenBalancedString_whenCheckingForBalance_shouldReturnTrue() { + boolean result = balancedBracketsUsingString.isBalanced("{{[[(())]]}}"); + assertThat(result).isTrue(); + } - @Test - public void givenEvenLengthBalancedString_whenCheckingForBalance_shouldReturnTrue() { - boolean result = balancedBracketsUsingString.isBalanced("{[()]}"); - assertThat(result).isTrue(); - } + @Test + public void givenAnotherBalancedString_whenCheckingForBalance_shouldReturnTrue() { + boolean result = balancedBracketsUsingString.isBalanced("{{([])}}"); + assertThat(result).isTrue(); + } - @Test - public void givenBalancedString_whenCheckingForBalance_shouldReturnTrue() { - boolean result = balancedBracketsUsingString.isBalanced("{{[[(())]]}}"); - assertThat(result).isTrue(); - } - - - @Test - public void givenAnotherBalancedString_whenCheckingForBalance_shouldReturnTrue() { - boolean result = balancedBracketsUsingString.isBalanced("{{([])}}"); - assertThat(result).isTrue(); - } - - - @Test - public void givenUnBalancedString_whenCheckingForBalance_shouldReturnFalse() { - boolean result = balancedBracketsUsingString.isBalanced("{{)[](}}"); - assertThat(result).isFalse(); - } + @Test + public void givenUnBalancedString_whenCheckingForBalance_shouldReturnFalse() { + boolean result = balancedBracketsUsingString.isBalanced("{{)[](}}"); + assertThat(result).isFalse(); + } } \ No newline at end of file