Updated unit test to use assertj (#4025)

This commit is contained in:
tamasradu 2018-04-16 17:38:24 +03:00 committed by maibin
parent 6f887d29c6
commit 72b5ac265c
1 changed files with 56 additions and 66 deletions

View File

@ -1,11 +1,10 @@
package com.baeldung.netty; package com.baeldung.netty;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import java.nio.charset.Charset; import java.nio.charset.Charset;
import org.junit.Assert; import static org.assertj.core.api.Assertions.*;
import org.assertj.core.api.Assertions;
import org.junit.Test; import org.junit.Test;
import io.netty.channel.embedded.EmbeddedChannel; import io.netty.channel.embedded.EmbeddedChannel;
@ -21,87 +20,78 @@ public class EmbeddedChannelUnitTest {
@Test @Test
public void givenTwoChannelHandlers_testPipeline() { public void givenTwoChannelHandlers_testPipeline() {
final FullHttpRequest httpRequest = new DefaultFullHttpRequest(HttpVersion.HTTP_1_1, HttpMethod.GET, "/calculate?a=10&b=5"); final FullHttpRequest httpRequest = new DefaultFullHttpRequest(HttpVersion.HTTP_1_1, HttpMethod.GET,
"/calculate?a=10&b=5");
httpRequest.headers().add("Operator", "Add"); httpRequest.headers().add("Operator", "Add");
EmbeddedChannel channel = new EmbeddedChannel( EmbeddedChannel channel = new EmbeddedChannel(new HttpMessageHandler(), new CalculatorOperationHandler());
new HttpMessageHandler(), new CalculatorOperationHandler());
channel.pipeline()
.addFirst(new HttpMessageHandler())
.addLast(new CalculatorOperationHandler());
channel.pipeline().addFirst(new HttpMessageHandler()).addLast(new CalculatorOperationHandler());
// send HTTP request to server and check that the message is on the inbound pipeline // send HTTP request to server and check that the message is on the inbound pipeline
assertTrue(channel.writeInbound(httpRequest)); assertThat(channel.writeInbound(httpRequest)).isTrue();
long inboundChannelResponse = channel.readInbound(); long inboundChannelResponse = channel.readInbound();
assertEquals(15, inboundChannelResponse); assertThat(inboundChannelResponse).isEqualTo(15);
// we should have an outbound message in the form of a HTTP response // we should have an outbound message in the form of a HTTP response
assertEquals(1, channel.outboundMessages().size()); assertThat(channel.outboundMessages().size()).isEqualTo(1);
// Object response = channel.readOutbound(); // Object response = channel.readOutbound();
FullHttpResponse httpResponse = channel.readOutbound(); FullHttpResponse httpResponse = channel.readOutbound();
String httpResponseContent = httpResponse.content().toString(Charset.defaultCharset()); String httpResponseContent = httpResponse.content().toString(Charset.defaultCharset());
assertTrue("15".equalsIgnoreCase(httpResponseContent)); assertThat(httpResponseContent).isEqualTo("15");
} }
@Test @Test
public void givenTwoChannelHandlers_testExceptionHandlingInHttpMessageHandler() { public void givenTwoChannelHandlers_testExceptionHandlingInHttpMessageHandler() {
EmbeddedChannel channel = new EmbeddedChannel( EmbeddedChannel channel = new EmbeddedChannel(new HttpMessageHandler(), new CalculatorOperationHandler());
new HttpMessageHandler(), new CalculatorOperationHandler());
final FullHttpRequest wrongHttpRequest = new DefaultFullHttpRequest(HttpVersion.HTTP_1_1, HttpMethod.POST, "/calculate?a=10&b=5"); final FullHttpRequest wrongHttpRequest = new DefaultFullHttpRequest(HttpVersion.HTTP_1_1, HttpMethod.POST,
"/calculate?a=10&b=5");
wrongHttpRequest.headers().add("Operator", "Add"); wrongHttpRequest.headers().add("Operator", "Add");
try { Throwable thrownException = catchThrowable(() -> {
// send invalid HTTP request to server and expect and error // send invalid HTTP request to server and expect and error
channel.pipeline().fireChannelRead(wrongHttpRequest); channel.pipeline().fireChannelRead(wrongHttpRequest);
channel.checkException(); channel.checkException();
// channel.writeInbound(wrongHttpRequest); Assertions.failBecauseExceptionWasNotThrown(UnsupportedOperationException.class);
Assert.fail(); });
} catch (Exception ex) { assertThat(thrownException)
.isInstanceOf(UnsupportedOperationException.class)
// the HttpMessageHandler does not handle the exception and throws it down the pipeline .hasMessage("HTTP method not supported");
assertTrue(ex instanceof UnsupportedOperationException);
assertTrue(ex.getMessage().equalsIgnoreCase("HTTP method not supported"));
FullHttpResponse errorHttpResponse = channel.readOutbound(); FullHttpResponse errorHttpResponse = channel.readOutbound();
String errorHttpResponseContent = errorHttpResponse.content().toString(Charset.defaultCharset()); String errorHttpResponseContent = errorHttpResponse.content().toString(Charset.defaultCharset());
assertTrue("Operation not defined".equalsIgnoreCase(errorHttpResponseContent)); assertThat(errorHttpResponseContent).isEqualToIgnoringCase("Operation not defined");
assertEquals(HttpResponseStatus.INTERNAL_SERVER_ERROR, errorHttpResponse.status()); assertThat(errorHttpResponse.status()).isEqualTo(HttpResponseStatus.INTERNAL_SERVER_ERROR);
} }
}
@Test @Test
public void givenTwoChannelHandlers_testExceptionHandlingInCalculatorOperationHandler() { public void givenTwoChannelHandlers_testExceptionHandlingInCalculatorOperationHandler() {
EmbeddedChannel channel = new EmbeddedChannel( EmbeddedChannel channel = new EmbeddedChannel(new HttpMessageHandler(), new CalculatorOperationHandler());
new HttpMessageHandler(), new CalculatorOperationHandler());
final FullHttpRequest wrongHttpRequest = new DefaultFullHttpRequest(HttpVersion.HTTP_1_1, HttpMethod.GET, "/calculate?a=10&b=5"); final FullHttpRequest wrongHttpRequest = new DefaultFullHttpRequest(HttpVersion.HTTP_1_1, HttpMethod.GET,
"/calculate?a=10&b=5");
wrongHttpRequest.headers().add("Operator", "Invalid_operation"); wrongHttpRequest.headers().add("Operator", "Invalid_operation");
try { Throwable thrownException = catchThrowable(() -> {
// send invalid HTTP request to server and expect and error // send invalid HTTP request to server and expect and error
channel.writeInbound(wrongHttpRequest); channel.writeInbound(wrongHttpRequest);
Assert.fail(); Assertions.failBecauseExceptionWasNotThrown(IllegalArgumentException.class);
});
} catch (Exception ex) { // the HttpMessageHandler does not handle the exception and throws it down the
// pipeline
// the HttpMessageHandler does not handle the exception and throws it down the pipeline assertThat(thrownException).isInstanceOf(IllegalArgumentException.class).hasMessage("Operation not defined");
assertTrue(ex instanceof IllegalArgumentException);
assertTrue(ex.getMessage().equalsIgnoreCase("Operation not defined"));
// the outbound message is a HTTP response with the status code 500 // the outbound message is a HTTP response with the status code 500
FullHttpResponse errorHttpResponse = channel.readOutbound(); FullHttpResponse errorHttpResponse = channel.readOutbound();
String errorHttpResponseContent = errorHttpResponse.content().toString(Charset.defaultCharset()); String errorHttpResponseContent = errorHttpResponse.content().toString(Charset.defaultCharset());
assertTrue("Operation not defined".equalsIgnoreCase(errorHttpResponseContent)); assertThat(errorHttpResponseContent).isEqualToIgnoringCase("Operation not defined");
assertEquals(HttpResponseStatus.INTERNAL_SERVER_ERROR, errorHttpResponse.status()); assertThat(errorHttpResponse.status()).isEqualTo(HttpResponseStatus.INTERNAL_SERVER_ERROR);
}
} }
} }