From 78096d4712cc03256324557606137b0528ad854b Mon Sep 17 00:00:00 2001 From: Javier Date: Fri, 14 Dec 2018 20:21:50 +0100 Subject: [PATCH] BAEL-2412 Change test for min and max values by negative and positive infinity. --- .../gson/primitives/models/InfinityValuesExample.java | 6 ++++++ .../gson/primitives/models/LimitValuesExample.java | 6 ------ .../java/org/baeldung/gson/primitives/UnitTest.java | 11 +++++------ 3 files changed, 11 insertions(+), 12 deletions(-) create mode 100644 gson/src/main/java/org/baeldung/gson/primitives/models/InfinityValuesExample.java delete mode 100644 gson/src/main/java/org/baeldung/gson/primitives/models/LimitValuesExample.java diff --git a/gson/src/main/java/org/baeldung/gson/primitives/models/InfinityValuesExample.java b/gson/src/main/java/org/baeldung/gson/primitives/models/InfinityValuesExample.java new file mode 100644 index 0000000000..163b0a3d95 --- /dev/null +++ b/gson/src/main/java/org/baeldung/gson/primitives/models/InfinityValuesExample.java @@ -0,0 +1,6 @@ +package org.baeldung.gson.primitives.models; + +public class InfinityValuesExample { + public float negativeInfinity; + public float positiveInfinity; +} diff --git a/gson/src/main/java/org/baeldung/gson/primitives/models/LimitValuesExample.java b/gson/src/main/java/org/baeldung/gson/primitives/models/LimitValuesExample.java deleted file mode 100644 index 4960a98834..0000000000 --- a/gson/src/main/java/org/baeldung/gson/primitives/models/LimitValuesExample.java +++ /dev/null @@ -1,6 +0,0 @@ -package org.baeldung.gson.primitives.models; - -public class LimitValuesExample { - public float minValue; - public float maxValue; -} diff --git a/gson/src/test/java/org/baeldung/gson/primitives/UnitTest.java b/gson/src/test/java/org/baeldung/gson/primitives/UnitTest.java index 95314d4d43..d77476517d 100644 --- a/gson/src/test/java/org/baeldung/gson/primitives/UnitTest.java +++ b/gson/src/test/java/org/baeldung/gson/primitives/UnitTest.java @@ -32,15 +32,14 @@ public class UnitTest { assertEquals(expected, gson.toJson(primitiveBundle)); } - @Test public void toJsonLimitValues() { - LimitValuesExample model = new LimitValuesExample(); - model.minValue = Float.MIN_VALUE; - model.maxValue = Float.MAX_VALUE; + @Test(expected = IllegalArgumentException.class) public void toJsonInfinity() { + InfinityValuesExample model = new InfinityValuesExample(); + model.negativeInfinity = Float.NEGATIVE_INFINITY; + model.positiveInfinity = Float.POSITIVE_INFINITY; Gson gson = new Gson(); - String expected = "{\"minValue\":1.4E-45,\"maxValue\":3.4028235E38}"; - assertEquals(expected, gson.toJson(model)); + gson.toJson(model); } @Test(expected = IllegalArgumentException.class) public void toJsonNaN() {