iSharkFly-Docs
/
java-tutorials
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BAEL-4503 PR/article review feedback

This commit is contained in:
amdegregorio 2020-10-17 08:28:31 -04:00
parent 9735c8c093
commit 7d297f344f
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core-java-modules/core-java-lang-3/src/main/java/com/baeldung/constantspatterns/calculations/MathConstants.java
View File

@ -2,9 +2,9 @@ package com.baeldung.constantspatterns.calculations;
public final class MathConstants { public final class MathConstants {
public static final double PI = 3.14159265359; public static final double PI = 3.14159265359;
public static final double GOLDEN_RATIO = 1.6180; static final double GOLDEN_RATIO = 1.6180;
public static final double GRAVITATIONAL_ACCELERATION = 9.8; static final double GRAVITATIONAL_ACCELERATION = 9.8;
public static final double EULERS_NUMBER = 2.7182818284590452353602874713527; static final double EULERS_NUMBER = 2.7182818284590452353602874713527;
public enum Operation { public enum Operation {
ADD, SUBTRACT, DIVIDE, MULTIPLY ADD, SUBTRACT, DIVIDE, MULTIPLY

4
core-java-modules/core-java-lang-3/src/test/java/com/baeldung/constantspatterns/ConstantPatternUnitTest.java
View File

@ -6,7 +6,7 @@ import org.junit.Test;
public class ConstantPatternUnitTest { public class ConstantPatternUnitTest {
@Test @Test
public void givenTwoNumbersAndAdd_whenCallingCalculatorOperatOneTwoNumbers_correctAnswerReturned() { public void givenTwoNumbersAndAdd_whenCallingCalculatorOperatOneTwoNumbers_thenCorrectAnswerReturned() {
Calculator calculator = new Calculator(); Calculator calculator = new Calculator();
double expected = 4; double expected = 4;
double answer = calculator.operateOnTwoNumbers(2, 2, Calculator.Operation.ADD); double answer = calculator.operateOnTwoNumbers(2, 2, Calculator.Operation.ADD);
@ -14,7 +14,7 @@ public class ConstantPatternUnitTest {
} }
@Test @Test
public void givenTwoNumbersAndAdd_whenCallingGeometryCalculatorOperatOneTwoNumbers_correctAnswerReturned() { public void givenTwoNumbersAndAdd_whenCallingGeometryCalculatorOperatOneTwoNumbers_thenCorrectAnswerReturned() {
GeometryCalculator calculator = new GeometryCalculator(); GeometryCalculator calculator = new GeometryCalculator();
double expected = 4; double expected = 4;
double answer = calculator.operateOnTwoNumbers(2, 2, GeometryCalculator.Operation.ADD); double answer = calculator.operateOnTwoNumbers(2, 2, GeometryCalculator.Operation.ADD);