From 854614166fd128600c4b948654a9fea9bdbe4ce2 Mon Sep 17 00:00:00 2001 From: Loredana Crusoveanu Date: Wed, 15 Aug 2018 22:19:02 +0300 Subject: [PATCH] fix exceptions tests --- .../com/baeldung/exceptionhandling/Exceptions.java | 14 ++++++++++++-- .../exceptionhandling/ExceptionsUnitTest.java | 8 +------- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/core-java/src/main/java/com/baeldung/exceptionhandling/Exceptions.java b/core-java/src/main/java/com/baeldung/exceptionhandling/Exceptions.java index 48f4b5c02b..9690648386 100644 --- a/core-java/src/main/java/com/baeldung/exceptionhandling/Exceptions.java +++ b/core-java/src/main/java/com/baeldung/exceptionhandling/Exceptions.java @@ -25,7 +25,11 @@ public class Exceptions { } public List loadAllPlayers(String playersFile) throws IOException{ - throw new IOException(); + try { + throw new IOException(); + } catch(IOException ex) { + throw new IllegalStateException(); + } } public int getPlayerScoreThrows(String playerFile) throws FileNotFoundException { @@ -160,7 +164,13 @@ public class Exceptions { } public void throwAsGotoAntiPattern() throws MyException { - throw new MyException(); + try { + // bunch of code + throw new MyException(); + // second bunch of code + } catch ( MyException e ) { + // third bunch of code + } } public int getPlayerScoreSwallowingExceptionAntiPattern(String playerFile) { diff --git a/core-java/src/test/java/com/baeldung/exceptionhandling/ExceptionsUnitTest.java b/core-java/src/test/java/com/baeldung/exceptionhandling/ExceptionsUnitTest.java index 1e86132116..b3f585cfe4 100644 --- a/core-java/src/test/java/com/baeldung/exceptionhandling/ExceptionsUnitTest.java +++ b/core-java/src/test/java/com/baeldung/exceptionhandling/ExceptionsUnitTest.java @@ -21,7 +21,7 @@ public class ExceptionsUnitTest { @Test public void loadAllPlayers() { assertThatThrownBy(() -> exceptions.loadAllPlayers("")) - .isInstanceOf(IOException.class); + .isInstanceOf(IllegalStateException.class); } @Test @@ -72,12 +72,6 @@ public class ExceptionsUnitTest { .isInstanceOf(NullPointerException.class); } - @Test - public void throwAsGotoAntiPattern() { - assertThatThrownBy(() -> exceptions.throwAsGotoAntiPattern()) - .isInstanceOf(MyException.class); - } - @Test public void getPlayerScoreSwallowingExceptionAntiPatternAlternative2() { assertThatThrownBy(() -> exceptions.getPlayerScoreSwallowingExceptionAntiPatternAlternative2(""))