Merge pull request #3875 from eugenp/BAEL-1599-v2
formatting, dst error
This commit is contained in:
Loredana Crusoveanu
GitHub
commit
8755eb18f7
@ -10,51 +10,60 @@ import java.util.Date;
|
|||||||
import java.util.Locale;
|
import java.util.Locale;
|
||||||
import java.util.TimeZone;
|
import java.util.TimeZone;
|
||||||
|
|
||||||
|
import org.junit.Ignore;
|
||||||
import org.junit.Test;
|
import org.junit.Test;
|
||||||
|
|
||||||
public class DaylightSavingTimeExamplesTest {
|
public class DaylightSavingTimeExamplesTest {
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
public void givenItalianTimeZone_WhenDSTHappens_ThenCorrectlyShiftTimeZone() throws ParseException {
|
public void givenItalianTimeZone_WhenDSTHappens_ThenCorrectlyShiftTimeZone() throws ParseException {
|
||||||
TimeZone tz = TimeZone.getTimeZone("Europe/Rome");
|
TimeZone.setDefault(TimeZone.getTimeZone("Europe/Rome"));
|
||||||
Calendar cal = Calendar.getInstance(tz, Locale.ITALIAN);
|
|
||||||
DateFormat df = new SimpleDateFormat("yyyy-MM-dd HH:mm", Locale.ITALIAN);
|
TimeZone tz = TimeZone.getTimeZone("Europe/Rome");
|
||||||
Date dateBeforeDST = df.parse("2018-03-25 01:55");
|
Calendar cal = Calendar.getInstance(tz, Locale.ITALIAN);
|
||||||
prettyPrint(cal.getTimeZone());
|
DateFormat df = new SimpleDateFormat("yyyy-MM-dd HH:mm", Locale.ITALIAN);
|
||||||
|
Date dateBeforeDST = df.parse("2018-03-25 01:55");
|
||||||
cal.setTime(dateBeforeDST);
|
prettyPrint(cal.getTimeZone());
|
||||||
System.out.println("Before DST (00:55 UTC - 01:55 GMT+1) = " + dateBeforeDST);
|
|
||||||
System.out.println("With this Calendar " + (cal.get(Calendar.ZONE_OFFSET) + cal.get(Calendar.DST_OFFSET)) / (60 * 1000) + " minutes must be added to UTC (GMT TimeZone) to get a correct date for this TimeZone\n");
|
|
||||||
assertThat(cal.get(Calendar.ZONE_OFFSET)).isEqualTo(3600000);
|
|
||||||
assertThat(cal.get(Calendar.DST_OFFSET)).isEqualTo(0);
|
|
||||||
|
|
||||||
cal.add(Calendar.MINUTE, 10);
|
cal.setTime(dateBeforeDST);
|
||||||
|
System.out.println("Before DST (00:55 UTC - 01:55 GMT+1) = " + dateBeforeDST);
|
||||||
Date dateAfterDST = cal.getTime();
|
|
||||||
System.out.println(" After DST (01:05 UTC - 03:05 GMT+2) = " + dateAfterDST);
|
|
||||||
System.out.println("With this Calendar " + (cal.get(Calendar.ZONE_OFFSET) + cal.get(Calendar.DST_OFFSET)) / (60 * 1000) + " minutes must be added to UTC (GMT TimeZone) to get a correct date for this TimeZone\n");
|
|
||||||
assertThat(cal.get(Calendar.DST_OFFSET)).isEqualTo(3600000);
|
|
||||||
assertThat(dateAfterDST).isEqualTo(df.parse("2018-03-25 03:05"));
|
|
||||||
|
|
||||||
Long deltaBetweenDatesInMillis = dateAfterDST.getTime() - dateBeforeDST.getTime();
|
|
||||||
Long tenMinutesInMillis = (1000L * 60 * 10);
|
|
||||||
assertThat(deltaBetweenDatesInMillis).isEqualTo(tenMinutesInMillis);
|
|
||||||
}
|
|
||||||
|
|
||||||
private void prettyPrint(TimeZone tz) {
|
System.out.println("With this Calendar " + (cal.get(Calendar.ZONE_OFFSET) + cal.get(Calendar.DST_OFFSET)) / (60 * 1000) + " minutes must be added to UTC (GMT TimeZone) to get a correct date for this TimeZone\n");
|
||||||
System.out.println(String.format(
|
assertThat(cal.get(Calendar.ZONE_OFFSET)).isEqualTo(3600000);
|
||||||
" Zone ID = %s (%s)\n"
|
assertThat(cal.get(Calendar.DST_OFFSET)).isEqualTo(0);
|
||||||
+ " RawOffset = %s minutes\n"
|
|
||||||
+ " DST = %s minutes\n"
|
cal.add(Calendar.MINUTE, 10);
|
||||||
+ " -----------------------------------------",
|
|
||||||
tz.getID(), tz.getDisplayName(), tz.getRawOffset()/60000, tz.getDSTSavings()/60000));
|
Date dateAfterDST = cal.getTime();
|
||||||
}
|
|
||||||
|
System.out.println(" After DST (01:05 UTC - 03:05 GMT+2) = " + dateAfterDST);
|
||||||
@Test
|
System.out.println("With this Calendar " + (cal.get(Calendar.ZONE_OFFSET) + cal.get(Calendar.DST_OFFSET)) / (60 * 1000) + " minutes must be added to UTC (GMT TimeZone) to get a correct date for this TimeZone\n");
|
||||||
public void whenIterating_ThenPrintAllTimeZones() {
|
assertThat(cal.get(Calendar.DST_OFFSET)).isEqualTo(3600000);
|
||||||
for (String id : TimeZone.getAvailableIDs()) {
|
assertThat(dateAfterDST).isEqualTo(df.parse("2018-03-25 03:05"));
|
||||||
TimeZone tz = TimeZone.getTimeZone(id);
|
|
||||||
prettyPrint(tz);
|
Long deltaBetweenDatesInMillis = dateAfterDST.getTime() - dateBeforeDST.getTime();
|
||||||
}
|
Long tenMinutesInMillis = (1000L * 60 * 10);
|
||||||
}
|
assertThat(deltaBetweenDatesInMillis).isEqualTo(tenMinutesInMillis);
|
||||||
|
}
|
||||||
|
|
||||||
|
private void prettyPrint(TimeZone tz) {
|
||||||
|
|
||||||
|
//@formatter:off
|
||||||
|
System.out.println(String.format(
|
||||||
|
" Zone ID = %s (%s)\n"
|
||||||
|
+ " RawOffset = %s minutes\n"
|
||||||
|
+ " DST = %s minutes\n"
|
||||||
|
+ " -----------------------------------------",
|
||||||
|
tz.getID(), tz.getDisplayName(), tz.getRawOffset()/60000, tz.getDSTSavings()/60000));
|
||||||
|
//@formatter:on
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
@Ignore
|
||||||
|
public void whenIterating_ThenPrintAllTimeZones() {
|
||||||
|
for (String id : TimeZone.getAvailableIDs()) {
|
||||||
|
TimeZone tz = TimeZone.getTimeZone(id);
|
||||||
|
prettyPrint(tz);
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@ -13,40 +13,44 @@ import org.junit.Test;
|
|||||||
|
|
||||||
public class DaylightSavingTimeJavaTimeExamplesTest {
|
public class DaylightSavingTimeJavaTimeExamplesTest {
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
public void givenItalianTimeZone_WhenDSTHappens_ThenCorrectlyShiftTimeZone() throws ParseException {
|
public void givenItalianTimeZone_WhenDSTHappens_ThenCorrectlyShiftTimeZone() throws ParseException {
|
||||||
ZoneId italianZoneId = ZoneId.of("Europe/Rome");
|
ZoneId italianZoneId = ZoneId.of("Europe/Rome");
|
||||||
|
|
||||||
LocalDateTime localDateTimeBeforeDST = LocalDateTime.of(2018, 3, 25, 1, 55);
|
|
||||||
System.out.println(localDateTimeBeforeDST);
|
|
||||||
assertThat(localDateTimeBeforeDST.toString()).isEqualTo("2018-03-25T01:55");
|
|
||||||
|
|
||||||
ZonedDateTime zonedDateTimeBeforeDST = localDateTimeBeforeDST.atZone(italianZoneId);
|
|
||||||
prettyPrint(zonedDateTimeBeforeDST);
|
|
||||||
assertThat(zonedDateTimeBeforeDST.toString()).isEqualTo("2018-03-25T01:55+01:00[Europe/Rome]");
|
|
||||||
|
|
||||||
ZonedDateTime zonedDateTimeAfterDST = zonedDateTimeBeforeDST.plus(10, ChronoUnit.MINUTES);
|
|
||||||
prettyPrint(zonedDateTimeAfterDST);
|
|
||||||
assertThat(zonedDateTimeAfterDST.toString()).isEqualTo("2018-03-25T03:05+02:00[Europe/Rome]");
|
|
||||||
|
|
||||||
Long deltaBetweenDatesInMinutes = ChronoUnit.MINUTES.between(zonedDateTimeBeforeDST,zonedDateTimeAfterDST);
|
|
||||||
assertThat(deltaBetweenDatesInMinutes).isEqualTo(10);
|
|
||||||
|
|
||||||
}
|
|
||||||
|
|
||||||
private void prettyPrint(ZonedDateTime zdt) {
|
LocalDateTime localDateTimeBeforeDST = LocalDateTime.of(2018, 3, 25, 1, 55);
|
||||||
System.out.println(String.format(
|
System.out.println(localDateTimeBeforeDST);
|
||||||
" ZonedDateTime = %s\n"
|
assertThat(localDateTimeBeforeDST.toString()).isEqualTo("2018-03-25T01:55");
|
||||||
+ " Zone ID = %s (%s)\n"
|
|
||||||
+ " RawOffset = %s minutes\n"
|
|
||||||
+ " -----------------------------------------",
|
|
||||||
zdt, zdt.getZone(), zdt.getZone().getId(), zdt.getOffset().getTotalSeconds()/60));
|
|
||||||
}
|
|
||||||
|
|
||||||
@Test
|
|
||||||
public void whenCounting_ThenPrintDifferencesBetweenAPIs() {
|
|
||||||
System.out.println("Total java.time.ZoneId count : " + ZoneId.getAvailableZoneIds().size());
|
|
||||||
System.out.println("Total java.util.TimeZone Id count : " + TimeZone.getAvailableIDs().length);
|
|
||||||
}
|
|
||||||
|
|
||||||
|
ZonedDateTime zonedDateTimeBeforeDST = localDateTimeBeforeDST.atZone(italianZoneId);
|
||||||
|
prettyPrint(zonedDateTimeBeforeDST);
|
||||||
|
assertThat(zonedDateTimeBeforeDST.toString()).isEqualTo("2018-03-25T01:55+01:00[Europe/Rome]");
|
||||||
|
|
||||||
|
ZonedDateTime zonedDateTimeAfterDST = zonedDateTimeBeforeDST.plus(10, ChronoUnit.MINUTES);
|
||||||
|
prettyPrint(zonedDateTimeAfterDST);
|
||||||
|
assertThat(zonedDateTimeAfterDST.toString()).isEqualTo("2018-03-25T03:05+02:00[Europe/Rome]");
|
||||||
|
|
||||||
|
Long deltaBetweenDatesInMinutes = ChronoUnit.MINUTES.between(zonedDateTimeBeforeDST, zonedDateTimeAfterDST);
|
||||||
|
assertThat(deltaBetweenDatesInMinutes).isEqualTo(10);
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
private void prettyPrint(ZonedDateTime zdt) {
|
||||||
|
//@formatter:off
|
||||||
|
System.out.println(String.format(
|
||||||
|
" ZonedDateTime = %s\n"
|
||||||
|
+ " Zone ID = %s (%s)\n"
|
||||||
|
+ " RawOffset = %s minutes\n"
|
||||||
|
+ " -----------------------------------------",
|
||||||
|
zdt, zdt.getZone(), zdt.getZone().getId(), zdt.getOffset().getTotalSeconds()/60));
|
||||||
|
//@formatter:on
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void whenCounting_ThenPrintDifferencesBetweenAPIs() {
|
||||||
|
System.out.println("Total java.time.ZoneId count : " + ZoneId.getAvailableZoneIds()
|
||||||
|
.size());
|
||||||
|
System.out.println("Total java.util.TimeZone Id count : " + TimeZone.getAvailableIDs().length);
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user