JAVA-10134: Cleanup POM properties (#12272)

* JAVA-10134: Cleanup POM properties

* JAVA-10134: Fix POM properties

* JAVA-10134: Fix hamcrest dependency in libraries-apache-commons-collections

* JAVA-10134: Fix java-hamcrest dependency

* JAVA-10134: Add maven.compiler properties

libraries-apache-commons-collections/pom.xml

@@ -20,14 +20,11 @@
         </dependency>
         <dependency>
             <groupId>org.hamcrest</groupId>
-            <artifactId>java-hamcrest</artifactId>
+            <artifactId>hamcrest</artifactId>
-            <version>${org.hamcrest.java-hamcrest.version}</version>
+            <version>${hamcrest.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>
 
-    <properties>
-        <org.hamcrest.java-hamcrest.version>2.0.0.0</org.hamcrest.java-hamcrest.version>
-    </properties>
 
 </project>

libraries-data-io/pom.xml

@@ -107,7 +107,6 @@
         <docx4j.version>3.3.5</docx4j.version>
         <jaxb-api.version>2.1</jaxb-api.version>
         <gson.version>2.8.7</gson.version>
-        <jackson.version>2.12.3</jackson.version>
         <yamlbeans.version>1.15</yamlbeans.version>
         <apache-thrift.version>0.14.2</apache-thrift.version>
         <google-protobuf.version>3.17.3</google-protobuf.version>

libraries-primitive/pom.xml

@@ -69,12 +69,6 @@
     <properties>
         <fastutil.version>8.2.2</fastutil.version>
         <eclipse-collections.version>10.0.0</eclipse-collections.version>
-        <maven.compiler.source>1.8</maven.compiler.source>
-        <maven.compiler.target>1.8</maven.compiler.target>
-        <jmh-core.version>1.28</jmh-core.version>
-        <jmh-generator.version>1.28</jmh-generator.version>
-        <junit-jupiter.version>5.8.1</junit-jupiter.version>
-        <maven-surefire-plugin.version>2.22.2</maven-surefire-plugin.version>
     </properties>
 
 </project>

libraries-testing/pom.xml

@@ -171,15 +171,6 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-compiler-plugin</artifactId>
-                <version>${maven-compiler-plugin.version}</version>
-                <configuration>
-                    <source>${maven-compiler-plugin.source}</source>
-                    <target>${maven-compiler-plugin.target}</target>
-                </configuration>
-            </plugin>
         </plugins>
     </build>
 
@@ -196,10 +187,6 @@
         <spring-mock-mvc.version>4.1.1</spring-mock-mvc.version>
         <java-hamcrest.version>2.0.0.0</java-hamcrest.version>
         <dbunit.version>2.7.0</dbunit.version>
-        <assertj-core.version>3.14.0</assertj-core.version>
-        <maven-compiler-plugin.target>1.8</maven-compiler-plugin.target>
-        <maven-compiler-plugin.source>1.8</maven-compiler-plugin.source>
-        <maven-compiler-plugin.version>3.8.1</maven-compiler-plugin.version>
         <archunit.version>0.14.1</archunit.version>
         <modelassert.version>1.0.0</modelassert.version>
     </properties>

metrics/pom.xml

@@ -78,7 +78,7 @@
         <dependency>
             <groupId>com.netflix.spectator</groupId>
             <artifactId>spectator-api</artifactId>
-            <version>1.0.11</version>
+            <version>${spectator-api.version}</version>
         </dependency>
     </dependencies>
 
@@ -90,6 +90,7 @@
         <!-- <fasterxml.jackson.version>2.9.1</fasterxml.jackson.version> -->
         <spring-boot-starter-web.version>2.0.7.RELEASE</spring-boot-starter-web.version>
         <metrics-aspectj.version>1.1.0</metrics-aspectj.version>
+        <spectator-api.version>1.0.11</spectator-api.version>
     </properties>
 
 </project>

netflix-modules/mantis/pom.xml

@@ -23,7 +23,7 @@
         <dependency>
             <groupId>io.mantisrx</groupId>
             <artifactId>mantis-runtime</artifactId>
-            <version>1.2.63</version>
+            <version>${mantis-runtime.version}</version>
             <exclusions>
                 <exclusion>
                     <groupId>org.slf4j</groupId>
@@ -38,7 +38,7 @@
         <dependency>
             <groupId>net.andreinc.mockneat</groupId>
             <artifactId>mockneat</artifactId>
-            <version>0.4.2</version>
+            <version>${mockneat.version}</version>
         </dependency>
         <dependency>
             <groupId>org.projectlombok</groupId>
@@ -63,4 +63,9 @@
         </repository>
     </repositories>
 
+    <properties>
+        <mantis-runtime.version>1.2.63</mantis-runtime.version>
+        <mockneat.version>0.4.2</mockneat.version>
+    </properties>
+
 </project>

patterns/cqrs-es/pom.xml

@@ -25,10 +25,4 @@
         </dependency>
     </dependencies>
 
-    <properties>
-        <maven.compiler.source>1.8</maven.compiler.source>
-        <maven.compiler.target>1.8</maven.compiler.target>
-        <lombok.version>1.18.12</lombok.version>
-    </properties>
-
 </project>