iSharkFly-Docs
/
java-tutorials
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[BAEL-3981] Fixes from Josh's review 

* Upgraded Apache Commons to 3.10

* Replaced Nathalie by Natalie
This commit is contained in:
dupirefr 2020-05-20 23:33:04 +02:00
parent 24a88c11ac
commit a990d57407
4 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core-java-modules/core-java-lang-2/pom.xml
View File

@ -70,7 +70,7 @@
<jmh-generator.version>1.19</jmh-generator.version>
<assertj.version>3.12.2</assertj.version>
<commons.beanutils.version>1.9.4</commons.beanutils.version>
<commons-lang3.version>3.9</commons-lang3.version>
<commons-lang3.version>3.10</commons-lang3.version>
<guava.version>29.0-jre</guava.version>
</properties>

4
core-java-modules/core-java-lang-2/src/test/java/com/baeldung/comparing/EqualsMethodUnitTest.java
View File

@ -66,8 +66,8 @@ class EqualsMethodUnitTest {
@Test
void givenTwoPersonWittEqualsWithDifferentNames_whenEquals_thenFalse() {
PersonWithEquals joe = new PersonWithEquals("Joe", "Portman");
PersonWithEquals nathalie = new PersonWithEquals("Nathalie", "Portman");
PersonWithEquals natalie = new PersonWithEquals("Natalie", "Portman");
assertThat(joe.equals(nathalie)).isFalse();
assertThat(joe.equals(natalie)).isFalse();
}
}

8
core-java-modules/core-java-lang-2/src/test/java/com/baeldung/comparing/GuavaUnitTest.java
View File

@ -58,13 +58,13 @@ class GuavaUnitTest {
@Nested
class ComparisonChainClass {
@Test
void givenTwoPersonWithEquals_whenComparisonChainByLastNameThenFirstName_thenSortedJoeFirstAndNathalieSecond() {
PersonWithEquals nathalie = new PersonWithEquals("Nathalie", "Portman");
void givenTwoPersonWithEquals_whenComparisonChainByLastNameThenFirstName_thenSortedJoeFirstAndNatalieSecond() {
PersonWithEquals natalie = new PersonWithEquals("Natalie", "Portman");
PersonWithEquals joe = new PersonWithEquals("Joe", "Portman");
int comparisonResult = ComparisonChain.start()
.compare(nathalie.lastName(), joe.lastName())
.compare(nathalie.firstName(), joe.firstName())
.compare(natalie.lastName(), joe.lastName())
.compare(natalie.firstName(), joe.firstName())
.result();
assertThat(comparisonResult).isPositive();

4
core-java-modules/core-java-lang-2/src/test/java/com/baeldung/comparing/ObjectsEqualsStaticMethodUnitTest.java
View File

@ -19,9 +19,9 @@ class ObjectsEqualsStaticMethodUnitTest {
@Test
void givenTwoPersonWithEqualsWithDifferentNames_whenObjectsEquals_thenFalse() {
PersonWithEquals joe = new PersonWithEquals("Joe", "Portman");
PersonWithEquals nathalie = new PersonWithEquals("Nathalie", "Portman");
PersonWithEquals natalie = new PersonWithEquals("Natalie", "Portman");
assertThat(Objects.equals(joe, nathalie)).isFalse();
assertThat(Objects.equals(joe, natalie)).isFalse();
}
@Test