new httpclient timeout examples - old api and new api

httpclient/pom.xml

@@ -1,5 +1,4 @@
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
-	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
     <groupId>org.baeldung</groupId>
     <artifactId>httpclient</artifactId>
@@ -30,6 +29,11 @@
             <artifactId>httpclient</artifactId>
             <version>${httpclient.version}</version>
         </dependency>
+        <dependency>
+            <groupId>org.apache.httpcomponents</groupId>
+            <artifactId>httpcore</artifactId>
+            <version>${httpcore.version}</version>
+        </dependency>
 
         <!-- logging -->
 
@@ -143,7 +147,7 @@
         <junit.version>4.11</junit.version>
         <mockito.version>1.9.5</mockito.version>
 
-		<httpcore.version>4.3</httpcore.version>
+        <httpcore.version>4.3.1</httpcore.version>
         <httpclient.version>4.3.1</httpclient.version>
 
         <rest-assured.version>2.1.0</rest-assured.version>

httpclient/src/test/java/org/baeldung/httpclient/HttpClientTimeoutLiveTest.java

@@ -0,0 +1,95 @@
+package org.baeldung.httpclient;
+
+import static org.hamcrest.Matchers.equalTo;
+import static org.junit.Assert.assertThat;
+
+import java.io.IOException;
+import java.io.InputStream;
+
+import org.apache.http.HttpEntity;
+import org.apache.http.client.ClientProtocolException;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpGet;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.DefaultHttpClient;
+import org.apache.http.impl.client.HttpClientBuilder;
+import org.apache.http.params.CoreConnectionPNames;
+import org.apache.http.params.HttpConnectionParams;
+import org.apache.http.params.HttpParams;
+import org.junit.After;
+import org.junit.Test;
+
+public class HttpClientTimeoutLiveTest {
+
+    private CloseableHttpResponse response;
+
+    @After
+    public final void after() throws IllegalStateException, IOException {
+        if (response == null) {
+            return;
+        }
+
+        try {
+            final HttpEntity entity = response.getEntity();
+            if (entity != null) {
+                final InputStream instream = entity.getContent();
+                instream.close();
+            }
+        } finally {
+            response.close();
+        }
+    }
+
+    // tests
+
+    @SuppressWarnings("deprecation")
+    @Test
+    public final void givenUsingDeprecatedApi_whenSettingTimeoutViaRawParams_thenCorrect() throws ClientProtocolException, IOException {
+        final int timeout = 2;
+        final DefaultHttpClient client = new DefaultHttpClient();
+        final HttpGet request = new HttpGet("http://www.github.com");
+
+        final HttpParams httpParams = client.getParams();
+        httpParams.setParameter(CoreConnectionPNames.CONNECTION_TIMEOUT, timeout * 1000);
+        httpParams.setParameter(CoreConnectionPNames.SO_TIMEOUT, timeout * 1000);
+        // httpParams.setLongParameter(ClientPNames.CONN_MANAGER_TIMEOUT, new Long(timeout * 1000)); // https://issues.apache.org/jira/browse/HTTPCLIENT-1418
+
+        response = client.execute(request);
+
+        assertThat(response.getStatusLine().getStatusCode(), equalTo(200));
+        client.close();
+    }
+
+    @SuppressWarnings("deprecation")
+    @Test
+    public final void givenUsingDeprecatedApi_whenSettingTimeoutViaHigherLevelApi_thenCorrect() throws ClientProtocolException, IOException {
+        final int timeout = 2;
+        final DefaultHttpClient client = new DefaultHttpClient();
+        final HttpGet request = new HttpGet("http://www.github.com");
+
+        final HttpParams httpParams = client.getParams();
+        HttpConnectionParams.setConnectionTimeout(httpParams, timeout * 1000); // http.connection.timeout
+        HttpConnectionParams.setSoTimeout(httpParams, timeout * 1000); // http.socket.timeout
+
+        response = client.execute(request);
+
+        assertThat(response.getStatusLine().getStatusCode(), equalTo(200));
+        client.close();
+    }
+
+    @Test
+    public final void givenUsingNewApi_whenSettingTimeoutViaHighLevelApi_thenCorrect() throws ClientProtocolException, IOException {
+        final int timeout = 5;
+
+        final RequestConfig.Builder requestBuilder = RequestConfig.custom().setConnectTimeout(timeout * 1000).setConnectionRequestTimeout(timeout * 1000);
+        final CloseableHttpClient client = HttpClientBuilder.create().setDefaultRequestConfig(requestBuilder.build()).build();
+
+        final HttpGet request = new HttpGet("http://www.github.com");
+
+        response = client.execute(request);
+
+        assertThat(response.getStatusLine().getStatusCode(), equalTo(200));
+    }
+
+}

spring-security-rest-basic-auth/pom.xml

@@ -294,7 +294,7 @@
         <mysql-connector-java.version>5.1.27</mysql-connector-java.version>
 
         <!-- http -->
-        <httpcore.version>4.3</httpcore.version>
+        <httpcore.version>4.3.1</httpcore.version>
         <httpclient.version>4.3.1</httpclient.version>
 
         <!-- logging -->

spring-security-rest-basic-auth/src/main/java/org/baeldung/client/RestTemplateFactory.java

@@ -2,6 +2,8 @@ package org.baeldung.client;
 
 import org.apache.http.HttpHost;
 import org.apache.http.client.HttpClient;
+import org.apache.http.client.params.ClientPNames;
+import org.apache.http.params.CoreConnectionPNames;
 import org.apache.http.params.HttpConnectionParams;
 import org.apache.http.params.HttpParams;
 import org.springframework.beans.factory.FactoryBean;
@@ -51,6 +53,10 @@ public class RestTemplateFactory implements FactoryBean<RestTemplate>, Initializ
 
         // - note: timeout via the API
         final HttpParams httpParams = httpClient.getParams();
+        httpParams.setParameter(CoreConnectionPNames.CONNECTION_TIMEOUT, timeout * 1000);
+        httpParams.setParameter(CoreConnectionPNames.SO_TIMEOUT, timeout * 1000);
+        httpParams.setParameter(ClientPNames.CONN_MANAGER_TIMEOUT, new Long(timeout * 1000));
+
         HttpConnectionParams.setConnectionTimeout(httpParams, timeout * 1000); // http.connection.timeout
         HttpConnectionParams.setSoTimeout(httpParams, timeout * 1000); // http.socket.timeout
     }