From bf1aaf197f9733cfa0e5ccd0c0ada50a8d8b52b4 Mon Sep 17 00:00:00 2001
From: panos-kakos <102670093+panos-kakos@users.noreply.github.com>
Date: Fri, 8 Dec 2023 09:51:11 +0200
Subject: [PATCH] [JAVA-28504] Clean up

---
 spring-websockets/pom.xml                       |  6 +++++-
 static-analysis/error-prone-project/pom.xml     | 11 ++++-------
 static-analysis/my-bugchecker-plugin/pom.xml    | 11 +++--------
 static-analysis/pmd/pom.xml                     | 10 ++--------
 tablesaw/pom.xml                                |  5 -----
 testing-modules/cucumber/pom.xml                |  2 --
 testing-modules/gatling-java/pom.xml            |  3 ---
 testing-modules/gatling/pom.xml                 |  3 ---
 testing-modules/jqwik/pom.xml                   |  6 +++++-
 testing-modules/junit-5-advanced/pom.xml        |  3 ++-
 testing-modules/junit-5-basics-2/pom.xml        |  7 -------
 testing-modules/junit-5/pom.xml                 |  1 -
 testing-modules/load-testing-comparison/pom.xml |  3 ---
 testing-modules/mockito-2/pom.xml               |  3 ---
 vavr-modules/java-vavr-stream/pom.xml           |  6 +-----
 vavr-modules/pom.xml                            |  4 ++++
 vavr-modules/vavr-2/pom.xml                     |  4 ----
 vertx-modules/pom.xml                           |  4 ++++
 vertx-modules/vertx-and-rxjava/pom.xml          |  4 ----
 vertx-modules/vertx/pom.xml                     |  1 -
 web-modules/apache-tapestry/pom.xml             |  8 --------
 web-modules/blade/pom.xml                       |  1 -
 web-modules/jakarta-ee/pom.xml                  |  9 ++-------
 23 files changed, 32 insertions(+), 83 deletions(-)

diff --git a/spring-websockets/pom.xml b/spring-websockets/pom.xml
index a28ef8749a..6ca84c4946 100644
--- a/spring-websockets/pom.xml
+++ b/spring-websockets/pom.xml
@@ -26,7 +26,7 @@
         <dependency>
             <groupId>com.github.javafaker</groupId>
             <artifactId>javafaker</artifactId>
-            <version>1.0.2</version>
+            <version>${javafaker.version}</version>
         </dependency>
         <dependency>
             <groupId>com.google.code.gson</groupId>
@@ -44,4 +44,8 @@
         </resources>
     </build>
 
+    <properties>
+        <javafaker.version>1.0.2</javafaker.version>
+    </properties>
+
 </project>
\ No newline at end of file
diff --git a/static-analysis/error-prone-project/pom.xml b/static-analysis/error-prone-project/pom.xml
index 59f7bb7270..2d5706d0d2 100644
--- a/static-analysis/error-prone-project/pom.xml
+++ b/static-analysis/error-prone-project/pom.xml
@@ -3,14 +3,14 @@
          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
+    <artifactId>error-prone-project</artifactId>
+
     <parent>
         <groupId>com.baeldung</groupId>
         <artifactId>static-analysis</artifactId>
         <version>1.0-SNAPSHOT</version>
     </parent>
 
-    <artifactId>error-prone-project</artifactId>
-
     <build>
         <plugins>
             <plugin>
@@ -19,7 +19,6 @@
                 <version>${maven-compiler-plugin.version}</version>
                 <configuration>
                     <release>17</release>
-                    <encoding>UTF-8</encoding>
                     <fork>true</fork>
                     <compilerArgs>
                         <arg>-XDcompilePolicy=simple</arg>
@@ -44,7 +43,7 @@
                         <path>
                             <groupId>com.baeldung</groupId>
                             <artifactId>my-bugchecker-plugin</artifactId>
-                            <version>1.0-SNAPSHOT</version>
+                            <version>${my-bugchecker-plugin.version}</version>
                         </path>
                     </annotationProcessorPaths>
                 </configuration>
@@ -53,9 +52,7 @@
     </build>
 
     <properties>
-        <maven.compiler.source>17</maven.compiler.source>
-        <maven.compiler.target>17</maven.compiler.target>
-        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <my-bugchecker-plugin.version>1.0-SNAPSHOT</my-bugchecker-plugin.version>
     </properties>
 
 </project>
diff --git a/static-analysis/my-bugchecker-plugin/pom.xml b/static-analysis/my-bugchecker-plugin/pom.xml
index cbe16b0a14..eb11f07b4e 100644
--- a/static-analysis/my-bugchecker-plugin/pom.xml
+++ b/static-analysis/my-bugchecker-plugin/pom.xml
@@ -3,13 +3,14 @@
          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
+    <artifactId>my-bugchecker-plugin</artifactId>
+    <packaging>jar</packaging>
+
     <parent>
         <groupId>com.baeldung</groupId>
         <artifactId>static-analysis</artifactId>
         <version>1.0-SNAPSHOT</version>
     </parent>
-    <packaging>jar</packaging>
-    <artifactId>my-bugchecker-plugin</artifactId>
 
     <build>
         <plugins>
@@ -47,10 +48,4 @@
         </dependency>
     </dependencies>
 
-    <properties>
-        <maven.compiler.source>17</maven.compiler.source>
-        <maven.compiler.target>17</maven.compiler.target>
-        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-    </properties>
-
 </project>
diff --git a/static-analysis/pmd/pom.xml b/static-analysis/pmd/pom.xml
index 31914fe9f0..372c122776 100644
--- a/static-analysis/pmd/pom.xml
+++ b/static-analysis/pmd/pom.xml
@@ -3,18 +3,12 @@
          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
+    <artifactId>pmd</artifactId>
+
     <parent>
         <groupId>com.baeldung</groupId>
         <artifactId>static-analysis</artifactId>
         <version>1.0-SNAPSHOT</version>
     </parent>
 
-    <artifactId>pmd</artifactId>
-
-    <properties>
-        <maven.compiler.source>17</maven.compiler.source>
-        <maven.compiler.target>17</maven.compiler.target>
-        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-    </properties>
-
 </project>
diff --git a/tablesaw/pom.xml b/tablesaw/pom.xml
index f38e4cb8b4..c45931a9e2 100644
--- a/tablesaw/pom.xml
+++ b/tablesaw/pom.xml
@@ -25,11 +25,6 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
-                <version>3.8.0</version>
-                <configuration>
-                    <source>17</source>
-                    <target>17</target>
-                </configuration>
             </plugin>
         </plugins>
     </build>
diff --git a/testing-modules/cucumber/pom.xml b/testing-modules/cucumber/pom.xml
index c1d99bb492..088a75a941 100644
--- a/testing-modules/cucumber/pom.xml
+++ b/testing-modules/cucumber/pom.xml
@@ -121,8 +121,6 @@
     </profiles>
 
     <properties>
-        <maven.compiler.source>14</maven.compiler.source>
-        <maven.compiler.target>14</maven.compiler.target>
         <cucumber.version>6.10.3</cucumber.version>
         <cucumber-reporting.version>5.4.0</cucumber-reporting.version>
         <selenium.version>3.141.59</selenium.version>
diff --git a/testing-modules/gatling-java/pom.xml b/testing-modules/gatling-java/pom.xml
index abe033f298..54dee1fd88 100644
--- a/testing-modules/gatling-java/pom.xml
+++ b/testing-modules/gatling-java/pom.xml
@@ -72,9 +72,6 @@
     </build>
 
     <properties>
-        <maven.compiler.source>1.8</maven.compiler.source>
-        <maven.compiler.target>1.8</maven.compiler.target>
-        <encoding>UTF-8</encoding>
         <gatling.version>3.9.5</gatling.version>
         <gatling-maven-plugin.version>4.3.0</gatling-maven-plugin.version>
         <faker.version>1.0.2</faker.version>
diff --git a/testing-modules/gatling/pom.xml b/testing-modules/gatling/pom.xml
index 82ce988bac..e5b1db2bfb 100644
--- a/testing-modules/gatling/pom.xml
+++ b/testing-modules/gatling/pom.xml
@@ -105,9 +105,6 @@
     </build>
 
     <properties>
-        <maven.compiler.source>1.8</maven.compiler.source>
-        <maven.compiler.target>1.8</maven.compiler.target>
-        <encoding>UTF-8</encoding>
         <scala.version>2.12.6</scala.version>
         <gatling.version>3.3.1</gatling.version>
         <scala-maven-plugin.version>4.3.0</scala-maven-plugin.version>
diff --git a/testing-modules/jqwik/pom.xml b/testing-modules/jqwik/pom.xml
index 6ef9b61a6a..85c4ba571a 100644
--- a/testing-modules/jqwik/pom.xml
+++ b/testing-modules/jqwik/pom.xml
@@ -17,7 +17,7 @@
         <dependency>
             <groupId>net.jqwik</groupId>
             <artifactId>jqwik</artifactId>
-            <version>1.7.4</version>
+            <version>${jqwik.version}</version>
             <scope>test</scope>
         </dependency>
         <dependency>
@@ -53,5 +53,9 @@
         </resources>
     </build>
 
+    <properties>
+        <jqwik.version>1.7.4</jqwik.version>
+    </properties>
+
 </project>
 
diff --git a/testing-modules/junit-5-advanced/pom.xml b/testing-modules/junit-5-advanced/pom.xml
index 411f189638..fc0349ff8e 100644
--- a/testing-modules/junit-5-advanced/pom.xml
+++ b/testing-modules/junit-5-advanced/pom.xml
@@ -18,7 +18,7 @@
         <dependency>
             <groupId>com.github.stefanbirkner</groupId>
             <artifactId>system-lambda</artifactId>
-            <version>1.2.1</version>
+            <version>${system-lambda.version}</version>
             <scope>test</scope>
         </dependency>
         <dependency>
@@ -79,6 +79,7 @@
     </build>
 
     <properties>
+        <system-lambda.version>1.2.1</system-lambda.version>
         <jmockit.version>1.49</jmockit.version>
         <assertj.version>3.24.2</assertj.version>
         <junit-platform.version>1.10.1</junit-platform.version>
diff --git a/testing-modules/junit-5-basics-2/pom.xml b/testing-modules/junit-5-basics-2/pom.xml
index b430161380..f03b74f47a 100644
--- a/testing-modules/junit-5-basics-2/pom.xml
+++ b/testing-modules/junit-5-basics-2/pom.xml
@@ -36,18 +36,11 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
-                <configuration>
-                    <source>11</source>
-                    <target>11</target>
-                </configuration>
             </plugin>
         </plugins>
     </build>
 
     <properties>
-        <maven.compiler.source>11</maven.compiler.source>
-        <maven.compiler.target>11</maven.compiler.target>
-        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <commons-cli.version>1.5.0</commons-cli.version>
         <junit-jupiter-api.version>5.10.0</junit-jupiter-api.version>
         <mockito-core.version>5.5.0</mockito-core.version>
diff --git a/testing-modules/junit-5/pom.xml b/testing-modules/junit-5/pom.xml
index 8afaa085b1..cdddf90855 100644
--- a/testing-modules/junit-5/pom.xml
+++ b/testing-modules/junit-5/pom.xml
@@ -107,7 +107,6 @@
             <plugin>
                 <groupId>org.codehaus.mojo</groupId>
                 <artifactId>exec-maven-plugin</artifactId>
-                <version>${exec-maven-plugin.version}</version>
                 <executions>
                     <execution>
                         <goals>
diff --git a/testing-modules/load-testing-comparison/pom.xml b/testing-modules/load-testing-comparison/pom.xml
index d5a389d311..af42523ca9 100644
--- a/testing-modules/load-testing-comparison/pom.xml
+++ b/testing-modules/load-testing-comparison/pom.xml
@@ -66,9 +66,6 @@
     </build>
 
     <properties>
-        <maven.compiler.source>1.8</maven.compiler.source>
-        <maven.compiler.target>1.8</maven.compiler.target>
-        <encoding>UTF-8</encoding>
         <scala.version>2.12.12</scala.version>
         <gatling.version>3.4.0</gatling.version>
         <scala-maven-plugin.version>4.4.0</scala-maven-plugin.version>
diff --git a/testing-modules/mockito-2/pom.xml b/testing-modules/mockito-2/pom.xml
index 0e0f19b6b3..100c9d7015 100644
--- a/testing-modules/mockito-2/pom.xml
+++ b/testing-modules/mockito-2/pom.xml
@@ -21,9 +21,6 @@
     </dependencies>
 
     <properties>
-        <maven.compiler.source>8</maven.compiler.source>
-        <maven.compiler.target>8</maven.compiler.target>
-        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <mockito-inline.version>4.8.1</mockito-inline.version>
     </properties>
 
diff --git a/vavr-modules/java-vavr-stream/pom.xml b/vavr-modules/java-vavr-stream/pom.xml
index cda9d1f734..e369fa7cf3 100644
--- a/vavr-modules/java-vavr-stream/pom.xml
+++ b/vavr-modules/java-vavr-stream/pom.xml
@@ -19,12 +19,8 @@
         <dependency>
             <groupId>io.vavr</groupId>
             <artifactId>vavr</artifactId>
-            <version>${io.vavr.version}</version>
+            <version>${vavr.version}</version>
         </dependency>
     </dependencies>
 
-    <properties>
-        <io.vavr.version>0.9.2</io.vavr.version>
-    </properties>
-
 </project>
\ No newline at end of file
diff --git a/vavr-modules/pom.xml b/vavr-modules/pom.xml
index 416c689511..e9a3b121aa 100644
--- a/vavr-modules/pom.xml
+++ b/vavr-modules/pom.xml
@@ -30,4 +30,8 @@
         </pluginManagement>
     </build>
 
+    <properties>
+        <vavr.version>0.9.2</vavr.version>
+    </properties>
+
 </project>
\ No newline at end of file
diff --git a/vavr-modules/vavr-2/pom.xml b/vavr-modules/vavr-2/pom.xml
index 0063daa518..54f3cb4d71 100644
--- a/vavr-modules/vavr-2/pom.xml
+++ b/vavr-modules/vavr-2/pom.xml
@@ -21,8 +21,4 @@
         </dependency>
     </dependencies>
 
-    <properties>
-        <vavr.version>0.9.1</vavr.version>
-    </properties>
-
 </project>
\ No newline at end of file
diff --git a/vertx-modules/pom.xml b/vertx-modules/pom.xml
index 7d9614ad61..00f0bc46f5 100644
--- a/vertx-modules/pom.xml
+++ b/vertx-modules/pom.xml
@@ -30,4 +30,8 @@
         </pluginManagement>
     </build>
 
+    <properties>
+        <vertx.version>3.9.15</vertx.version>
+    </properties>
+
 </project>
\ No newline at end of file
diff --git a/vertx-modules/vertx-and-rxjava/pom.xml b/vertx-modules/vertx-and-rxjava/pom.xml
index 16eaf8ebaa..b68117ddeb 100644
--- a/vertx-modules/vertx-and-rxjava/pom.xml
+++ b/vertx-modules/vertx-and-rxjava/pom.xml
@@ -40,8 +40,4 @@
         </plugins>
     </build>
 
-    <properties>
-        <vertx.version>3.9.15</vertx.version>
-    </properties>
-
 </project>
\ No newline at end of file
diff --git a/vertx-modules/vertx/pom.xml b/vertx-modules/vertx/pom.xml
index 75df2fae69..d34deca9d8 100644
--- a/vertx-modules/vertx/pom.xml
+++ b/vertx-modules/vertx/pom.xml
@@ -65,7 +65,6 @@
     </build>
 
     <properties>
-        <vertx.version>3.9.15</vertx.version>
         <maven-shade-plugin.version>3.2.1</maven-shade-plugin.version>
     </properties>
 
diff --git a/web-modules/apache-tapestry/pom.xml b/web-modules/apache-tapestry/pom.xml
index 562cdff00c..bfc7c22415 100644
--- a/web-modules/apache-tapestry/pom.xml
+++ b/web-modules/apache-tapestry/pom.xml
@@ -78,17 +78,13 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
-                <version>${compiler.plugin.version}</version>
                 <configuration>
-                    <source>${source.version}</source>
-                    <target>${target.version}</target>
                     <optimize>true</optimize>
                 </configuration>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-surefire-plugin</artifactId>
-                <version>${compiler.surefire.version}</version>
                 <configuration>
                     <systemPropertyVariables>
                         <tapestry.execution-mode>Qa</tapestry.execution-mode>
@@ -118,7 +114,6 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-war-plugin</artifactId>
-                <version>3.3.1</version>
                 <configuration>
                     <archive>
                         <manifest>
@@ -140,9 +135,6 @@
     <properties>
         <compiler.jetty.version>6.1.16</compiler.jetty.version>
         <compiler.surefire.version>3.0.0-M5</compiler.surefire.version>
-        <compiler.plugin.version>3.8.1</compiler.plugin.version>
-        <source.version>11</source.version>
-        <target.version>11</target.version>
         <tapestry.version>5.8.2</tapestry.version>
         <servlet-api-release-version>2.5</servlet-api-release-version>
         <testng-release-version>6.8.21</testng-release-version>
diff --git a/web-modules/blade/pom.xml b/web-modules/blade/pom.xml
index 2748c05663..fb0ca13dbe 100644
--- a/web-modules/blade/pom.xml
+++ b/web-modules/blade/pom.xml
@@ -62,7 +62,6 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-failsafe-plugin</artifactId>
-                <version>${maven-failsafe-plugin.version}</version>
                 <configuration>
                     <skipITs>true</skipITs>
                     <includes>
diff --git a/web-modules/jakarta-ee/pom.xml b/web-modules/jakarta-ee/pom.xml
index 066bc14766..d90e848323 100644
--- a/web-modules/jakarta-ee/pom.xml
+++ b/web-modules/jakarta-ee/pom.xml
@@ -2,7 +2,6 @@
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
-    <groupId>com.baeldung</groupId>
     <artifactId>jakarta-ee</artifactId>
     <version>1.0-SNAPSHOT</version>
     <name>jakarta-ee</name>
@@ -51,7 +50,7 @@
             <plugin>
                 <groupId>org.glassfish.maven.plugin</groupId>
                 <artifactId>maven-glassfish-plugin</artifactId>
-                <version>2.1</version>
+                <version>${maven-glassfish-plugin.version}</version>
                 <configuration>
                     <glassfishDirectory>${local.glassfish.home}</glassfishDirectory>
                     <user>admin</user>
@@ -76,11 +75,6 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
-                <version>3.8.0</version>
-                <configuration>
-                    <source>11</source>
-                    <target>11</target>
-                </configuration>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
@@ -104,6 +98,7 @@
         <local.glassfish.passfile>
             ${local.glassfish.home}\\domains\\${local.glassfish.domain}\\config\\domain-passwords
         </local.glassfish.passfile>
+        <maven-glassfish-plugin.version>2.1</maven-glassfish-plugin.version>
     </properties>
 
 </project>
\ No newline at end of file