From c0a730a3ac5fcd51d1ce732e633bae1f3cb89a18 Mon Sep 17 00:00:00 2001
From: ocheja <ocheja.patrick@gmail.com>
Date: Thu, 7 Dec 2017 18:24:49 +0900
Subject: [PATCH]  Replace string concatenations with String.format (#3201)

* Define beans for handling different message types in a lean chat app

* Add class based spring beans configuration

* Define spring configuration in XML for constructor based bean injection

* Refactor package structure to separate constructor based bean injection code set from setter based bean injection code set

* Define configuration and classes specific to setter-based bean injection.

* Implement tests for constructor-based and setter-based bean injections

* develop codes for explaining type erasure

* Write unit tests for type erasure examples

* Remove evaluation article code

* Modify type erasure examples and unit tests

* Modify type erasure examples and unit tests

* Add expected exception in TypeErasureUnitTest

* Correct grammar in class name

* Implement File Manager app to demonstrate Polymorphism. Develop unit tests for Polymorphism article code

* Add examples for static polymorphism

* Change sysout statments to slf4j log info statements

* Add assertions and expected errors check on Test

* Add assertions and expected errors check on Test

* Correct compile time error of symbol not found

* Removed commented out non-compiling test.

* Replace string concatenations with String.format

* Replace string concatenations with String.format
---
 .../src/main/java/com/baeldung/polymorphism/GenericFile.java    | 2 +-
 .../src/main/java/com/baeldung/polymorphism/ImageFile.java      | 2 +-
 core-java/src/main/java/com/baeldung/polymorphism/TextFile.java | 2 +-
 .../java/com/baeldung/polymorphism/PolymorphismUnitTest.java    | 2 --
 4 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/core-java/src/main/java/com/baeldung/polymorphism/GenericFile.java b/core-java/src/main/java/com/baeldung/polymorphism/GenericFile.java
index 4075083c49..03e704f36f 100644
--- a/core-java/src/main/java/com/baeldung/polymorphism/GenericFile.java
+++ b/core-java/src/main/java/com/baeldung/polymorphism/GenericFile.java
@@ -54,7 +54,7 @@ public class GenericFile {
     }
 
     public String getFileInfo() {
-        return "File Name: " + this.getName() + "\n" + "Extension: " + this.getExtension() + "\n" + "Date Created: " + this.getDateCreated() + "\n" + "Version: " + this.getVersion() + "\n";
+        return String.format("File Name: %s\n" + " Extension: %s\n" + " Date Created: %s\n" + " Version: %s\n", this.getName(), this.getExtension(), this.getDateCreated(), this.getVersion());
     }
 
     public Object read() {
diff --git a/core-java/src/main/java/com/baeldung/polymorphism/ImageFile.java b/core-java/src/main/java/com/baeldung/polymorphism/ImageFile.java
index ac72a40993..e237f3f826 100644
--- a/core-java/src/main/java/com/baeldung/polymorphism/ImageFile.java
+++ b/core-java/src/main/java/com/baeldung/polymorphism/ImageFile.java
@@ -30,7 +30,7 @@ public class ImageFile extends GenericFile {
     }
 
     public String getFileInfo() {
-        return super.getFileInfo() + "Height: " + this.getHeight() + "\n" + "Width: " + this.getWidth();
+        return String.format(" %s Height: %d\n Width: %d", super.getFileInfo(), this.getHeight(), this.getWidth());
     }
 
     public String read() {
diff --git a/core-java/src/main/java/com/baeldung/polymorphism/TextFile.java b/core-java/src/main/java/com/baeldung/polymorphism/TextFile.java
index 8280b4ee95..2c28c968b8 100644
--- a/core-java/src/main/java/com/baeldung/polymorphism/TextFile.java
+++ b/core-java/src/main/java/com/baeldung/polymorphism/TextFile.java
@@ -21,7 +21,7 @@ public class TextFile extends GenericFile {
     }
 
     public String getFileInfo() {
-        return super.getFileInfo() + "Word Count: " + wordCount;
+        return String.format(" %s Word Count: %d", super.getFileInfo(), wordCount);
     }
 
     public String read() {
diff --git a/core-java/src/test/java/com/baeldung/polymorphism/PolymorphismUnitTest.java b/core-java/src/test/java/com/baeldung/polymorphism/PolymorphismUnitTest.java
index 8fb606c2fc..58826766e0 100644
--- a/core-java/src/test/java/com/baeldung/polymorphism/PolymorphismUnitTest.java
+++ b/core-java/src/test/java/com/baeldung/polymorphism/PolymorphismUnitTest.java
@@ -3,8 +3,6 @@ package com.baeldung.polymorphism;
 import static org.junit.Assert.*;
 
 import java.awt.image.BufferedImage;
-
-import org.junit.Ignore;
 import org.junit.Test;
 
 public class PolymorphismUnitTest {