BAEL-4936: converted multiline code to one liner, also changed names of unit test methods

This commit is contained in:
Vikas Ramsingh Rajput 2021-06-11 19:55:03 +05:30
parent 12dc1287a5
commit c3563566f8
3 changed files with 5 additions and 13 deletions

View File

@ -9,11 +9,7 @@ public abstract class CircleClass {
private List<String> allowedColors = Arrays.asList("RED", "GREEN", "BLUE"); private List<String> allowedColors = Arrays.asList("RED", "GREEN", "BLUE");
public boolean isValid() { public boolean isValid() {
if (allowedColors.contains(getColor())) { return allowedColors.contains(getColor());
return true;
} else {
return false;
}
} }
public String getColor() { public String getColor() {

View File

@ -9,10 +9,6 @@ public interface CircleInterface {
String getColor(); String getColor();
public default boolean isValid() { public default boolean isValid() {
if (allowedColors.contains(getColor())) { return allowedColors.contains(getColor());
return true;
} else {
return false;
}
} }
} }

View File

@ -6,14 +6,14 @@ import org.junit.Test;
public class InterfaceVsAbstractClassUnitTest { public class InterfaceVsAbstractClassUnitTest {
@Test @Test
public void givenAbstractClass_whenValidCircleUsedThenPass() { public void givenAbstractClass_whenValidCircleUsed_thenPass() {
CircleClass redCircle = new ChildCircleClass(); CircleClass redCircle = new ChildCircleClass();
redCircle.setColor("RED"); redCircle.setColor("RED");
assertTrue(redCircle.isValid()); assertTrue(redCircle.isValid());
} }
@Test @Test
public void givenInterface_whenValidCircleWithoutStateUsedThenPass() { public void givenInterface_whenValidCircleWithoutStateUsed_thenPass() {
ChidlCircleInterfaceImpl redCircleWithoutState = new ChidlCircleInterfaceImpl(); ChidlCircleInterfaceImpl redCircleWithoutState = new ChidlCircleInterfaceImpl();
redCircleWithoutState.setColor("RED"); redCircleWithoutState.setColor("RED");
assertTrue(redCircleWithoutState.isValid()); assertTrue(redCircleWithoutState.isValid());