iSharkFly-Docs/java-tutorials
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

change return type to optional

Browse Source
This commit is contained in:
Deboshree 2023-05-18 19:27:02 +05:30
parent d694564141
commit c4431dadf5
2 changed files with 25 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
core-java-modules/core-java-string-conversions-3/src/main/java/com/baeldung/stringtoint/StringToIntConverter.java
View File

@ -4,38 +4,34 @@ import java.util.Optional;
import org.apache.commons.lang3.math.NumberUtils; import org.apache.commons.lang3.math.NumberUtils;
public class StringToIntConverter { public class StringToIntConverter {
Optional<Integer> convertStringToIntUsingIntegerParseInt(String input){
private StringToIntConverter() {
}
public static Integer convertStringToIntUsingIntegerParseInt(String input){
try { try {
return Integer.parseInt(input); return Optional.of(Integer.parseInt(input));
} catch (NumberFormatException e) { } catch (NumberFormatException e) {
// log or handle the error // log or handle the error
return Integer.MIN_VALUE; return Optional.empty();
} }
} }
public static Integer convertStringToIntUsingIntegerValueOf(String input){ Optional<Integer> convertStringToIntUsingIntegerValueOf(String input){
try { try {
return Integer.valueOf(input); return Optional.of(Integer.valueOf(input));
} catch (NumberFormatException e) { } catch (NumberFormatException e) {
// log or handle the error // log or handle the error
return Integer.MIN_VALUE; return Optional.empty();
} }
} }
public static Integer convertStringToIntUsingIntegerDecode(String input){ Optional<Integer> convertStringToIntUsingIntegerDecode(String input){
try { try {
return Integer.decode(input); return Optional.of(Integer.decode(input));
} catch (Exception e) { } catch (Exception e) {
// log or handle the error // log or handle the error
return Integer.MIN_VALUE; return Optional.empty();
} }
} }
public static Integer convertStringToIntUsingOptional(String input){ Optional<Integer> convertStringToIntUsingOptional(String input){
Optional<Integer> parsedInt; Optional<Integer> parsedInt;
try { try {
parsedInt = Optional.of(Integer.parseInt(input)); parsedInt = Optional.of(Integer.parseInt(input));
@ -43,10 +39,10 @@ public class StringToIntConverter {
// log or handle the error // log or handle the error
parsedInt = Optional.empty(); parsedInt = Optional.empty();
} }
return parsedInt.orElse(Integer.MIN_VALUE); return parsedInt;
} }
public static int convertStringToIntUsingNumberUtils(String input, Integer defaultValue){ int convertStringToIntUsingNumberUtils(String input, Integer defaultValue){
return NumberUtils.toInt(input, defaultValue); return NumberUtils.toInt(input, defaultValue);
} }
} }

24
core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtoint/StringToIntConverterUnitTest.java
View File

@ -5,7 +5,9 @@ import java.util.List;
import org.junit.jupiter.api.Assertions; import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
class StringToIntConverterUnitTest { class stringToIntConverter {
private StringToIntConverter stringToIntConverter = new StringToIntConverter();
@Test @Test
void whenConvertingIntToString_thenInvalidCasesReturnIntegerMinValue() { void whenConvertingIntToString_thenInvalidCasesReturnIntegerMinValue() {
@ -18,11 +20,11 @@ class StringToIntConverterUnitTest {
new TestData("hello", Integer.MIN_VALUE) new TestData("hello", Integer.MIN_VALUE)
); );
testData.forEach(data -> { testData.forEach(data -> {
Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingIntegerParseInt(data.input)); Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingIntegerParseInt(data.input).orElse(Integer.MIN_VALUE));
Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingIntegerValueOf(data.input)); Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingIntegerValueOf(data.input).orElse(Integer.MIN_VALUE));
Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingOptional(data.input)); Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingOptional(data.input).orElse(Integer.MIN_VALUE));
Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingIntegerDecode(data.input)); Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingIntegerDecode(data.input).orElse(Integer.MIN_VALUE));
Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingNumberUtils(data.input,Integer.MIN_VALUE )); Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingNumberUtils(data.input,Integer.MIN_VALUE ));
}); });
} }
@ -33,11 +35,11 @@ class StringToIntConverterUnitTest {
new TestData("-23", -23) new TestData("-23", -23)
); );
testData.forEach(data -> { testData.forEach(data -> {
Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingIntegerParseInt(data.input)); Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingIntegerParseInt(data.input).orElse(Integer.MIN_VALUE));
Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingIntegerValueOf(data.input)); Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingIntegerValueOf(data.input).orElse(Integer.MIN_VALUE));
Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingOptional(data.input)); Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingOptional(data.input).orElse(Integer.MIN_VALUE));
Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingNumberUtils(data.input, Integer.MIN_VALUE)); Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingNumberUtils(data.input, Integer.MIN_VALUE));
Assertions.assertEquals(data.expectedOutput, StringToIntConverter.convertStringToIntUsingIntegerDecode(data.input)); Assertions.assertEquals(data.expectedOutput, stringToIntConverter.convertStringToIntUsingIntegerDecode(data.input).orElse(Integer.MIN_VALUE));
}); });
} }