iSharkFly-Docs/java-tutorials
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changes for Code review feedback:

Browse Source 
1. Change main method to use command-line input.
2. Update test class to use static imports.
2. Add more use cases in test-cases.
This commit is contained in:
akash.pandey 2018-12-02 10:44:27 +05:30
parent ed0713046f
commit ca681a8e67
2 changed files with 21 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
algorithms-miscellaneous-1/src/main/java/com/baeldung/algorithms/string/LongestSubstringNonRepeatingCharacters.java
View File

@ -44,8 +44,11 @@ public class LongestSubstringNonRepeatingCharacters {
} }
public static void main(String[] args) { public static void main(String[] args) {
String input = "CODINGISAWESOME"; if(args.length > 0) {
System.out.println(getUniqueCharacterSubstring(input)); System.out.println(getUniqueCharacterSubstring(args[0]));
} else {
System.err.println("This program expects command-line input. Please try again!");
}
} }
} }

21
algorithms-miscellaneous-1/src/test/java/com/baeldung/algorithms/string/LongestSubstringNonRepeatingCharactersTest.java
View File

@ -1,20 +1,31 @@
package com.baeldung.algorithms.string; package com.baeldung.algorithms.string;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static com.baeldung.algorithms.string.LongestSubstringNonRepeatingCharacters.getUniqueCharacterSubstring;
import static com.baeldung.algorithms.string.LongestSubstringNonRepeatingCharacters.getUniqueCharacterSubstringBruteForce;
public class LongestSubstringNonRepeatingCharactersTest { public class LongestSubstringNonRepeatingCharactersTest {
@Test @Test
void givenString_whenGetUniqueCharacterSubstringBruteForceCalled_thenResultFoundAsExpected() { void givenString_whenGetUniqueCharacterSubstringBruteForceCalled_thenResultFoundAsExpected() {
String input = "CODINGISAWESOME"; assertEquals("", getUniqueCharacterSubstringBruteForce(""));
Assertions.assertEquals("NGISAWE", LongestSubstringNonRepeatingCharacters.getUniqueCharacterSubstringBruteForce(input)); assertEquals("A", getUniqueCharacterSubstringBruteForce("A"));
assertEquals("ABCDEF", getUniqueCharacterSubstringBruteForce("AABCDEF"));
assertEquals("ABCDEF", getUniqueCharacterSubstringBruteForce("ABCDEFF"));
assertEquals("NGISAWE", getUniqueCharacterSubstringBruteForce("CODINGISAWESOME"));
assertEquals("be coding", getUniqueCharacterSubstringBruteForce("always be coding"));
} }
@Test @Test
void givenString_whenGetUniqueCharacterSubstringCalled_thenResultFoundAsExpected() { void givenString_whenGetUniqueCharacterSubstringCalled_thenResultFoundAsExpected() {
String input = "CODINGISAWESOME"; assertEquals("", getUniqueCharacterSubstring(""));
Assertions.assertEquals("NGISAWE",LongestSubstringNonRepeatingCharacters.getUniqueCharacterSubstring(input)); assertEquals("A", getUniqueCharacterSubstring("A"));
assertEquals("ABCDEF", getUniqueCharacterSubstring("AABCDEF"));
assertEquals("ABCDEF", getUniqueCharacterSubstring("ABCDEFF"));
assertEquals("NGISAWE", getUniqueCharacterSubstring("CODINGISAWESOME"));
assertEquals("be coding", getUniqueCharacterSubstring("always be coding"));
} }
} }