Address review comments

This commit is contained in:
rajatgarg 2023-09-06 02:17:39 +05:30
parent 869b931e73
commit d7367094f3
1 changed files with 6 additions and 6 deletions

View File

@ -12,18 +12,18 @@ import java.util.Set;
import org.apache.tika.mime.MimeType; import org.apache.tika.mime.MimeType;
import org.apache.tika.mime.MimeTypeException; import org.apache.tika.mime.MimeTypeException;
import org.apache.tika.mime.MimeTypes;
import org.junit.Test; import org.junit.Test;
import com.j256.simplemagic.ContentInfo; import com.j256.simplemagic.ContentInfo;
public class ExtensionFromMimeTypeUnitTest { public class ExtensionFromMimeTypeUnitTest {
public static final String JPEG_EXT = "image/jpeg"; private static final String IMG_MIME_TYPE = "image/jpeg";
@Test @Test
public void whenUsingTika_thenGetFileExtension() throws MimeTypeException { public void whenUsingTika_thenGetFileExtension() throws MimeTypeException {
List<String> SUPPORTED_EXTENSIONS = Arrays.asList(".jpg", ".jpeg", ".jpe", ".jif", ".jfif", ".jfi"); List<String> SUPPORTED_EXTENSIONS = Arrays.asList(".jpg", ".jpeg", ".jpe", ".jif", ".jfif", ".jfi");
MimeTypes allTypes = MimeTypes.getDefaultMimeTypes(); org.apache.tika.mime.MimeTypes allTypes = org.apache.tika.mime.MimeTypes.getDefaultMimeTypes();
MimeType type = allTypes.forName(JPEG_EXT); MimeType type = allTypes.forName(IMG_MIME_TYPE);
String extension = type.getExtension(); String extension = type.getExtension();
assertEquals(".jpg", extension); assertEquals(".jpg", extension);
List<String> supportedExtensions = type.getExtensions(); List<String> supportedExtensions = type.getExtensions();
@ -33,14 +33,14 @@ public class ExtensionFromMimeTypeUnitTest {
@Test @Test
public void whenUsingJodd_thenGetFileExtension() { public void whenUsingJodd_thenGetFileExtension() {
String[] supportedExtensions = {"jpeg","jpg","jpe"}; String[] supportedExtensions = {"jpeg","jpg","jpe"};
String[] extensionsByMimeTypes = jodd.net.MimeTypes.findExtensionsByMimeTypes(JPEG_EXT, false); String[] extensionsByMimeTypes = jodd.net.MimeTypes.findExtensionsByMimeTypes(IMG_MIME_TYPE, false);
assertArrayEquals(supportedExtensions, extensionsByMimeTypes); assertArrayEquals(supportedExtensions, extensionsByMimeTypes);
} }
@Test @Test
public void whenUsingMimetypesFileTypeMap_thenGetFileExtension() { public void whenUsingMimetypesFileTypeMap_thenGetFileExtension() {
String[] supportedExtensions = {"jpeg","jpg","jpe"}; String[] supportedExtensions = {"jpeg","jpg","jpe"};
ContentInfo contentInfo = new ContentInfo("", JPEG_EXT, "", true); ContentInfo contentInfo = new ContentInfo("", IMG_MIME_TYPE, "", true);
String[] fileExtensions = contentInfo.getFileExtensions(); String[] fileExtensions = contentInfo.getFileExtensions();
assertArrayEquals(supportedExtensions, fileExtensions); assertArrayEquals(supportedExtensions, fileExtensions);
} }