From d7577d260159dedc9e5e59540992e6ff3f212509 Mon Sep 17 00:00:00 2001 From: Anshul BANSAL Date: Wed, 7 Apr 2021 13:20:24 +0300 Subject: [PATCH] BAEL-4786 - review comments - removed close method --- .../com/baeldung/datagramchannel/DatagramClient.java | 1 - .../com/baeldung/datagramchannel/DatagramServer.java | 2 -- .../datagramchannel/DatagramChannelUnitTest.java | 11 ++++++++--- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/core-java-modules/core-java-nio-2/src/main/java/com/baeldung/datagramchannel/DatagramClient.java b/core-java-modules/core-java-nio-2/src/main/java/com/baeldung/datagramchannel/DatagramClient.java index 867378cc50..e377cc431c 100644 --- a/core-java-modules/core-java-nio-2/src/main/java/com/baeldung/datagramchannel/DatagramClient.java +++ b/core-java-modules/core-java-nio-2/src/main/java/com/baeldung/datagramchannel/DatagramClient.java @@ -17,7 +17,6 @@ public class DatagramClient { public static void sendMessage(DatagramChannel client, String msg, SocketAddress serverAddress) throws IOException { ByteBuffer buffer = ByteBuffer.wrap(msg.getBytes()); client.send(buffer, serverAddress); - client.close(); } public static void main(String[] args) throws IOException { diff --git a/core-java-modules/core-java-nio-2/src/main/java/com/baeldung/datagramchannel/DatagramServer.java b/core-java-modules/core-java-nio-2/src/main/java/com/baeldung/datagramchannel/DatagramServer.java index 187599bb95..ed3345a26d 100644 --- a/core-java-modules/core-java-nio-2/src/main/java/com/baeldung/datagramchannel/DatagramServer.java +++ b/core-java-modules/core-java-nio-2/src/main/java/com/baeldung/datagramchannel/DatagramServer.java @@ -24,8 +24,6 @@ public class DatagramServer { System.out.println("Client at #" + remoteAdd + " sent: " + message); - server.close(); - return message; } diff --git a/core-java-modules/core-java-nio-2/src/test/java/com/baeldung/datagramchannel/DatagramChannelUnitTest.java b/core-java-modules/core-java-nio-2/src/test/java/com/baeldung/datagramchannel/DatagramChannelUnitTest.java index b971cc55f5..f816072ee7 100644 --- a/core-java-modules/core-java-nio-2/src/test/java/com/baeldung/datagramchannel/DatagramChannelUnitTest.java +++ b/core-java-modules/core-java-nio-2/src/test/java/com/baeldung/datagramchannel/DatagramChannelUnitTest.java @@ -12,13 +12,18 @@ public class DatagramChannelUnitTest { @Test public void whenClientSendsAndServerReceivesUDPPacket_thenCorrect() throws IOException { DatagramChannel server = DatagramServer.startServer(); - DatagramChannel client = DatagramClient.startClient(); - String msg = "Hello, this is a Baeldung's DatagramChannel based UDP client!"; + + String msg1 = "Hello, this is a Baeldung's DatagramChannel based UDP client!"; + String msg2 = "Hi again!, Are you there!"; + InetSocketAddress serverAddress = new InetSocketAddress("localhost", 7001); - DatagramClient.sendMessage(client, msg, serverAddress); + + DatagramClient.sendMessage(client, msg1, serverAddress); + DatagramClient.sendMessage(client, msg2, serverAddress); assertEquals("Hello, this is a Baeldung's DatagramChannel based UDP client!", DatagramServer.receiveMessage(server)); + assertEquals("Hi again!, Are you there!", DatagramServer.receiveMessage(server)); } }