incorporate review comments for BAEL-747 (#1603)

algorithms/src/main/java/com/baeldung/algorithms/primechecker/BigIntegerPrimeChecker.java

@@ -2,10 +2,10 @@ package com.baeldung.algorithms.primechecker;
 
 import java.math.BigInteger;
 
-public class BigIntegerPrimeChecker implements PrimeChecker{
+public class BigIntegerPrimeChecker implements PrimeChecker<Long>{
 
     @Override
-    public boolean isPrime(int number) {
+    public boolean isPrime(Long number) {
         BigInteger bigInt = BigInteger.valueOf(number);
         return bigInt.isProbablePrime(100);
     }

algorithms/src/main/java/com/baeldung/algorithms/primechecker/BruteForcePrimeChecker.java

@@ -1,12 +1,15 @@
 package com.baeldung.algorithms.primechecker;
 
 import java.util.stream.IntStream;
+import java.util.stream.LongStream;
 
-public class BruteForcePrimeChecker implements PrimeChecker{
+public class BruteForcePrimeChecker implements PrimeChecker<Integer>{
 
     @Override
-    public boolean isPrime(int number) {
+    public boolean isPrime(Integer number) {
-        return IntStream.range(2, number).noneMatch(n -> (number % n == 0));
+        
+        return number > 2 ? IntStream.range(2, number)
+            .noneMatch(n -> (number % n == 0)) : false;
     }
 
     

algorithms/src/main/java/com/baeldung/algorithms/primechecker/OptimisedPrimeChecker.java

@@ -1,13 +1,14 @@
 package com.baeldung.algorithms.primechecker;
 
 import java.util.stream.IntStream;
+import java.util.stream.LongStream;
 
-public class OptimisedPrimeChecker implements PrimeChecker{
+public class OptimisedPrimeChecker implements PrimeChecker<Integer>{
 
     @Override
-    public boolean isPrime(int number) {
+    public boolean isPrime(Integer number) {
-        return IntStream.range(2, (int)Math.sqrt(number) + 1)
+        return number > 2 ? IntStream.rangeClosed(2, (int) Math.sqrt(number))
-            .noneMatch(n -> (number % n == 0));
+            .noneMatch(n -> (number % n == 0)) : false;
     }
 
     

algorithms/src/main/java/com/baeldung/algorithms/primechecker/PrimeChecker.java

@@ -1,6 +1,6 @@
 package com.baeldung.algorithms.primechecker;
 
-public interface PrimeChecker {
+public interface PrimeChecker <T> {
     
-    public boolean isPrime( int number );
+    public boolean isPrime( T number );
 }

algorithms/src/main/java/com/baeldung/algorithms/primechecker/PrimesPrimeChecker.java

@@ -2,10 +2,10 @@ package com.baeldung.algorithms.primechecker;
 
 import org.apache.commons.math3.primes.Primes;
 
-public class PrimesPrimeChecker implements PrimeChecker{
+public class PrimesPrimeChecker implements PrimeChecker<Integer>{
 
     @Override
-    public boolean isPrime(int number) {
+    public boolean isPrime(Integer number) {
         return Primes.isPrime(number);
     }
 

algorithms/src/test/java/com/baeldung/algorithms/primechecker/BigIntegerPrimeCheckerTest.java

@@ -9,18 +9,20 @@ import com.baeldung.algorithms.primechecker.PrimeChecker;
 
 public class BigIntegerPrimeCheckerTest {
 
-    PrimeChecker primeChecker = new BigIntegerPrimeChecker();
+    BigIntegerPrimeChecker primeChecker = new BigIntegerPrimeChecker();
     
     @Test
     public void givenPrimeNumber_whenCheckIsPrime_thenTrue(){
-        assertTrue(primeChecker.isPrime(13));
+        assertTrue(primeChecker.isPrime(13l));
-        assertTrue(primeChecker.isPrime(1009));
+        assertTrue(primeChecker.isPrime(1009L));
+        assertTrue(primeChecker.isPrime(74207281L));
     }
     
     @Test
     public void givenNonPrimeNumber_whenCheckIsPrime_thenFalse(){
-        assertTrue(!primeChecker.isPrime(50));
+        assertTrue(!primeChecker.isPrime(50L));
-        assertTrue(!primeChecker.isPrime(1001));
+        assertTrue(!primeChecker.isPrime(1001L));
+        assertTrue(!primeChecker.isPrime(74207282L));
     }
     
 }

algorithms/src/test/java/com/baeldung/algorithms/primechecker/OptimisedPrimeCheckerTest.java

@@ -9,7 +9,7 @@ import com.baeldung.algorithms.primechecker.PrimeChecker;
 
 public class OptimisedPrimeCheckerTest {
 
-    PrimeChecker primeChecker = new OptimisedPrimeChecker();
+    OptimisedPrimeChecker primeChecker = new OptimisedPrimeChecker();
     
     @Test
     public void givenPrimeNumber_whenCheckIsPrime_thenTrue(){

algorithms/src/test/java/com/baeldung/algorithms/primechecker/PrimesPrimeCheckerTest.java

@@ -8,7 +8,7 @@ import com.baeldung.algorithms.primechecker.PrimeChecker;
 import com.baeldung.algorithms.primechecker.PrimesPrimeChecker;
 
 public class PrimesPrimeCheckerTest {
-    PrimeChecker primeChecker = new PrimesPrimeChecker();
+    PrimesPrimeChecker primeChecker = new PrimesPrimeChecker();
 
     @Test
     public void givenPrimeNumber_whenCheckIsPrime_thenTrue() {