diff --git a/mock-comparisons/pom.xml b/mock-comparisons/pom.xml index c7a6dcb09d..97e24c61cd 100644 --- a/mock-comparisons/pom.xml +++ b/mock-comparisons/pom.xml @@ -7,14 +7,18 @@ mockito + + 4.12 + 1.10.19 + 3.4 + 1.24 + + + 3.3 + 2.18.1 + + - - - - - - - junit junit @@ -61,8 +65,8 @@ maven-compiler-plugin ${maven-compiler-plugin.version} - 1.7 - 1.7 + 1.8 + 1.8 @@ -76,30 +80,5 @@ - - - - - - - - - - - - - 4.12 - 1.10.19 - 3.4 - 1.24 - - - 3.3 - 2.6 - 2.18.1 - 2.7 - 1.4.14 - - \ No newline at end of file diff --git a/mock-comparisons/src/main/java/org/baeldung/mocks/testCase/LoginController.java b/mock-comparisons/src/main/java/org/baeldung/mocks/testCase/LoginController.java index 2e25332db8..914b0034d2 100644 --- a/mock-comparisons/src/main/java/org/baeldung/mocks/testCase/LoginController.java +++ b/mock-comparisons/src/main/java/org/baeldung/mocks/testCase/LoginController.java @@ -4,10 +4,10 @@ public class LoginController { public LoginService loginService; - public String login(UserForm userForm){ - if(null == userForm){ + public String login(UserForm userForm) { + if (null == userForm) { return "ERROR"; - }else{ + } else { boolean logged; try { @@ -16,10 +16,10 @@ public class LoginController { return "ERROR"; } - if(logged){ + if (logged) { loginService.setCurrentUser(userForm.getUsername()); return "OK"; - }else{ + } else { return "KO"; } } diff --git a/mock-comparisons/src/main/java/org/baeldung/mocks/testCase/LoginDao.java b/mock-comparisons/src/main/java/org/baeldung/mocks/testCase/LoginDao.java index 4641fc1889..2cbff6c9d4 100644 --- a/mock-comparisons/src/main/java/org/baeldung/mocks/testCase/LoginDao.java +++ b/mock-comparisons/src/main/java/org/baeldung/mocks/testCase/LoginDao.java @@ -2,7 +2,7 @@ package org.baeldung.mocks.testCase; public class LoginDao { - public int login(UserForm userForm){ + public int login(UserForm userForm) { //actual call to a third party library return 0; } diff --git a/mock-comparisons/src/main/java/org/baeldung/mocks/testCase/LoginService.java b/mock-comparisons/src/main/java/org/baeldung/mocks/testCase/LoginService.java index 2a20159393..d6a31a8047 100644 --- a/mock-comparisons/src/main/java/org/baeldung/mocks/testCase/LoginService.java +++ b/mock-comparisons/src/main/java/org/baeldung/mocks/testCase/LoginService.java @@ -11,7 +11,7 @@ public class LoginService { int loginResults = loginDao.login(userForm); - switch (loginResults){ + switch (loginResults) { case 1: return true; default: @@ -20,7 +20,7 @@ public class LoginService { } public void setCurrentUser(String username) { - if(null != username){ + if (null != username) { this.currentUser = username; } } diff --git a/mock-comparisons/src/main/java/org/baeldung/mocks/testCase/UserForm.java b/mock-comparisons/src/main/java/org/baeldung/mocks/testCase/UserForm.java index d6ee444909..14136d0f31 100644 --- a/mock-comparisons/src/main/java/org/baeldung/mocks/testCase/UserForm.java +++ b/mock-comparisons/src/main/java/org/baeldung/mocks/testCase/UserForm.java @@ -8,7 +8,7 @@ public class UserForm { public String username; - public String getUsername(){ + public String getUsername() { return username; } diff --git a/mock-comparisons/src/test/java/org/baeldung/mocks/easymock/LoginControllerTest.java b/mock-comparisons/src/test/java/org/baeldung/mocks/easymock/LoginControllerTest.java index b80c28804a..25d2b91ede 100644 --- a/mock-comparisons/src/test/java/org/baeldung/mocks/easymock/LoginControllerTest.java +++ b/mock-comparisons/src/test/java/org/baeldung/mocks/easymock/LoginControllerTest.java @@ -9,10 +9,6 @@ import org.junit.Assert; import org.junit.Test; import org.junit.runner.RunWith; -/** - *

Test for LoginController using EasyMock.

- * Created by Alvaro on 12/06/2016. - */ @RunWith(EasyMockRunner.class) public class LoginControllerTest { @@ -133,7 +129,7 @@ public class LoginControllerTest { loginServicePartial.setLoginDao(loginDao); loginController.loginService = loginServicePartial; - + EasyMock.replay(loginDao); EasyMock.replay(loginServicePartial); diff --git a/mock-comparisons/src/test/java/org/baeldung/mocks/jmockit/LoginControllerTest.java b/mock-comparisons/src/test/java/org/baeldung/mocks/jmockit/LoginControllerTest.java index d1c502ce55..621342fed2 100644 --- a/mock-comparisons/src/test/java/org/baeldung/mocks/jmockit/LoginControllerTest.java +++ b/mock-comparisons/src/test/java/org/baeldung/mocks/jmockit/LoginControllerTest.java @@ -12,10 +12,6 @@ import org.junit.Assert; import org.junit.Test; import org.junit.runner.RunWith; -/** - *

Test for LoginController using JMockit.

- * Created by Alvaro on 12/06/2016. - */ @RunWith(JMockit.class) public class LoginControllerTest { @@ -32,7 +28,8 @@ public class LoginControllerTest { public void assertThatNoMethodHasBeenCalled() { loginController.login(null); // no method called - new FullVerifications(loginService) {}; + new FullVerifications(loginService) { + }; } @Test @@ -40,14 +37,16 @@ public class LoginControllerTest { final UserForm userForm = new UserForm(); userForm.username = "foo"; new Expectations() {{ - loginService.login(userForm); result = true; + loginService.login(userForm); + result = true; loginService.setCurrentUser("foo"); }}; String login = loginController.login(userForm); Assert.assertEquals("OK", login); - new FullVerifications(loginService) {}; + new FullVerifications(loginService) { + }; } @Test @@ -55,43 +54,51 @@ public class LoginControllerTest { final UserForm userForm = new UserForm(); userForm.username = "foo"; new Expectations() {{ - loginService.login(userForm); result = false; + loginService.login(userForm); + result = false; // no expectation for setCurrentUser }}; String login = loginController.login(userForm); Assert.assertEquals("KO", login); - new FullVerifications(loginService) {}; + new FullVerifications(loginService) { + }; } @Test public void mockExceptionThrowing() { final UserForm userForm = new UserForm(); new Expectations() {{ - loginService.login(userForm); result = new IllegalArgumentException(); + loginService.login(userForm); + result = new IllegalArgumentException(); // no expectation for setCurrentUser }}; String login = loginController.login(userForm); Assert.assertEquals("ERROR", login); - new FullVerifications(loginService) {}; + new FullVerifications(loginService) { + }; } @Test public void mockAnObjectToPassAround(@Mocked final UserForm userForm) { new Expectations() {{ - userForm.getUsername(); result = "foo"; - loginService.login(userForm); result = true; + userForm.getUsername(); + result = "foo"; + loginService.login(userForm); + result = true; loginService.setCurrentUser("foo"); }}; - + String login = loginController.login(userForm); Assert.assertEquals("OK", login); - new FullVerifications(loginService) {}; - new FullVerifications(userForm) {}; + new FullVerifications(loginService) { + }; + new FullVerifications(userForm) { + }; } @Test @@ -119,7 +126,8 @@ public class LoginControllerTest { String login = loginController.login(userForm); Assert.assertEquals("OK", login); - new FullVerifications(loginService) {}; + new FullVerifications(loginService) { + }; } @Test @@ -133,7 +141,8 @@ public class LoginControllerTest { userForm.username = "foo"; // let service's login use implementation so let's mock DAO call new Expectations() {{ - loginDao.login(userForm); result = 1; + loginDao.login(userForm); + result = 1; // no expectation for loginService.login partialLoginService.setCurrentUser("foo"); }}; @@ -142,7 +151,9 @@ public class LoginControllerTest { Assert.assertEquals("OK", login); // verify mocked call - new FullVerifications(partialLoginService) {}; - new FullVerifications(loginDao) {}; + new FullVerifications(partialLoginService) { + }; + new FullVerifications(loginDao) { + }; } } diff --git a/mock-comparisons/src/test/java/org/baeldung/mocks/mockito/LoginControllerTest.java b/mock-comparisons/src/test/java/org/baeldung/mocks/mockito/LoginControllerTest.java index 841dd493e6..59b28a2cb4 100644 --- a/mock-comparisons/src/test/java/org/baeldung/mocks/mockito/LoginControllerTest.java +++ b/mock-comparisons/src/test/java/org/baeldung/mocks/mockito/LoginControllerTest.java @@ -9,10 +9,6 @@ import org.junit.Before; import org.junit.Test; import org.mockito.*; -/** - *

Test for LoginController using Mockito.

- * Created by Alvaro on 12/06/2016. - */ public class LoginControllerTest { @Mock