BAEL-4321 move to new module and use BDD for test names

configuration/yaml-to-pojo/src/test/java/yamltopojo/demo/DemoApplicationTests.java

@@ -1,13 +0,0 @@
-package yamltopojo.demo;
-
-import org.junit.jupiter.api.Test;
-import org.springframework.boot.test.context.SpringBootTest;
-
-@SpringBootTest
-class DemoApplicationTests {
-
-	@Test
-	void contextLoads() {
-	}
-
-}

spring-boot-modules/spring-boot-data-2/src/main/java/yamltopojo/demo/controller/TshirtSizeController.java

@@ -7,7 +7,7 @@ import yamltopojo.demo.service.SizeConverterService;
 @RequestMapping(value = "/")
 public class TshirtSizeController {
 
-    private SizeConverterService service;
+    private final SizeConverterService service;
 
     public TshirtSizeController(SizeConverterService service) {
         this.service = service;

spring-boot-modules/spring-boot-data-2/src/main/java/yamltopojo/demo/service/SizeConverterImpl.java

@@ -7,7 +7,7 @@ import yamltopojo.demo.config.TshirtSizeConfig;
 @Service
 public class SizeConverterImpl implements SizeConverterService {
 
-    private TshirtSizeConfig tshirtSizeConfig;
+    private final TshirtSizeConfig tshirtSizeConfig;
 
     public SizeConverterImpl(TshirtSizeConfig tshirtSizeConfig) {
         this.tshirtSizeConfig = tshirtSizeConfig;
@@ -17,6 +17,6 @@ public class SizeConverterImpl implements SizeConverterService {
         if(countryCode == null) {
             return tshirtSizeConfig.getSimpleMapping().get(label);
         }
-        return tshirtSizeConfig.getComplexMapping().get(label).get(countryCode);
+        return tshirtSizeConfig.getComplexMapping().get(label).get(countryCode.toLowerCase());
     }
 }

spring-boot-modules/spring-boot-data-2/src/test/java/yamltopojo/demo/controller/TshirtSizeControllerTest.java

@@ -20,14 +20,14 @@ class TshirtSizeControllerTest {
     private TshirtSizeController tested;
 
     @Test
-    void convertSize() {
+    void givenSizeConverter_whenLabelIsSandCountryCodeIsFr_thenReturnCorrectSize() {
 
         // Given
         String label = "S";
         String countryCode = "fr";
         int result = 36;
 
-        //
+        // When
         when(service.convertSize(label, countryCode)).thenReturn(result);
         int actual = tested.convertSize(label, countryCode);