From e59d0e481d07a004d19985315e4774bf226961ca Mon Sep 17 00:00:00 2001 From: BudBak Date: Fri, 10 Jan 2020 15:10:43 +0530 Subject: [PATCH] BAEL-3481 - modified as per Editor Review comments. --- .../balancedbrackets/BalancedBracketsUsingDeque.java | 2 +- .../balancedbrackets/BalancedBracketsUsingString.java | 2 +- .../balancedbrackets/BalancedBracketsUsingDequeUnitTest.java | 4 ++-- .../balancedbrackets/BalancedBracketsUsingStringUnitTest.java | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/algorithms-miscellaneous-5/src/main/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingDeque.java b/algorithms-miscellaneous-5/src/main/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingDeque.java index 2734a622e3..cc3e246962 100644 --- a/algorithms-miscellaneous-5/src/main/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingDeque.java +++ b/algorithms-miscellaneous-5/src/main/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingDeque.java @@ -6,7 +6,7 @@ import java.util.LinkedList; public class BalancedBracketsUsingDeque { public boolean isBalanced(String str) { - if (null == str || str.length() == 0 || ((str.length() % 2) != 0)) { + if (null == str || ((str.length() % 2) != 0)) { return false; } else { char[] ch = str.toCharArray(); diff --git a/algorithms-miscellaneous-5/src/main/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingString.java b/algorithms-miscellaneous-5/src/main/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingString.java index d808842dc3..60d7191597 100644 --- a/algorithms-miscellaneous-5/src/main/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingString.java +++ b/algorithms-miscellaneous-5/src/main/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingString.java @@ -3,7 +3,7 @@ package com.baeldung.algorithms.balancedbrackets; public class BalancedBracketsUsingString { public boolean isBalanced(String str) { - if (null == str || str.length() == 0 || ((str.length() % 2) != 0)) { + if (null == str || ((str.length() % 2) != 0)) { return false; } else { char[] ch = str.toCharArray(); diff --git a/algorithms-miscellaneous-5/src/test/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingDequeUnitTest.java b/algorithms-miscellaneous-5/src/test/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingDequeUnitTest.java index 1d791dd29e..d7bed3000b 100644 --- a/algorithms-miscellaneous-5/src/test/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingDequeUnitTest.java +++ b/algorithms-miscellaneous-5/src/test/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingDequeUnitTest.java @@ -21,9 +21,9 @@ public class BalancedBracketsUsingDequeUnitTest { } @Test - public void givenEmptyString_whenCheckingForBalance_shouldReturnFalse() { + public void givenEmptyString_whenCheckingForBalance_shouldReturnTrue() { boolean result = balancedBracketsUsingDeque.isBalanced(""); - assertThat(result).isFalse(); + assertThat(result).isTrue(); } @Test diff --git a/algorithms-miscellaneous-5/src/test/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingStringUnitTest.java b/algorithms-miscellaneous-5/src/test/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingStringUnitTest.java index f192417e69..8f4d72d0e7 100644 --- a/algorithms-miscellaneous-5/src/test/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingStringUnitTest.java +++ b/algorithms-miscellaneous-5/src/test/java/com/baeldung/algorithms/balancedbrackets/BalancedBracketsUsingStringUnitTest.java @@ -21,9 +21,9 @@ public class BalancedBracketsUsingStringUnitTest { } @Test - public void givenEmptyString_whenCheckingForBalance_shouldReturnFalse() { + public void givenEmptyString_whenCheckingForBalance_shouldReturnTrue() { boolean result = balancedBracketsUsingString.isBalanced(""); - assertThat(result).isFalse(); + assertThat(result).isTrue(); } @Test