BAEL-7374 - Incorporated Review comments for PR
This commit is contained in:
		
							parent
							
								
									36f3e32ff6
								
							
						
					
					
						commit
						ec88f94427
					
				| @ -1,8 +1,8 @@ | ||||
| package com.baeldung.spring.kafka.start.stop.consumer; | ||||
| 
 | ||||
| public class Constants { | ||||
| 
 | ||||
|     public static final String MULTI_PARTITION_TOPIC = "multi_partition_topic"; | ||||
|     public static final int MULTIPLE_PARTITIONS = 5; | ||||
|     public static final short REPLICATION_FACTOR = 1; | ||||
| 
 | ||||
|     public static final String LISTENER_ID = "listener-id-1"; | ||||
| } | ||||
|  | ||||
| @ -11,7 +11,6 @@ public class KafkaListenerControlService { | ||||
|     @Autowired | ||||
|     private KafkaListenerEndpointRegistry registry; | ||||
| 
 | ||||
|     // Method to start a listener | ||||
|     public void startListener(String listenerId) { | ||||
|         MessageListenerContainer listenerContainer = registry.getListenerContainer(listenerId); | ||||
|         if (listenerContainer != null && !listenerContainer.isRunning()) { | ||||
| @ -19,7 +18,6 @@ public class KafkaListenerControlService { | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     // Method to stop a listener | ||||
|     public void stopListener(String listenerId) { | ||||
|         MessageListenerContainer listenerContainer = registry.getListenerContainer(listenerId); | ||||
|         if (listenerContainer != null && listenerContainer.isRunning()) { | ||||
|  | ||||
| @ -1,4 +1,5 @@ | ||||
| package com.baeldung.spring.kafka.start.stop.consumer; | ||||
| 
 | ||||
| import org.springframework.boot.SpringApplication; | ||||
| import org.springframework.boot.autoconfigure.SpringBootApplication; | ||||
| 
 | ||||
|  | ||||
| @ -1,10 +1,12 @@ | ||||
| package com.baeldung.spring.kafka.start.stop.consumer; | ||||
| 
 | ||||
| public class UserEvent { | ||||
|     private String userEventId; | ||||
|     private long eventNanoTime; | ||||
| 
 | ||||
|     public UserEvent(){} | ||||
|     private String userEventId; | ||||
| 
 | ||||
| 
 | ||||
|     public UserEvent() { | ||||
|     } | ||||
| 
 | ||||
|     public UserEvent(String userEventId) { | ||||
|         this.userEventId = userEventId; | ||||
| @ -18,11 +20,4 @@ public class UserEvent { | ||||
|         this.userEventId = userEventId; | ||||
|     } | ||||
| 
 | ||||
|     public long getEventNanoTime() { | ||||
|         return eventNanoTime; | ||||
|     } | ||||
| 
 | ||||
|     public void setEventNanoTime(long eventNanoTime) { | ||||
|         this.eventNanoTime = eventNanoTime; | ||||
|     } | ||||
| } | ||||
|  | ||||
| @ -1,4 +1,5 @@ | ||||
| package com.baeldung.spring.kafka.start.stop.consumer; | ||||
| 
 | ||||
| import org.slf4j.Logger; | ||||
| import org.slf4j.LoggerFactory; | ||||
| import org.springframework.beans.factory.annotation.Autowired; | ||||
| @ -7,6 +8,7 @@ import org.springframework.stereotype.Component; | ||||
| 
 | ||||
| @Component | ||||
| public class UserEventListener { | ||||
| 
 | ||||
|     private static final Logger logger = LoggerFactory.getLogger(UserEventListener.class); | ||||
| 
 | ||||
|     @Autowired | ||||
| @ -15,7 +17,7 @@ public class UserEventListener { | ||||
|     @KafkaListener(id = Constants.LISTENER_ID, topics = Constants.MULTI_PARTITION_TOPIC, groupId = "test-group", | ||||
|             containerFactory = "kafkaListenerContainerFactory", autoStartup = "false") | ||||
|     public void userEventListener(UserEvent userEvent) { | ||||
|         logger.info("Received UserEvent: " + userEvent.getUserEventId() + ", Time: " + userEvent.getEventNanoTime()); | ||||
|         logger.info("Received UserEvent: " + userEvent.getUserEventId()); | ||||
|         userEventStore.addUserEvent(userEvent); | ||||
|     } | ||||
| } | ||||
|  | ||||
| @ -7,6 +7,7 @@ import java.util.List; | ||||
| 
 | ||||
| @Component | ||||
| public class UserEventStore { | ||||
| 
 | ||||
|     private final List<UserEvent> userEvents = new ArrayList<>(); | ||||
| 
 | ||||
|     public void addUserEvent(UserEvent userEvent) { | ||||
|  | ||||
| @ -83,14 +83,12 @@ public class StartStopConsumerLiveTest { | ||||
| 
 | ||||
|         //Verification that listener has started. | ||||
|         UserEvent startUserEventTest = new UserEvent(UUID.randomUUID().toString()); | ||||
|         startUserEventTest.setEventNanoTime(System.nanoTime()); | ||||
|         producer.send(new ProducerRecord<>(Constants.MULTI_PARTITION_TOPIC, startUserEventTest)); | ||||
|         await().untilAsserted(() -> assertEquals(1, this.userEventStore.getUserEvents().size())); | ||||
|         this.userEventStore.clearUserEvents(); | ||||
| 
 | ||||
|         for (long count = 1; count <= 10; count++) { | ||||
|             UserEvent userEvent = new UserEvent(UUID.randomUUID().toString()); | ||||
|             userEvent.setEventNanoTime(System.nanoTime()); | ||||
|             Future<RecordMetadata> future = producer.send(new ProducerRecord<>(Constants.MULTI_PARTITION_TOPIC, userEvent)); | ||||
|             RecordMetadata metadata = future.get(); | ||||
|             if (count == 4) { | ||||
|  | ||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user