[BAEL-3841] PR review updates

This commit is contained in:
Adrian Maghear 2020-06-10 19:44:13 +02:00
parent e1a6218c1b
commit ee694afc51
3 changed files with 5 additions and 5 deletions

View File

@ -70,7 +70,7 @@
<dependency>
<groupId>net.bytebuddy</groupId>
<artifactId>byte-buddy</artifactId>
<version>1.10.10</version>
<version>1.10.11</version>
</dependency>
<dependency>
<groupId>org.springframework.data</groupId>

View File

@ -64,7 +64,7 @@ public class BookRepositoryCachingIntegrationTest {
}
@Test
void givenCachedBookWhenFindByTitleThenRepositoryShouldNotBeHit() {
void givenCachedBook_whenFindByTitle_thenRepositoryShouldNotBeHit() {
assertEquals(of(DUNE), bookRepository.findFirstByTitle("Dune"));
verify(mock).findFirstByTitle("Dune");
@ -75,7 +75,7 @@ public class BookRepositoryCachingIntegrationTest {
}
@Test
void givenNotCachedBookWhenFindByTitleThenRepositoryShouldBeHit() {
void givenNotCachedBook_whenFindByTitle_thenRepositoryShouldBeHit() {
assertEquals(of(FOUNDATION), bookRepository.findFirstByTitle("Foundation"));
assertEquals(of(FOUNDATION), bookRepository.findFirstByTitle("Foundation"));
assertEquals(of(FOUNDATION), bookRepository.findFirstByTitle("Foundation"));

View File

@ -38,14 +38,14 @@ public class BookRepositoryIntegrationTest {
}
@Test
void givenBookThatShouldBeCachedWhenFindByTitleThenResultShouldBePutInCache() {
void givenBookThatShouldBeCached_whenFindByTitle_thenResultShouldBePutInCache() {
Optional<Book> dune = repository.findFirstByTitle("Dune");
assertEquals(dune, getCachedBook("Dune"));
}
@Test
void givenBookThatShouldNotBeCachedWhenFindByTitleThenResultShouldNotBePutInCache() {
void givenBookThatShouldNotBeCached_whenFindByTitle_thenResultShouldNotBePutInCache() {
repository.findFirstByTitle("Foundation");
assertEquals(empty(), getCachedBook("Foundation"));