iSharkFly-Docs/java-tutorials
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[BAEL-3841] PR review updates

Browse Source
This commit is contained in:
Adrian Maghear 2020-06-10 19:44:13 +02:00
parent e1a6218c1b
commit ee694afc51
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spring-caching/pom.xml
View File

@ -70,7 +70,7 @@
<dependency> <dependency>
<groupId>net.bytebuddy</groupId> <groupId>net.bytebuddy</groupId>
<artifactId>byte-buddy</artifactId> <artifactId>byte-buddy</artifactId>
<version>1.10.10</version> <version>1.10.11</version>
</dependency> </dependency>
<dependency> <dependency>
<groupId>org.springframework.data</groupId> <groupId>org.springframework.data</groupId>

4
spring-caching/src/test/java/com/baeldung/springdatacaching/repositories/BookRepositoryCachingIntegrationTest.java
View File

@ -64,7 +64,7 @@ public class BookRepositoryCachingIntegrationTest {
} }
@Test @Test
void givenCachedBookWhenFindByTitleThenRepositoryShouldNotBeHit() { void givenCachedBook_whenFindByTitle_thenRepositoryShouldNotBeHit() {
assertEquals(of(DUNE), bookRepository.findFirstByTitle("Dune")); assertEquals(of(DUNE), bookRepository.findFirstByTitle("Dune"));
verify(mock).findFirstByTitle("Dune"); verify(mock).findFirstByTitle("Dune");
@ -75,7 +75,7 @@ public class BookRepositoryCachingIntegrationTest {
} }
@Test @Test
void givenNotCachedBookWhenFindByTitleThenRepositoryShouldBeHit() { void givenNotCachedBook_whenFindByTitle_thenRepositoryShouldBeHit() {
assertEquals(of(FOUNDATION), bookRepository.findFirstByTitle("Foundation")); assertEquals(of(FOUNDATION), bookRepository.findFirstByTitle("Foundation"));
assertEquals(of(FOUNDATION), bookRepository.findFirstByTitle("Foundation")); assertEquals(of(FOUNDATION), bookRepository.findFirstByTitle("Foundation"));
assertEquals(of(FOUNDATION), bookRepository.findFirstByTitle("Foundation")); assertEquals(of(FOUNDATION), bookRepository.findFirstByTitle("Foundation"));

4
spring-caching/src/test/java/com/baeldung/springdatacaching/repositories/BookRepositoryIntegrationTest.java
View File

@ -38,14 +38,14 @@ public class BookRepositoryIntegrationTest {
} }
@Test @Test
void givenBookThatShouldBeCachedWhenFindByTitleThenResultShouldBePutInCache() { void givenBookThatShouldBeCached_whenFindByTitle_thenResultShouldBePutInCache() {
Optional<Book> dune = repository.findFirstByTitle("Dune"); Optional<Book> dune = repository.findFirstByTitle("Dune");
assertEquals(dune, getCachedBook("Dune")); assertEquals(dune, getCachedBook("Dune"));
} }
@Test @Test
void givenBookThatShouldNotBeCachedWhenFindByTitleThenResultShouldNotBePutInCache() { void givenBookThatShouldNotBeCached_whenFindByTitle_thenResultShouldNotBePutInCache() {
repository.findFirstByTitle("Foundation"); repository.findFirstByTitle("Foundation");
assertEquals(empty(), getCachedBook("Foundation")); assertEquals(empty(), getCachedBook("Foundation"));