From 5ca67c9ac774f4f2b98d9eb91bf9f5b3ee5eedfc Mon Sep 17 00:00:00 2001 From: Radhe Sravan Date: Fri, 29 Nov 2019 05:55:33 +0530 Subject: [PATCH 1/2] Fixed the review comments --- .../{list => circularlinkedlist}/CircularLinkedList.java | 4 +--- .../CircularLinkedListUnitTest.java | 4 +++- 2 files changed, 4 insertions(+), 4 deletions(-) rename data-structures/src/main/java/com/baeldung/{list => circularlinkedlist}/CircularLinkedList.java (94%) rename data-structures/src/test/java/com/baeldung/{list => circularlinkedlist}/CircularLinkedListUnitTest.java (93%) diff --git a/data-structures/src/main/java/com/baeldung/list/CircularLinkedList.java b/data-structures/src/main/java/com/baeldung/circularlinkedlist/CircularLinkedList.java similarity index 94% rename from data-structures/src/main/java/com/baeldung/list/CircularLinkedList.java rename to data-structures/src/main/java/com/baeldung/circularlinkedlist/CircularLinkedList.java index d17134a32d..47368d7f15 100644 --- a/data-structures/src/main/java/com/baeldung/list/CircularLinkedList.java +++ b/data-structures/src/main/java/com/baeldung/circularlinkedlist/CircularLinkedList.java @@ -1,4 +1,4 @@ -package com.baeldung.list; +package com.baeldung.circularlinkedlist; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -49,13 +49,11 @@ public class CircularLinkedList { if (currentNode.value == valueToDelete) { head = head.nextNode; tail.nextNode = head; - currentNode = null; } else { do { Node nextNode = currentNode.nextNode; if (nextNode.value == valueToDelete) { currentNode.nextNode = nextNode.nextNode; - nextNode = null; break; } currentNode = currentNode.nextNode; diff --git a/data-structures/src/test/java/com/baeldung/list/CircularLinkedListUnitTest.java b/data-structures/src/test/java/com/baeldung/circularlinkedlist/CircularLinkedListUnitTest.java similarity index 93% rename from data-structures/src/test/java/com/baeldung/list/CircularLinkedListUnitTest.java rename to data-structures/src/test/java/com/baeldung/circularlinkedlist/CircularLinkedListUnitTest.java index 3251182864..28e31c9da8 100644 --- a/data-structures/src/test/java/com/baeldung/list/CircularLinkedListUnitTest.java +++ b/data-structures/src/test/java/com/baeldung/circularlinkedlist/CircularLinkedListUnitTest.java @@ -1,10 +1,12 @@ -package com.baeldung.list; +package com.baeldung.circularlinkedlist; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertTrue; import org.junit.Test; +import com.baeldung.circularlinkedlist.CircularLinkedList; + public class CircularLinkedListUnitTest { @Test From fa28032d48d6cbe79a2b2586139b064659f4a773 Mon Sep 17 00:00:00 2001 From: Radhe Sravan Date: Fri, 29 Nov 2019 05:58:55 +0530 Subject: [PATCH 2/2] Fixed the review comments --- .../baeldung/circularlinkedlist/CircularLinkedListUnitTest.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/data-structures/src/test/java/com/baeldung/circularlinkedlist/CircularLinkedListUnitTest.java b/data-structures/src/test/java/com/baeldung/circularlinkedlist/CircularLinkedListUnitTest.java index 28e31c9da8..5b0573a1ce 100644 --- a/data-structures/src/test/java/com/baeldung/circularlinkedlist/CircularLinkedListUnitTest.java +++ b/data-structures/src/test/java/com/baeldung/circularlinkedlist/CircularLinkedListUnitTest.java @@ -5,8 +5,6 @@ import static org.junit.Assert.assertTrue; import org.junit.Test; -import com.baeldung.circularlinkedlist.CircularLinkedList; - public class CircularLinkedListUnitTest { @Test